Page MenuHomePhabricator
Feed All Stories

Dec 22 2015

epriestley reopened T10037: Branch names are not correct in Drydock working copies as "Open".

That's entirely reasonable, but completely unclear from the task title, reproduction steps, description, or other context here. Here's an example of how you could have filed this task instead to make the root issue more clear:

Dec 22 2015, 2:07 PM · Drydock, Bug Report
epriestley added a comment to T10027: "Wait for Previous Commits" should allow you to specify build plans to wait on.

This task does not describe a problem that is in any way related to reclaiming unused resources or autoscaling hardware pools.

Dec 22 2015, 1:57 PM · Harbormaster, Feature Request
hach-que added a comment to T10037: Branch names are not correct in Drydock working copies.

You don't need to examine the remote branches beyond git fetch, which I'm assuming has already been done when the working copy is fetched. You just need to map the local branches to the remote ones (you can actually just do this cp .git/refs/remotes/origin/* .git/refs/heads).

Dec 22 2015, 1:53 PM · Drydock, Bug Report
hach-que added a comment to T10027: "Wait for Previous Commits" should allow you to specify build plans to wait on.

I don't know of any scenario in which physical hardware or renting virtual machines is cheap?

I am building Harbormaster and Drydock for commercial companies, where the cost of hardware is small compared to the cost of personnel. I believe this to be true for essentially every commercial company. It is true even for us, and we don't pay salaries! We pay more for health insurance than for all development and production hardware combined. Hardware is incredibly cheap compared to personnel -- even personnel who work for free.

Dec 22 2015, 1:44 PM · Harbormaster, Feature Request
epriestley claimed T3967: Build a 2-up preview mode into the fullscreen Remarkup editor.

Building something generalish here may be the best way to unblock D14802, and to reduce the amount of regression behavior from T9905 (I am missing the preview a little myself). I think we need click-to-preview in some cases (mobile, Conpherence) anyway, so my tentative plan is:

Dec 22 2015, 1:34 PM · Remarkup
epriestley added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

Given how much of a backlog there is here and how slowly I've been able to move through it historically, my initial thought is that there may be no mid-term and T5055 is the pathway forward.

Dec 22 2015, 1:22 PM · Lint, Arcanist
epriestley closed T10037: Branch names are not correct in Drydock working copies as Wontfix.

That would needlessly slow down working copy construction in the common case, by adding extra unnecessary steps. Have your build tools examine remote branches instead of local branches, or do this synchronization yourself at the beginning of your build, or wait for T9492 and use "one-time" working copies in exchange for inefficient working copy construction.

Dec 22 2015, 1:21 PM · Drydock, Bug Report
hach-que reopened T10037: Branch names are not correct in Drydock working copies as "Open".

I'm not actually after a "current branch"; I know that there's potentially unlimited branches for the current commit. What I'm interested in is actually having the branches from the remote fetched down as the local branch names, so that "master" locally is the same as "origin/master" and "abcdef" is the same as "origin/abcdef", or to put it another way, as if the repository had been freshly cloned with "git clone".

Dec 22 2015, 1:09 PM · Drydock, Bug Report
epriestley updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Dec 22 2015, 1:07 PM · Lint, Arcanist
epriestley updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Dec 22 2015, 12:59 PM · Lint, Arcanist
epriestley moved T4483: ArcanistCSharpLinter not reporting linter warnings from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:47 PM · Lint, Arcanist
epriestley moved T4701: Linter for <?hh code from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:47 PM · Lint, Arcanist
epriestley moved T6867: Add linter and unit test engine for Go(lang) from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:47 PM · Lint
epriestley moved T7170: Support beta versions of PHP Code Sniffer from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:47 PM · Lint
epriestley moved T7293: Add support for ansible-lint from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:47 PM · Arcanist, Lint
epriestley moved T7780: Add linter for Foodcritic from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Restricted Project, Lint
epriestley moved T8404: Running the cpplint linter through arcanist no longer works from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint, Arcanist
epriestley moved T8474: Fix linter severity customization from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint
epriestley moved T8495: Write a linter wrapper for PHPDCD from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint
epriestley moved T8492: Add a lint wrapper for PHPMD from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint
epriestley moved T8506: LESS Linter does not use path in linter message from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint
epriestley moved T8922: Clarify csharp linter requirements from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint, Documentation, Arcanist
epriestley moved T8978: cslint, used by CSharpArcanistLinter, will be deprecated and replaced in the future from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint, Arcanist
epriestley moved T9047: arc lint can not find php and phpcs from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Windows, Lint, Arcanist
epriestley moved T7653: XUnitTestEngine ignores failures for xUnit 2.0 from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint
epriestley moved T9262: Community and Upstream interests for a flowtype linter from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint
epriestley moved T9518: In diff summary linting error code shown instead of message, when PHP_CodeSniffer linter was used from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint
epriestley moved T9957: Arcanist cpplint install information is out of date from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Restricted Project, Lint, Bug Report
epriestley moved T9734: Cppcheck linter seems to show warnings from other files from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint, Arcanist
epriestley moved T9785: Add ESLint Linter from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint
epriestley moved T9795: Enforce Minimum Required Lint Version from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint
epriestley moved T9796: Add linting support for Elixir from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint, Arcanist
epriestley moved T9870: Include clang-format-lint as a linter from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Restricted Project, Lint, Arcanist
epriestley moved T9886: Add Java linters, checkstyle and PMD from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Restricted Project, Arcanist, Lint
epriestley moved T10038: Plan the mid-term pathway for unit-test/linter bindings from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:44 PM · Lint, Arcanist
epriestley created T10038: Plan the mid-term pathway for unit-test/linter bindings.
Dec 22 2015, 12:44 PM · Lint, Arcanist
OCram awarded T3967: Build a 2-up preview mode into the fullscreen Remarkup editor a Like token.
Dec 22 2015, 12:38 PM · Remarkup
epriestley closed T10035: Can't see the code below SVN as Invalid.

This report doesn't include reproduction steps which allow us to reproduce the issue you're encountering. See Contributing Bug Reports.

Dec 22 2015, 12:35 PM · Bug Report
epriestley closed T10036: Duplicate task status shows as "unknown status" as Resolved.

I believe this was resolved shortly afterward, in connection with T6884.

Dec 22 2015, 12:35 PM · Maniphest, Bug Report
epriestley added a comment to T10027: "Wait for Previous Commits" should allow you to specify build plans to wait on.

I don't know of any scenario in which physical hardware or renting virtual machines is cheap?

Dec 22 2015, 12:28 PM · Harbormaster, Feature Request
epriestley closed T10037: Branch names are not correct in Drydock working copies as Invalid.

There is no such thing as a "current branch" in this sense in the general case. Harbormaster builds commits, and a commit may be on anything between zero and infinity branches, and may be the head of any equal or smaller number of branches.

Dec 22 2015, 11:39 AM · Drydock, Bug Report
hach-que created T10037: Branch names are not correct in Drydock working copies.
Dec 22 2015, 7:51 AM · Drydock, Bug Report
joshuaspence created T10036: Duplicate task status shows as "unknown status".
Dec 22 2015, 7:38 AM · Maniphest, Bug Report
• qzn928 created T10035: Can't see the code below SVN.
Dec 22 2015, 6:59 AM · Bug Report
joshuaspence awarded T9952: Let "Land Revision" target branches other than master a Like token.
Dec 22 2015, 6:40 AM · Differential
joshuaspence edited projects for T9954: Cannot change a fulfiled promise to rejected, added: libphutil; removed Differential, Bug Report.
Dec 22 2015, 5:54 AM · libphutil
joshuaspence reopened T9954: Cannot change a fulfiled promise to rejected as "Open".

I'm going to see if I can make libphutil compatible with this library which might involve some hackery such as in D14523.

Dec 22 2015, 5:53 AM · libphutil
chengyin edited P1911 Masterwork From Distant Lands.
Dec 22 2015, 3:55 AM
epriestley added a comment to T6884: Logging when a task has been marked as a blocker.

(The fix isn't retroactive, but should apply to newly created subtasks.)

Dec 22 2015, 1:37 AM · Transactions, Maniphest
epriestley closed T9890: Version and lock search index rebuilds to reduce the cost of runaway writes as Resolved by committing Restricted Diffusion Commit.
Dec 22 2015, 1:27 AM · Search
hach-que added a comment to T10027: "Wait for Previous Commits" should allow you to specify build plans to wait on.

Hmm, are you expecting that Harbormaster builds will only ever run for a few minutes then? The text in the Drydock documentation seems to indicate that you don't expect people to run builds that take hours.

Dec 22 2015, 1:10 AM · Harbormaster, Feature Request
epriestley added a comment to T10027: "Wait for Previous Commits" should allow you to specify build plans to wait on.

This task seems to describe expected, correct behavior of limit ("builds for one project ... block builds for other projects due to Drydock limits being hit").

Dec 22 2015, 1:08 AM · Harbormaster, Feature Request
hach-que added a comment to T10027: "Wait for Previous Commits" should allow you to specify build plans to wait on.

Anyway, if the intent is that the limit property shouldn't used and it's usage isn't supported, then perhaps it should be removed?

Dec 22 2015, 1:07 AM · Harbormaster, Feature Request
hach-que abandoned D13608: [triggers] Support weekly trigger for scheduling events on different times on different days.
Dec 22 2015, 1:01 AM
epriestley moved T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234" from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:01 AM · Maniphest
epriestley moved T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:01 AM · Maniphest
epriestley moved T4788: Allow "Edit Dependencies" both ways (blocking and depending) from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:01 AM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley moved T5100: Show work board column names as part of task basic information in query results and reference link popups from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:01 AM · Hovercards, Workboards, Maniphest
epriestley moved T5270: Allow creation of a Parent task (new task with a preset dependency) from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:01 AM · Maniphest
epriestley moved T5353: Add visual hint to tasks that are blocked by others from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:01 AM · Custom Fields, Maniphest
epriestley moved T5450: Add support for adding / removing dependent tasks when batch editing tasks from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:00 AM · Maniphest
epriestley moved T5598: Make "T123" in commit title work like "Ref T123" or "Fixes T123" in the body or test plan or a comment from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:00 AM · Differential, Maniphest
epriestley moved T3287: Merging duplicate tasks doesn't migrate dependencies from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:00 AM · Maniphest, Hard
epriestley moved T6027: Way to edit which column a task is in from the task itself from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:00 AM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley moved T6638: Be able to find tasks by "is a blocker to task Y" or "is blocked by task Y" in the search interface from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:00 AM · Restricted Project, Maniphest, Search
epriestley moved T6831: Embedding a mock or a file in a task should add a link in the header from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 1:00 AM · Files, Pholio, Maniphest
epriestley moved T7076: Show status of linked revisions for tasks from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 12:59 AM · Restricted Project, Differential, Maniphest
hach-que added a comment to T10029: PhabricatorRepositoryGitCommitChangeParserWorker is unable to find a commit.

I don't believe so, https://secure.phabricator.com/T4209#146794 clearly states that until that patch lands, daemons and repos must run on the same host.

Dec 22 2015, 12:59 AM · Infrastructure, Daemons
epriestley moved T7820: Add "Closed, Duplicate" option to Status Action in Maniphest from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 12:59 AM · Restricted Project, User Delight, Maniphest
epriestley moved T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 12:59 AM · Maniphest
epriestley moved T8152: Allow Batch Edit of Blocking Task Field from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 12:59 AM · Maniphest
epriestley moved T8232: Automatically claim a task when a differential is submitted from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 12:59 AM · Differential, Maniphest
epriestley moved T8345: Add task tabs for "Mentions" and "Merged" from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 12:59 AM · Restricted Project, FreeBSD, Maniphest
epriestley moved T8796: Display some associated projects on edge task lists from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 12:59 AM · Hovercards, OpenStack, Projects, Maniphest
epriestley moved T9151: Search for Task by parent from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 12:59 AM · Maniphest
epriestley moved T9232: Missing ability to edit attached commits in a task from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 12:59 AM · Maniphest
epriestley moved T10034: Plan the future of Maniphest task relationships from Backlog to Task Relationships on the Maniphest board.
Dec 22 2015, 12:58 AM · Maniphest
hach-que added a comment to T10017: Allow "Lease Working Copy" to just provide an empty folder.

Well my point is that I need some equivalent of "Lease Working Copy" that just provides an empty folder to work in.

Dec 22 2015, 12:56 AM · Drydock, Harbormaster, Feature Request
hach-que added a comment to T10027: "Wait for Previous Commits" should allow you to specify build plans to wait on.

I don't know of any scenario in which physical hardware or renting virtual machines is cheap? That seems like it excludes Drydock from being suitable for literally any system where you need to run commands on machines :/

Dec 22 2015, 12:54 AM · Harbormaster, Feature Request
hach-que added a comment to T10023: Waiting for available resources, but no resources are being created.

I don't know what reliable reproduction steps you expect here. Drydock doesn't really give me any indication as to what it's doing or why it's doing nothing. The screenshots clearly indicate the issue at hand, and the accompanying text indicates what I did to reproduce the issue on my install.

Dec 22 2015, 12:51 AM · Drydock, Bug Report
epriestley closed T6943: Create "basic" and "advanced" modes in Maniphest Search UI as Wontfix.

I think T4100 and design changes elsewhere sharply reduced the need for this, and don't anticipate pursuing it any time soon except perhaps as part of adjacent tasks like T5307 (and maybe T10034 and T4863).

Dec 22 2015, 12:50 AM · Design, Search, Maniphest
epriestley closed T5805: Make custom field visibilty dependent on custom task type field as Wontfix.

I don't currently plan to pursue this, as I think form customization fixes about 80% of this problem by letting you create multiple different create forms (as on this install), and will likely get to 85% or 90% with further refinement.

Dec 22 2015, 12:45 AM · Maniphest
epriestley updated the task description for T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:42 AM · Maniphest
epriestley added a parent task for T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies: T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:37 AM · Maniphest
epriestley added a parent task for T3287: Merging duplicate tasks doesn't migrate dependencies: T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:37 AM · Maniphest, Hard
epriestley added subtasks for T10034: Plan the future of Maniphest task relationships: T3287: Merging duplicate tasks doesn't migrate dependencies, T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies, T4788: Allow "Edit Dependencies" both ways (blocking and depending), T5270: Allow creation of a Parent task (new task with a preset dependency), T5353: Add visual hint to tasks that are blocked by others, T5450: Add support for adding / removing dependent tasks when batch editing tasks, T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships, Unknown Object (Maniphest Task), T6638: Be able to find tasks by "is a blocker to task Y" or "is blocked by task Y" in the search interface, T7820: Add "Closed, Duplicate" option to Status Action in Maniphest, T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries, T8152: Allow Batch Edit of Blocking Task Field, T8345: Add task tabs for "Mentions" and "Merged", T9151: Search for Task by parent.
Dec 22 2015, 12:37 AM · Maniphest
epriestley added a parent task for T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Customer Impact, Maniphest, Differential
epriestley added a parent task for T4788: Allow "Edit Dependencies" both ways (blocking and depending): T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a parent task for T5270: Allow creation of a Parent task (new task with a preset dependency): T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Maniphest
epriestley added a parent task for T5450: Add support for adding / removing dependent tasks when batch editing tasks: T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Maniphest
epriestley added a parent task for T6638: Be able to find tasks by "is a blocker to task Y" or "is blocked by task Y" in the search interface: T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Restricted Project, Maniphest, Search
epriestley added a parent task for T5353: Add visual hint to tasks that are blocked by others: T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Maniphest, Custom Fields
epriestley added a parent task for T8345: Add task tabs for "Mentions" and "Merged": T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Restricted Project, FreeBSD, Maniphest
epriestley added a parent task for T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries: T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Maniphest
epriestley added a parent task for T8152: Allow Batch Edit of Blocking Task Field: T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Maniphest
epriestley added a parent task for T7820: Add "Closed, Duplicate" option to Status Action in Maniphest: T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Restricted Project, User Delight, Maniphest
epriestley added a parent task for T9151: Search for Task by parent: T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:36 AM · Maniphest
epriestley created T10034: Plan the future of Maniphest task relationships.
Dec 22 2015, 12:33 AM · Maniphest
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 22 2015, 12:31 AM · ApplicationEditor
epriestley closed T6884: Logging when a task has been marked as a blocker as Resolved.
  • D14849 should fix messaging around "Create Subtask".
  • I'm likewise unable to reproduce the original issue at HEAD, so I suspect it may have been fixed elsewhere. If anyone has repro steps that work at HEAD, let us know.
Dec 22 2015, 12:31 AM · Transactions, Maniphest