Page MenuHomePhabricator
Create Task
Maniphest T6867

Add linter and unit test engine for Go(lang)
Open, WishlistPublic
Actions

Description

Currently for Go(lang) there's a test result parser in GoTestResultParser.php. It'll be good to extend unit test engine to support the following:

  • coverage report

Also following are popular golang linters to have:

  • gofmt
  • golint
  • go vet

Revisions and Commits

rARC Arcanist
Needs ReviewD12621 Add a Go unit test engine with support for Race and Godep.
Needs ReviewD12620 Add GoFmt linter
AbandonedD12598 Add a Go unit test engine with race detection (through go and godep).
AbandonedD12546 Add support for the race detector in the parser
AbandonedD12537 Add a Go unit test engine (through go and godep).
Needs RevisionD12120 Add GoVet Linter

Related Objects

Event Timeline

roylou created this task.Jan 5 2015, 10:03 AM
roylou raised the priority of this task from to Needs Triage.
roylou updated the task description. (Show Details)
roylou added a project: Lint.
roylou added a subscriber: roylou.
chad triaged this task as Wishlist priority.Jan 5 2015, 2:58 PM
cburroughs added a subscriber: cburroughs.Jan 5 2015, 4:51 PM
joshuaspence added a subscriber: joshuaspence.Jan 5 2015, 8:18 PM
roylou added a subscriber: chad.Jan 14 2015, 6:49 AM

Hi @chad, we're working on a a project using golang and phabricator. I can submit a diff to for those functionalities. Please let me know if it sounds good to you.

joshuaspence added a comment.Jan 14 2015, 7:06 AM

What exactly are you looking for? There is an existing golang linter which wraps go lint.

roylou added a comment.Jan 14 2015, 7:33 AM

Oh I didn't notice there's an existing ArcanistGoLintLinter. Thanks for pointing out. This is what I think missing:

  • A linter that wraps go vet
  • A linter that warps gofmt
  • Add coverage support in ArcanistGoTestResultParser
sectioneight added a subscriber: sectioneight.Mar 20 2015, 9:23 PM
sectioneight added a revision: D12120: Add GoVet Linter.Mar 20 2015, 10:28 PM
eMxyzptlk added a subscriber: eMxyzptlk.Apr 24 2015, 6:51 AM
eMxyzptlk added revisions: D12537: Add a Go unit test engine (through go and godep)., D12546: Add support for the race detector in the parser, D12598: Add a Go unit test engine with race detection (through go and godep)..Apr 30 2015, 1:41 AM
eMxyzptlk added a revision: D12620: Add GoFmt linter.Apr 30 2015, 5:43 AM
eMxyzptlk added a revision: D12621: Add a Go unit test engine with support for Race and Godep..Apr 30 2015, 10:37 AM
joshuaspence claimed this task.May 26 2015, 10:03 PM
• ryansking added a subscriber: • ryansking.Jul 9 2015, 8:13 PM
eMxyzptlk added a comment.Jul 16 2015, 7:26 AM

Not sure where this is going but I believe it's still on hold. I've release https://github.com/kalbasit/arcanist-go that I'm using personally and also at work. @joshuaspence and @chad please let me know when the Phabricator team is ready to accept these patches and I'll update all of my differentials.

ox added a subscriber: ox.Jul 30 2015, 2:03 PM
epriestley moved this task from Backlog to Bindings on the Lint board.Dec 22 2015, 12:47 PM
epriestley mentioned this in T10038: Plan the mid-term pathway for unit-test/linter bindings.Dec 22 2015, 12:59 PM
otto.bretz added a subscriber: otto.bretz.Jan 5 2016, 3:26 PM
• jazzdan added a subscriber: • jazzdan.Jan 19 2016, 2:57 PM
thomasthep added a subscriber: thomasthep.Oct 19 2016, 9:25 AM
hskiba added a subscriber: hskiba.Jan 14 2021, 9:41 AM
Phabricator · Built by Phacility