Page MenuHomePhabricator

Cppcheck linter seems to show warnings from other files
Open, Needs TriagePublic

Description

I ran arc lint -- support/xhpast/ast.hpp in rPHU and was shown a warning for support/xhpast/astnode.hpp:

> arc lint -- support/xhpast/ast.hpp 
>>> Lint for support/xhpast/astnode.hpp:


   Warning  (Cppcheck) noExplicitConstructor
    Class 'Node' has a constructor with 1 argument that is not explicit.

              40         l_tok(-1),
              41         r_tok(-1) {}
              42 
    >>>       43       Node(unsigned int type) :
              44         type(type),
              45         l_tok(-1),
              46         r_tok(-1) {}

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added projects: Arcanist, Lint.
joshuaspence added a subscriber: joshuaspence.
epriestley moved this task from Backlog to Bindings on the Lint board.Dec 22 2015, 12:45 PM