Page MenuHomePhabricator

Include clang-format-lint as a linter
Open, Needs TriagePublic

Description

clang-format is a helpful linting tool for C/C++/Objective-C.

clang-format-linter makes it easy to use clang-format with arcanist as a linter.

Would it be reasonable to add clang-format-linter to the included set of linters in arcanist? I see that there are other arcanist linters listed in the Community Resources page, so I'd be happy to just add a link there if that's preferable.

Event Timeline

featherless updated the task description. (Show Details)
featherless added a project: Arcanist.
featherless added a subscriber: featherless.
featherless updated the task description. (Show Details)Nov 29 2015, 4:21 AM
joshuaspence added a subscriber: joshuaspence.

I think it would be nice to have out-of-the-box support for the clang linter.

avivey added a subscriber: avivey.Nov 30 2015, 7:36 PM

I think adding it in the Community Resources is a good move:

  • It will let users use it right away
  • You can collect feedback and fix stuff while it's there
  • The wait time for upstreaming linters is very long (It's essentially a special integration, with all the costs of one). So getting it somewhere in the meanwhile makes sense.
vhbit added a comment.Dec 1 2015, 9:49 AM

clang-format-linter author here. I somehow missed the Community Resources page and yep ATM it's definitely a better place for this linter (alongside with one for Swift code).

BTW, what are requirements for linter to be upstreamed so I can keep them in mind?

Your Github repository is a nice reference. I will do the same for T9797

avivey added a comment.Dec 1 2015, 6:50 PM
In T9870#146277, @vhbit wrote:

BTW, what are requirements for linter to be upstreamed so I can keep them in mind?

See https://secure.phabricator.com/book/phabcontrib/article/contributing_code/ and Q106; There's no hard-and-fast rule for this, but maintenance cost is very important.

epriestley moved this task from Backlog to Bindings on the Lint board.Dec 22 2015, 12:45 PM
eadler added a project: Restricted Project.Jan 11 2016, 9:39 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jan 11 2016, 9:42 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:10 PM