Page MenuHomePhabricator
Feed Advanced Search

Feb 8 2017

epriestley merged T12158: Possible JS error in Phortune when adding new card into T12232: Phortune "add payment method" erroring out on submission.
Feb 8 2017, 5:15 PM · Phortune, Bug Report
epriestley added a comment to T12232: Phortune "add payment method" erroring out on submission.

You destroyed the original file in Files too, right?

Feb 8 2017, 5:15 PM · Phortune, Bug Report
epriestley added a comment to T12172: Better color scheme for diffs.

No problem, we're not in any rush.

Feb 8 2017, 5:11 PM · Accessibility, Feature Request
OCram awarded T12134: Develop a Nuance-based Phabricator reporting/support flow a Like token.
Feb 8 2017, 6:14 AM · Abuse
epriestley added a comment to T12227: Restrict ProfileMenuItem by location.

You should be able to implement canAddToObject() to do this. If you want a Home-only item, implement it like this:

Feb 8 2017, 3:18 AM · Profile Menu Item

Feb 7 2017

epriestley added a comment to T8937: Unclear exception when patching non-existant revision.

I'm going to fix this Real Soon, I absolutely Definitely Promise 100% ™ ®. But I'll accept a patch from a reputable contributor like @jcox any day.

Feb 7 2017, 9:00 PM · Arcanist
joshuaspence added a comment to I2 Donate to Phacility.

Macro awwyiss2:

Feb 7 2017, 8:54 PM · Phacility
epriestley edited this Badge.
Feb 7 2017, 8:51 PM
joshuaspence added a comment to I2 Donate to Phacility.

Can haz badge??? 🍺

Feb 7 2017, 8:49 PM · Phacility
joshuaspence backed I2 Donate to Phacility with $3.00 USD.
Feb 7 2017, 8:47 PM · Phacility
joshuaspence backed I2 Donate to Phacility with $1.00 USD.
Feb 7 2017, 8:43 PM · Phacility
joshuaspence added a comment to T8937: Unclear exception when patching non-existant revision.

I don't believe this is related to E being set in variables_order.

Feb 7 2017, 8:40 PM · Arcanist
epriestley added a comment to T10390: Dashboards v2 (UX).

Generally makes sense to me.

Feb 7 2017, 5:08 PM · Dashboards (v2)
epriestley created E1370: Last-Minute Pup Adventures.
Feb 7 2017, 4:32 PM
epriestley updated the task description for T12224: Phortune "Autopay" on View controller does not respect disabled payment methods.
Feb 7 2017, 3:23 PM · Phortune
epriestley created T12224: Phortune "Autopay" on View controller does not respect disabled payment methods.
Feb 7 2017, 3:22 PM · Phortune
epriestley reopened T12213: Task title is truncated in task graph, even if there is enough space as "Open".
Feb 7 2017, 2:09 PM · Maniphest, Bug Report
liuxinyu970226 awarded T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches a Like token.
Feb 7 2017, 12:01 AM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search

Feb 6 2017

epriestley added a comment to T2794: Implement Phage (like Hypershell).

Per T12218, the Phacility cluster is reaching a scale (~50 devices) where we need to improve tooling over "open a bunch of terminal windows". I want to look at implementing Phage for this use case and see how far I can get.

Feb 6 2017, 9:54 PM · Phage, Infrastructure
epriestley added a parent task for T2794: Implement Phage (like Hypershell): T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 8:51 PM · Phage, Infrastructure
epriestley added a subtask for T12218: Reduce the operational cost of a larger Phacility cluster: T2794: Implement Phage (like Hypershell).
Feb 6 2017, 8:51 PM · Ops, Phacility
epriestley merged task T9374: Allow `bin/remote` commands to operate on a range of hosts into T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 8:51 PM · Ops, Phacility
epriestley merged T9374: Allow `bin/remote` commands to operate on a range of hosts into T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 8:51 PM · Ops, Phacility
epriestley changed the visibility for T2794: Implement Phage (like Hypershell).
Feb 6 2017, 8:51 PM · Phage, Infrastructure
epriestley added a comment to T12219: Some MP4 videos do not play in Chrome.

Yeah, same here. Both videos are of similar size (1.6MB vs 2.1MB) and both appear to legitimately be MP4 / H264 videos (neither is some kind of obviously spooky magic like an AVI named .mp4).

Feb 6 2017, 5:39 PM · Files
epriestley updated subscribers of T12219: Some MP4 videos do not play in Chrome.
Feb 6 2017, 5:34 PM · Files
epriestley added a comment to T12219: Some MP4 videos do not play in Chrome.

Here's what I see in Chrome at time of writing:

Feb 6 2017, 5:34 PM · Files
epriestley created T12219: Some MP4 videos do not play in Chrome.
Feb 6 2017, 5:33 PM · Files
epriestley closed T12209: "Services" application is a launchable, listed application but should be a sneaky stealth application as Resolved by committing Restricted Diffusion Commit.
Feb 6 2017, 5:32 PM · Applications, Phacility
epriestley added a revision to T12209: "Services" application is a launchable, listed application but should be a sneaky stealth application: Unknown Object (Differential Revision).
Feb 6 2017, 5:27 PM · Applications, Phacility
epriestley created T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 5:14 PM · Ops, Phacility
epriestley added a comment to T12214: Navigation menus in applications have no maximum width.

(Maybe the real user report was something only indirectly related, like putting the query on a Dashboard? That would make sense given that the name talks about dashboards...)

Feb 6 2017, 4:58 PM · PHUI
epriestley added a comment to T12214: Navigation menus in applications have no maximum width.

I think it should use the same global/personal paradigm (let administrators save Global queries, supplementing the current ability for users to save personal queries).

Feb 6 2017, 4:55 PM · PHUI
epriestley closed T12215: Bad session URL in http://PHABRICATOR/people/logs/ as Resolved by committing Restricted Diffusion Commit.
Feb 6 2017, 4:38 PM · People, Bug Report
epriestley closed T12216: User can change userpic when account.editable is false (bad config description or restrictions mistake) as Resolved by committing Restricted Diffusion Commit.
Feb 6 2017, 4:37 PM · Profile, Config, Bug Report
epriestley created T12217: Reduce the hardware cost of Phacility free instances.
Feb 6 2017, 4:02 PM · Ops, Phacility
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

We queried a subset of instances for the date of the most recent session activity, to estimate the impact of requiring free instances to log in periodically to remain active:

Feb 6 2017, 3:17 PM · Phacility
epriestley added a revision to T12216: User can change userpic when account.editable is false (bad config description or restrictions mistake): Unknown Object (Differential Revision).
Feb 6 2017, 1:02 PM · Profile, Config, Bug Report
epriestley added a comment to T12216: User can change userpic when account.editable is false (bad config description or restrictions mistake).

I think I'm just going to remove the "profile picture" text from the description to resolve this. The account.editable option is very old and I'd eventually like to remove it, but making the description more clear is an easier fix for now.

Feb 6 2017, 12:59 PM · Profile, Config, Bug Report
epriestley added a comment to T12215: Bad session URL in http://PHABRICATOR/people/logs/.

Thanks! I believe I broke this in D15165, a little more than a year ago.

Feb 6 2017, 12:34 PM · People, Bug Report
epriestley added a revision to T12215: Bad session URL in http://PHABRICATOR/people/logs/: Unknown Object (Differential Revision).
Feb 6 2017, 12:30 PM · People, Bug Report
epriestley closed T12213: Task title is truncated in task graph, even if there is enough space as Invalid.

With text-overflow: ellipsis; and no truncation:

Feb 6 2017, 12:23 PM · Maniphest, Bug Report
epriestley closed T12212: New Feature Task Test as Invalid.
Feb 6 2017, 12:08 PM · Sample Project, Feature Request
epriestley created T12214: Navigation menus in applications have no maximum width.
Feb 6 2017, 12:07 PM · PHUI
toolmantim awarded T12173: Support Buildkite as a Harbormaster target a Mountain of Wealth token.
Feb 6 2017, 5:09 AM · Harbormaster, Phacility
epriestley closed T12204: Could not read from remote repository. as Invalid.

See this document for instructions on getting Phacility support:

Feb 6 2017, 4:30 AM · Bug Report
sj26 awarded T12173: Support Buildkite as a Harbormaster target a Love token.
Feb 6 2017, 12:47 AM · Harbormaster, Phacility

Feb 5 2017

epriestley added a comment to T12211: phabricator-home css doesn't get applied to dashboards on home.

(Or whatever more nuanced version of things you want to do. But that's the current fate/rationale of phabricator-home.)

Feb 5 2017, 2:31 PM · Profile Menu Item, Dashboards, Bug Report
epriestley added a comment to T12211: phabricator-home css doesn't get applied to dashboards on home.

.phabricator-home makes the menu full-screen on mobile, so it's currently only applied to /.

Feb 5 2017, 2:30 PM · Profile Menu Item, Dashboards, Bug Report
epriestley added a comment to T12209: "Services" application is a launchable, listed application but should be a sneaky stealth application.

ayep

Feb 5 2017, 5:31 AM · Applications, Phacility
epriestley added a comment to T12209: "Services" application is a launchable, listed application but should be a sneaky stealth application.

From the home page, you can uninstall Home like this:

Feb 5 2017, 5:28 AM · Applications, Phacility
epriestley created T12209: "Services" application is a launchable, listed application but should be a sneaky stealth application.
Feb 5 2017, 5:26 AM · Applications, Phacility
chad awarded T12207: Sort out the great Dashboard column editing mess a Baby Tequila token.
Feb 5 2017, 12:29 AM · Dashboards (v2)
epriestley added a revision to T12207: Sort out the great Dashboard column editing mess: Unknown Object (Differential Revision).
Feb 5 2017, 12:16 AM · Dashboards (v2)
epriestley added a comment to T12174: Home Menu Errata.

Put this workflow inside "Edit Menu"

Feb 5 2017, 12:12 AM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

Two possible alternatives to crumbs I can come up with, although I don't love either:

Feb 5 2017, 12:11 AM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

One other thought: it might be nice to provide a way to get to the dashboard from the dashboard-in-a-menu view. Currently, there's no way to "Edit This Dashboard" from Home or Projects: you have to go to Dashboards, hunt it down, and then manage things from there.

Feb 5 2017, 12:04 AM · Dashboards (v2), Profile Menu Item

Feb 4 2017

epriestley updated the task description for T12207: Sort out the great Dashboard column editing mess.
Feb 4 2017, 11:56 PM · Dashboards (v2)
epriestley updated the task description for T12207: Sort out the great Dashboard column editing mess.
Feb 4 2017, 11:46 PM · Dashboards (v2)
epriestley added a project to T12207: Sort out the great Dashboard column editing mess: Dashboards.
Feb 4 2017, 11:46 PM · Dashboards (v2)
epriestley added a parent task for T10612: Editing a panel causes it to duplicate in dashboard: T12207: Sort out the great Dashboard column editing mess.
Feb 4 2017, 11:45 PM · Dashboards (v2), Bug Report
epriestley added subtasks for T12207: Sort out the great Dashboard column editing mess: T10145: Adding a panel to a dashboard multiple times, T10612: Editing a panel causes it to duplicate in dashboard.
Feb 4 2017, 11:45 PM · Dashboards (v2)
epriestley added a parent task for T10145: Adding a panel to a dashboard multiple times: T12207: Sort out the great Dashboard column editing mess.
Feb 4 2017, 11:45 PM · Dashboards (v2), Bug Report
epriestley created T12207: Sort out the great Dashboard column editing mess.
Feb 4 2017, 11:44 PM · Dashboards (v2)
epriestley closed T12199: only some CSS and JS files inaccessible after switching to https as Invalid.

Sounds good, let us know if you come up with repro steps.

Feb 4 2017, 8:04 PM · Bug Report (Needs Information)
epriestley added a comment to T12173: Support Buildkite as a Harbormaster target.

This is now available in the Phacility cluster. It appeared to work correctly on a test instance:

Feb 4 2017, 4:36 PM · Harbormaster, Phacility
epriestley edited the content of Changelog.
Feb 4 2017, 3:13 AM
epriestley created 2017 Week 5 (Early February).
Feb 4 2017, 3:13 AM
epriestley added a comment to T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR.

The spooky emoji and icons are real lackluster, barely a respectable spook in the lot: 👻 💀 ☠ 🍖

Feb 4 2017, 2:41 AM · Dashboards, Bug Report
epriestley closed T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR as Resolved by committing Restricted Diffusion Commit.
Feb 4 2017, 2:34 AM · Dashboards, Bug Report
epriestley added a comment to T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR.

D17311 makes this stop fataling, but you're stuck with the panel for now. This should get fixed soon, but I don't want to try to sneak anything more ambitious in before the release cut.

Feb 4 2017, 2:34 AM · Dashboards, Bug Report
epriestley added a revision to T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR: Unknown Object (Differential Revision).
Feb 4 2017, 2:33 AM · Dashboards, Bug Report
epriestley added a comment to T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR.

tyvm 🙏

Feb 4 2017, 2:27 AM · Dashboards, Bug Report
epriestley added a comment to T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR.

Was the sequence of actions like this:

Feb 4 2017, 2:25 AM · Dashboards, Bug Report
epriestley added a comment to T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR.

I can't reproduce this: removing panels from dashboards works fine for me:

Feb 4 2017, 1:44 AM · Dashboards, Bug Report

Feb 3 2017

epriestley added a comment to T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes".

"Bizarro Gremlin" is just an alias for Quicksand

Feb 3 2017, 10:05 PM · Diffusion, Differential, Bug Report
epriestley merged T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes" into T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Feb 3 2017, 9:59 PM · Quicksand, Bug Report
epriestley merged task T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes" into T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Feb 3 2017, 9:59 PM · Diffusion, Differential, Bug Report
epriestley added a comment to T12200: Typeahead completion (of any kind) does not work with Persistent Chat on.

🙉

Feb 3 2017, 8:44 PM · Conpherence (v4), Quicksand, Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

I think we currently don't really try to handle these cases:

Feb 3 2017, 7:31 PM · PHUI, Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

That tip probably does not fit on screen in any of the orientations: it obviously won't fit to the north or east. If we try to put it to the south, part of it will be offscreen to the right. If we try to put it to the west, part of it will be off the top of the screen (the rectangle we use to detect the size of the tip box is slightly larger than the actual pixel size of the tip because we get weird scrollbar interactions if we use the size of the tip exactly).

Feb 3 2017, 7:28 PM · PHUI, Bug Report
friesenschrauber awarded T7930: Let Calendar provide date services to other applications a Love token.
Feb 3 2017, 7:28 PM · Calendar
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

My trick is:

Feb 3 2017, 7:25 PM · PHUI, Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

Here's what I see:

Feb 3 2017, 7:24 PM · PHUI, Bug Report
epriestley added a comment to T12174: Home Menu Errata.

Yeah, I don't think I fixed it. I tried this set of steps at master prior to D17308:

Feb 3 2017, 7:01 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

I'm not sure if I actually fixed @rphl's issue or not. D17308 was just aimed at the existing issue under the theory that we'll see more of it after this ships if we aren't already seeing it, but his report definitely might be a new issue.

Feb 3 2017, 6:55 PM · Dashboards (v2), Profile Menu Item
epriestley updated the task description for T12174: Home Menu Errata.
Feb 3 2017, 6:27 PM · Dashboards (v2), Profile Menu Item
epriestley added a revision to T8033: Inform editor when panels have more restrictive policy than dashboard: Unknown Object (Differential Revision).
Feb 3 2017, 5:58 PM · Dashboards
epriestley added a revision to T12174: Home Menu Errata: Unknown Object (Differential Revision).
Feb 3 2017, 5:58 PM · Dashboards (v2), Profile Menu Item
epriestley added a revision to T12174: Home Menu Errata: Unknown Object (Differential Revision).
Feb 3 2017, 5:22 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12197: Audits are no longer triggered using singular "Auditor:".

This should now be resolved at HEAD of master, and should promote to stable later today.

Feb 3 2017, 5:15 PM · Audit, Bug Report
epriestley closed T12197: Audits are no longer triggered using singular "Auditor:" as Resolved by committing Restricted Diffusion Commit.
Feb 3 2017, 5:14 PM · Audit, Bug Report
brianespinosa awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Feb 3 2017, 4:02 PM · Workboards (v3), Restricted Project
epriestley renamed T12197: Audits are no longer triggered using singular "Auditor:" from Audits are no longer triggered using Auditor: or Auditors: to Audits are no longer triggered using singular "Auditor:".
Feb 3 2017, 3:01 PM · Audit, Bug Report
epriestley added a comment to T12197: Audits are no longer triggered using singular "Auditor:".

Thanks! I think this is the timeline of events:

Feb 3 2017, 2:31 PM · Audit, Bug Report
epriestley added a revision to T12197: Audits are no longer triggered using singular "Auditor:": Unknown Object (Differential Revision).
Feb 3 2017, 2:18 PM · Audit, Bug Report
epriestley added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

Per above, it sounds like upgrading fixed what you were seeing?

Feb 3 2017, 1:23 PM · Bug Report
epriestley renamed T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts from `arc liberate` fails on Phabricator mysteriously with PHP 7.1 to `arc liberate` fails on Phabricator miraculously with PHP 7.1.
Feb 3 2017, 1:15 PM · Bug Report
epriestley edited projects for T12199: only some CSS and JS files inaccessible after switching to https, added: Bug Report (Needs Information); removed Bug Report.

This isn't a bug report we can accept upstream. See Contributing Bug Reports for help. In particular:

Feb 3 2017, 1:14 PM · Bug Report (Needs Information)
epriestley added a comment to T12197: Audits are no longer triggered using singular "Auditor:".

Does that explain what you're seeing locally?

Feb 3 2017, 12:32 PM · Audit, Bug Report