Page MenuHomePhabricator

phabricator-home css doesn't get applied to dashboards on home
Closed, ResolvedPublic

Description

  • Add a non default dashboard into your home menu
  • Click on it

Expect:
No sidebar background

Get:
Sidebar background

.phabricator-home should be applied, but the correct fix is likely to make dashboard views (proj + home) have a transparent sidebar. Will look tomorrow

Revisions and Commits

Restricted Differential Revision

Event Timeline

.phabricator-home makes the menu full-screen on mobile, so it's currently only applied to /.

We probably need two classes, one make-the-menu-look-different class (always on) and one make-the-menu-fullscreen-on-mobile class (only applied on /).

(Or whatever more nuanced version of things you want to do. But that's the current fate/rationale of phabricator-home.)

Or get rid of the darker sidebar. I think it's only needed on projects/profiles

chad added a revision: Restricted Differential Revision.Feb 6 2017, 6:52 PM
chad closed this task as Resolved by committing Restricted Diffusion Commit.Feb 6 2017, 7:06 PM
chad added a commit: Restricted Diffusion Commit.