Page MenuHomePhabricator
Create Task
Maniphest T12211

phabricator-home css doesn't get applied to dashboards on home
Closed, ResolvedPublic
Actions

Description

  • Add a non default dashboard into your home menu
  • Click on it

Expect:
No sidebar background

Get:
Sidebar background

.phabricator-home should be applied, but the correct fix is likely to make dashboard views (proj + home) have a transparent sidebar. Will look tomorrow

Revisions and Commits

rP Phabricator
D17321rP1f4a89b613a6 More minor CSS tweaks globally

Event Timeline

chad created this task.Feb 5 2017, 7:09 AM
chad added projects: Bug Report, Dashboards, Profile Menu Item.
Herald added a subscriber: eadler. · View Herald TranscriptFeb 5 2017, 7:09 AM
epriestley added a subscriber: epriestley.Feb 5 2017, 2:30 PM

.phabricator-home makes the menu full-screen on mobile, so it's currently only applied to /.

We probably need two classes, one make-the-menu-look-different class (always on) and one make-the-menu-fullscreen-on-mobile class (only applied on /).

epriestley added a comment.Feb 5 2017, 2:31 PM

(Or whatever more nuanced version of things you want to do. But that's the current fate/rationale of phabricator-home.)

chad added a comment.Feb 5 2017, 5:53 PM

Or get rid of the darker sidebar. I think it's only needed on projects/profiles

chad added a revision: D17321: More minor CSS tweaks globally.Feb 6 2017, 6:52 PM
chad closed this task as Resolved by committing rP1f4a89b613a6: More minor CSS tweaks globally.Feb 6 2017, 7:06 PM
chad added a commit: rP1f4a89b613a6: More minor CSS tweaks globally.
Phabricator · Built by Phacility