Page MenuHomePhabricator
Create Task
Maniphest T12232

Phortune "add payment method" erroring out on submission
Closed, ResolvedPublic
Actions

Assigned To
epriestley
Authored By
yelirekim
Feb 8 2017, 5:10 PM
Tags
Referenced Files
F4910889: Screen Shot 2017-04-17 at 7.40.52 AM.png
Apr 17 2017, 2:41 PM
F4910870: Screen Shot 2017-04-17 at 10.32.44 AM.png
Apr 17 2017, 2:34 PM
F2674849: Screen Shot 2017-02-08 at 12.06.13 PM.png
Feb 8 2017, 5:11 PM
Unknown Object (File)
Feb 8 2017, 5:10 PM
Subscribers
eadler
epriestley
ftdysa
revi
yelirekim

Description

I was just trying to buy you some beer.

Screen Shot 2017-02-08 at 12.06.13 PM.png (1×2 px, 307 KB)

Revisions and Commits

rP Phabricator
D17333rP4039f5f11b71 Don't try to access the Stripe object until the user submits the credit card…

Related Objects

Event Timeline

yelirekim created this task.Feb 8 2017, 5:10 PM
yelirekim updated the task description. (Show Details)

Edited to not give out my credit card number on the internet.

epriestley added a subscriber: epriestley.Feb 8 2017, 5:15 PM

You destroyed the original file in Files too, right?

This is probably the same as T12158 but I'll merge that here since this is a more complete description.

epriestley merged a task: T12158: Possible JS error in Phortune when adding new card.Feb 8 2017, 5:15 PM
epriestley added a project: Phortune.
epriestley added subscribers: ftdysa, revi, eadler.
yelirekim added a comment.Feb 8 2017, 5:16 PM

Yeah I clicked "Delete File" and can't see it anywhere now.

epriestley added a comment.Feb 8 2017, 5:26 PM
In T12232#210902, @yelirekim wrote:

Yeah I clicked "Delete File" and can't see it anywhere now.

😎 👍 :caprisun: 🌞 🏄 🌊 :sunmbrella: 🍨 🍦 🍧

epriestley added a comment.Feb 10 2017, 4:30 PM

I'm having some trouble reproducing this -- I tried Safari and Chrome here and in my sandbox. You aren't using anything weird, right?

I think what's happening is that we include Stripe's Javascript with a normal <script /> tag, and then somehow manage to win a race against it and run before it defines the Stripe object, but I'm not sure how that's possible. We can have our behavior sit there waiting for Stripe to become defined, but I'd like to be able to reproduce this and understand what the underlying issue is before we do that.

epriestley added a revision: D17333: Don't try to access the Stripe object until the user submits the credit card form.Feb 10 2017, 4:35 PM
epriestley added a commit: rP4039f5f11b71: Don't try to access the Stripe object until the user submits the credit card….Feb 10 2017, 4:40 PM
epriestley added a comment.Feb 10 2017, 4:44 PM

D17333 is a probable fix without needing to resort to a bunch of weird setInterval() juggling. I've pushed that here, let me know if you're still seeing the issue? If you are, does your JS console have anything in it?

You may want to test the workflow where you give us money several times to make sure it works reliably.

epriestley mentioned this in T12307: Users unable to add new credit cards to Autopay?.Feb 22 2017, 12:41 PM
epriestley closed this task as Resolved.Apr 7 2017, 12:54 PM
epriestley claimed this task.

While we haven't been showered in free money, I also haven't seen more reports of this so I'm going to presume it's resolved.

yelirekim reopened this task as Open.Apr 17 2017, 2:34 PM

Just tried again.

Screen Shot 2017-04-17 at 10.32.44 AM.png (1×2 px, 520 KB)

epriestley added a comment.Apr 17 2017, 2:36 PM

Does this resource load for you?

https://js.stripe.com/v2/

Should look like:

/*! stripe-js 22-03-2017 */
(function(){var a,b,c,d,e,f,g,h,i,j,k,l,m,n={}.hasOwnProperty,...
yelirekim added a comment.Apr 17 2017, 2:38 PM

Yeah.

epriestley added a comment.Apr 17 2017, 2:40 PM

(Also, do you run some browser extension like "disable all external Javascript so ads don't work"?)

I assume those little icons are "stealthy robot who disables all external Javascript", "Stop external Javascript from working", and "hide my identity from external javascript by preventing it from executing".

epriestley added a comment.Apr 17 2017, 2:41 PM

Maybe a simpler empirical test is, on the "Add Payment Method" page, does this work in the developer console?

Stripe

Screen Shot 2017-04-17 at 7.40.52 AM.png (110×539 px, 13 KB)

yelirekim added a comment.Apr 17 2017, 2:41 PM

No nothing like that but FWIW, it just worked when I tried to reproduce it again.

epriestley closed this task as Resolved.Apr 17 2017, 2:44 PM

Alright, I'm going to assume this was cache/ghosts until it happens to someone else since it seems like no reproduction case exists anywhere anymore.

yelirekim added a comment.Apr 17 2017, 2:45 PM

Yeah I just wanted to buy myself a badge.

epriestley added a comment.Apr 17 2017, 2:54 PM

You are now officially Pay2Win.

Phabricator · Built by Phacility