Page MenuHomePhabricator
Feed Advanced Search

Jan 11 2017

epriestley added a comment to T11114: Move Differential to EditEngine.

If you'd like us to look at it, please file a separate bug report with reproduction instructions, following the guide in Contributing Bug Reports.

Jan 11 2017, 5:34 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley removed a project from T9741: Default Edit Policy for Differential: Abuse.
Jan 11 2017, 5:03 PM · Differential
epriestley removed a subtask for T10215: Provide tools to combat and recover from abuse: T9741: Default Edit Policy for Differential.
Jan 11 2017, 5:03 PM · Abuse
epriestley removed a parent task for T9741: Default Edit Policy for Differential: T10215: Provide tools to combat and recover from abuse.
Jan 11 2017, 5:03 PM · Differential
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 11 2017, 4:48 PM · Audit
epriestley added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Awesome! Sorry for the churn here -- I think we have a brighter future on the other side, but have to break a few eggs to get there.

Jan 11 2017, 4:32 PM · Bug Report
epriestley closed T12096: How to remove rule to make me reviewer as Invalid.

This does not describe a bug in Phabricator. See Support Resources for help understanding available support resourecs.

Jan 11 2017, 4:29 PM · Bug Report
epriestley added a comment to T12094: Upgrade from Jun 18 2014.

Okay, I saw php7.1-mysql and just wanted to make sure you were aware.

Jan 11 2017, 4:20 PM · Support Request
epriestley added a comment to T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.

Although I earlier (in T6630#85282) felt like it was reasonable to consider separating Audit and Diffusion, there are now more existing or planned integration points and I think this approach is significantly less reasonable than the "merge them" approach. It also doesn't seem to be causing any problems on real installs.

Jan 11 2017, 4:17 PM · Audit, Diffusion, Wikimedia
epriestley renamed T12095: Differential reads and writes draft status to different tables, leading to various UI inconsistencies from "Unsubmitted Comments" after deletion of comment to Differential reads and writes draft status to different tables, leading to various UI inconsistencies.
Jan 11 2017, 4:08 PM · Differential, Bug Report
epriestley added a comment to T12095: Differential reads and writes draft status to different tables, leading to various UI inconsistencies.

This doesn't reproduce for me and we don't support third-party code, but it's entangled with T11114 and can stick around until I get rid of the old table.

Jan 11 2017, 4:06 PM · Differential, Bug Report
epriestley closed T12094: Upgrade from Jun 18 2014 as Invalid.

Particularly, this does not reproduce against the upstream. All patches can be re-run in order with ./bin/storage upgrade --no-quickstart --namespace ..., and we do this somewhat regularly. This process runs cleanly:

Jan 11 2017, 3:58 PM · Support Request
epriestley resigned from D1105: Initialize immediately, throw when accessing node data before merge..

iiam

Jan 11 2017, 3:33 PM
epriestley closed T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter as Wontfix.

We've formally frozen this method after D17158. The UI now encourages project.edit.

Jan 11 2017, 3:31 PM · Restricted Project, Conduit, Bug Report

Jan 10 2017

epriestley added a comment to T12092: conduit.querydiffs generates error when optional `id` argument is empty.

Intentional; see T12026 and T12027.

Jan 10 2017, 10:00 PM · Bug Report
epriestley closed T12089: New red/green highlight colors are incorrect for added or removed new lines as Resolved.

Presumably resolved by D17171?

Jan 10 2017, 9:48 PM · Design, Differential
epriestley added a comment to T12092: conduit.querydiffs generates error when optional `id` argument is empty.

Thanks for the report. This should be resolved at HEAD of master. Let us know if you run into anything else.

Jan 10 2017, 9:48 PM · Bug Report
epriestley closed T12092: conduit.querydiffs generates error when optional `id` argument is empty as Resolved by committing Restricted Diffusion Commit.
Jan 10 2017, 9:47 PM · Bug Report
epriestley added a revision to T12092: conduit.querydiffs generates error when optional `id` argument is empty: Unknown Object (Differential Revision).
Jan 10 2017, 9:45 PM · Bug Report
epriestley merged T12091: arc patch fails with conduit error into T12092: conduit.querydiffs generates error when optional `id` argument is empty.
Jan 10 2017, 9:43 PM · Bug Report
epriestley merged task T12091: arc patch fails with conduit error into T12092: conduit.querydiffs generates error when optional `id` argument is empty.
Jan 10 2017, 9:43 PM · Arcanist, Bug Report (Needs Information)
epriestley added a comment to T12092: conduit.querydiffs generates error when optional `id` argument is empty.

This was collateral damage from D17164.

Jan 10 2017, 9:43 PM · Bug Report
epriestley added a comment to T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader.

After D17169, the clusterize command, the error message, and the documentation should be more helpful in anticipating and resolving this situation. (The documentation may take ~24 hours to actually regenerate.)

Jan 10 2017, 8:46 PM · Restricted Project, Bug Report
epriestley closed T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader as Resolved by committing Restricted Diffusion Commit.
Jan 10 2017, 8:46 PM · Restricted Project, Bug Report
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 10 2017, 8:33 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field as Resolved by committing Restricted Diffusion Commit.
Jan 10 2017, 8:28 PM · Restricted Project, Bug Report
epriestley added a revision to T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader: Unknown Object (Differential Revision).
Jan 10 2017, 8:28 PM · Restricted Project, Bug Report
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

we can probably ditch that outright?

Jan 10 2017, 8:13 PM · Design
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

You should be able to return a list of appropriately configured PhabricatorEditEngineProfileMenuItem objects as builtins, rather than defining a new class for each application -- since "Create Task" is just "EditEngine link to the create task form", etc.

Jan 10 2017, 8:12 PM · Design
epriestley added a comment to T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field.

I marked D17168 as fixing this -- it just makes the replacement migration more robust, but I think that's the best we can do from the upstream. No idea how null ended up there in the first place, but I'd guess we have no way to figure it out and our lives would be no richer for knowing.

Jan 10 2017, 7:56 PM · Restricted Project, Bug Report
epriestley added a revision to T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field: Unknown Object (Differential Revision).
Jan 10 2017, 7:55 PM · Restricted Project, Bug Report
epriestley added a comment to T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field.

You should be able to safely update these rows to have '' instead of NULL, then continue:

Jan 10 2017, 7:52 PM · Restricted Project, Bug Report
epriestley added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Ah, sorry, I overlooked that you're using edges.

Jan 10 2017, 7:49 PM · Bug Report
chad awarded T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages a Love token.
Jan 10 2017, 7:12 PM · Installing & Upgrading, Differential
epriestley updated the task description for T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.
Jan 10 2017, 7:09 PM · Installing & Upgrading, Differential
epriestley added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Oh -- try subclassing DifferentialCommitMessageCustomField instead of DifferentialCommitMessageField directly?

Jan 10 2017, 7:07 PM · Bug Report
epriestley added a comment to T4416: Drop "-u" flag from `hg pull` in daemons?.

The other side of the Conduit call still issues an hg (or git, or whatever) command in most cases, but sending everything through Conduit means a different host (one which actually does have a working copy) can give us the answer if necessary.

Jan 10 2017, 5:27 PM · Mercurial, Diffusion
epriestley added a comment to T4416: Drop "-u" flag from `hg pull` in daemons?.

They shouldn't interact -- T10753 is mostly about clustering. When Diffusion and the daemons need to ask questions about a Mercurial repository, they're supposed to issue a Conduit call so Phabricator can get an answer by asking another host if it needs to. In a few cases, they currently just issue an hg command, which only works if the repository is present (and up to date) on local disk.

Jan 10 2017, 5:26 PM · Mercurial, Diffusion
epriestley moved T6636: Show Audit status of referenced commits in Maniphest from Backlog to Audit States on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Diffusion, Maniphest
epriestley moved T8690: Modernize PhabricatorCommitSearchEngine from Backlog to EditEngine on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Restricted Project, ApplicationSearch, Diffusion
epriestley moved T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) from Backlog to Inlines on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley moved T4343: Implement "arc audit" from Backlog to Future on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Diffusion
epriestley moved T4416: Drop "-u" flag from `hg pull` in daemons? from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:19 PM · Mercurial, Diffusion
epriestley moved T1130: Add Mercurial tag/bookmark support to Diffusion from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:19 PM · Mercurial, Diffusion
epriestley moved T6118: Support for Mercurial extensions in hosted repositories from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:18 PM · Mercurial, Diffusion
epriestley added a project to T8303: Mercurial hooks: Mercurial.
Jan 10 2017, 5:18 PM · Mercurial, Diffusion
epriestley moved T8303: Mercurial hooks from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:18 PM · Mercurial, Diffusion
epriestley added a project to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion): Audit.
Jan 10 2017, 5:17 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley merged T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position into T9548: Support Mercurial's bundle2 wire protocol.
Jan 10 2017, 5:15 PM · Diffusion, Mercurial
epriestley merged task T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position into T9548: Support Mercurial's bundle2 wire protocol.
Jan 10 2017, 5:15 PM · Diffusion, Mercurial
epriestley added a comment to T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position.

I'm just going to merge this into T9548 since I think bundle2 support will fix it?

Jan 10 2017, 5:15 PM · Diffusion, Mercurial
epriestley moved T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:14 PM · Diffusion, Mercurial
epriestley moved T9548: Support Mercurial's bundle2 wire protocol from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:14 PM · Diffusion, Mercurial
epriestley moved T10753: Remove Mercurial daemon working copy operations from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:14 PM · Infrastructure, Daemons, Diffusion, Mercurial
epriestley added a project to T8690: Modernize PhabricatorCommitSearchEngine: Audit.
Jan 10 2017, 5:13 PM · Audit, Restricted Project, ApplicationSearch, Diffusion
epriestley moved T8370: Index "TODO" comments and other references present in source code from Backlog to Far Future on the Diffusion board.
Jan 10 2017, 5:13 PM · Transactions, Diffusion
epriestley added a project to T6636: Show Audit status of referenced commits in Maniphest: Audit.
Jan 10 2017, 5:12 PM · Audit, Diffusion, Maniphest
epriestley added a project to T4343: Implement "arc audit": Audit.
Jan 10 2017, 5:11 PM · Audit, Diffusion
epriestley moved T9482: Problems in the "Commits in this Package that Need Attention" view from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:09 PM · Restricted Project, Restricted Project, Audit
epriestley moved T7676: Packages that are configured to auto-audit often generate audits that are un-closable from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:07 PM · Owners, Audit
epriestley moved T2393: Adds a "Needs Verification" state to Audits from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Restricted Project, Audit
epriestley moved T5928: Clarify language around self-accepting Audits from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Audit
epriestley moved T6024: Display (post-push) audit-state in Diffusion commit-list from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Restricted Project, Audit, Diffusion
epriestley moved T9544: way to search for commits with no audit status from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Restricted Project, Restricted Project, Audit
epriestley moved T8683: Ability to query audits where all auditors have replied from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Audit
epriestley moved T7504: Manually added auditors doesn't change commit audit status from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:05 PM · Audit
epriestley closed T9423: Timeout error when loading "All Audits" query from a user who should not have access to any commits/audits as Resolved.

I believe this was resolved by the introduction of the "query overheating" mechanism, described in T11773.

Jan 10 2017, 5:04 PM · Audit
epriestley merged T1397: Navigating the repository tree while auditing into T5815: Make it easier to work through a queue of stuff.
Jan 10 2017, 5:00 PM · Restricted Project, Maniphest, Differential, Audit
epriestley merged task T1397: Navigating the repository tree while auditing into T5815: Make it easier to work through a queue of stuff.
Jan 10 2017, 4:59 PM · Audit, Diffusion
epriestley added a comment to T1397: Navigating the repository tree while auditing.

I'm going to merge this into T5815, which is a more general discussion of action queues.

Jan 10 2017, 4:59 PM · Audit, Diffusion
epriestley moved T5338: Incorrect handling of merge commits from Backlog to Herald on the Audit board.
Jan 10 2017, 4:58 PM · Differential, Audit
epriestley moved T6557: Automatic auditing should ignore merges from Backlog to Herald on the Audit board.
Jan 10 2017, 4:58 PM · Audit
epriestley closed T10965: [Needs Audit] shows "Query Errors : This query specifies an invalid parameter." as Invalid.

I can't reproduce this; we can't move forward without reproduction steps.

Jan 10 2017, 4:58 PM · Audit, Bug Report
epriestley merged T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail into T10448: Modularize mail tags.
Jan 10 2017, 4:56 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged task T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail into T10448: Modularize mail tags.
Jan 10 2017, 4:56 PM · Restricted Project, Mail, Audit, Notifications
epriestley added a comment to T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail.

I'm just going to merge this into T10448, this task doesn't have anything not already covered there.

Jan 10 2017, 4:56 PM · Restricted Project, Mail, Audit, Notifications
epriestley moved T6660: Unsubmitted comments icon for Audits from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:56 PM · Restricted Project, Audit
epriestley closed T2716: Consolidate "load commit from name" code, a subtask of T2714: Move Releeph to Beta, as Resolved.
Jan 10 2017, 4:56 PM · Releeph
epriestley closed T2716: Consolidate "load commit from name" code as Resolved.
  • DiffusionCommitQuery has had the "good" version for a while.
  • We're nuking Releeph at some point.
Jan 10 2017, 4:56 PM · Releeph, Audit, Diffusion
epriestley moved T2921: Audit status is none on commit views of Audit if no Auditors specifically assigned from Backlog to Audit States on the Audit board.
Jan 10 2017, 4:55 PM · Audit
epriestley moved T3917: Avoid or easily handle 'duplicate' audits from Backlog to Audit States on the Audit board.
Jan 10 2017, 4:55 PM · Restricted Project, Audit
epriestley moved T4026: Add relations between commits from Backlog to Audit States on the Audit board.
Jan 10 2017, 4:54 PM · Restricted Project, Audit
epriestley moved T6507: Audit inline comments doesn't account for synthetic authors from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:54 PM · Audit
epriestley moved T6810: Inline comments is only partially working in an imported SVN repo from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:53 PM · Audit
epriestley moved T11029: Colorized html inline diffs for Diffusion from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:51 PM · Diffusion (v3), Audit
epriestley moved T11118: Herald Rule to assign Owners to an Audit from Backlog to Future on the Audit board.
Jan 10 2017, 4:51 PM · Restricted Project, Audit, Herald, Owners, Feature Request
epriestley moved T10965: [Needs Audit] shows "Query Errors : This query specifies an invalid parameter." from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:50 PM · Audit, Bug Report
epriestley moved T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:44 PM · Audit, Diffusion, Wikimedia
epriestley moved T5815: Make it easier to work through a queue of stuff from Backlog to Far Future on the Audit board.
Jan 10 2017, 4:44 PM · Restricted Project, Maniphest, Differential, Audit
epriestley moved T5722: Support meta-audit of arbitrary baskets of nonadjacent commits from Backlog to Far Future on the Audit board.
Jan 10 2017, 4:43 PM · Audit
epriestley moved T3639: Don't eat unsaved inline comments from Backlog to Future on the Audit board.
Jan 10 2017, 4:43 PM · Audit
epriestley moved T2393: Adds a "Needs Verification" state to Audits from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:43 PM · Restricted Project, Audit
epriestley moved T10446: Unable to simply mark a Diffusion comment as Done from EditEngine to Inlines on the Audit board.
Jan 10 2017, 4:42 PM · Audit, Bug Report
epriestley moved T8739: Inline comments not sorted from EditEngine to Inlines on the Audit board.
Jan 10 2017, 4:42 PM · Audit
epriestley moved T5889: Allow herald rules to act on existence of auditors from Backlog to Herald on the Audit board.
Jan 10 2017, 4:42 PM · Restricted Project, Audit, Herald
epriestley moved T5928: Clarify language around self-accepting Audits from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:41 PM · Audit
epriestley moved T6024: Display (post-push) audit-state in Diffusion commit-list from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:41 PM · Restricted Project, Audit, Diffusion
epriestley moved T9544: way to search for commits with no audit status from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Restricted Project, Restricted Project, Audit
epriestley moved T8683: Ability to query audits where all auditors have replied from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Audit
epriestley moved T7676: Packages that are configured to auto-audit often generate audits that are un-closable from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Owners, Audit