Page MenuHomePhabricator
Create Task
Maniphest T12091

arc patch fails with conduit error
Closed, DuplicatePublic
Actions

Description

Our phabricator is at 6816974d57 and arc patch is failing. Also, diffusion isn't showing arc patch commands anymore. Not sure if that's related.

Here's the output of --trace

 ARGV  '/opt/arcanist/bin/../scripts/arcanist.php' 'patch' 'D1313' '--trace'       
 LOAD  Loaded "phutil" from "/opt/libphutil/src".                                  
 LOAD  Loaded "arcanist" from "/opt/arcanist/src".                                 
Config: Reading user configuration file "/home/reuben/.arcrc"...                   
Config: Did not find system configuration at "/etc/arcconfig".                     
Working Copy: Reading .arcconfig from "/home/reuben/hologram-python/.arcconfig".   
Working Copy: Path "/home/reuben/hologram-python" is part of `git` working copy "/h
ome/reuben/hologram-python".                                                       
Working Copy: Project root is at "/home/reuben/hologram-python".                   
Config: Did not find local configuration at "/home/reuben/hologram-python/.git/arc/
config".                                                                           
>>> [0] <conduit> differential.querydiffs() <bytes = 75>                           
>>> [1] <http> https://phabricator.knkdt.com/api/differential.querydiffs           
<<< [1] <http> 68,784 us                                                           
<<< [0] <conduit> 91,264 us                                                        
>>> [2] <conduit> user.whoami() <bytes = 117>                                      
>>> [3] <http> https://phabricator.knkdt.com/api/user.whoami                       
<<< [3] <http> 53,735 us                                                           
<<< [2] <conduit> 54,703 us                                                        
>>> [4] <conduit> differential.querydiffs() <bytes = 156>                          
>>> [5] <http> https://phabricator.knkdt.com/api/differential.querydiffs           
<<< [5] <http> 53,091 us                                                           
<<< [4] <conduit> 53,999 us                                                        
                                                                                   
[2017-01-10 21:09:24] EXCEPTION: (ConduitClientException) ERR-CONDUIT-CORE: Array f
or %Ld conversion is empty. Query: id IN (%Ld) at [<phutil>/src/conduit/ConduitFutu
re.php:58]                                                                         
arcanist(head=master, ref.master=ade25facfdf2), phutil(head=master, ref.master=c584
8b71c10f)                                                                          
  #0 ConduitFuture::didReceiveResult(array) called at [<phutil>/src/future/FuturePr
oxy.php:58]                                                                        
  #1 FutureProxy::getResult() called at [<phutil>/src/future/FutureProxy.php:35]   
  #2 FutureProxy::resolve() called at [<arcanist>/src/workflow/ArcanistWorkflow.php
:1197]                                                                             
  #3 ArcanistWorkflow::loadBundleFromConduit(ConduitClient, array) called at [<arca
nist>/src/workflow/ArcanistWorkflow.php:1189]                                      
  #4 ArcanistWorkflow::loadRevisionBundleFromConduit(ConduitClient, string) called 
at [<arcanist>/src/workflow/ArcanistPatchWorkflow.php:384]                         
  #5 ArcanistPatchWorkflow::run() called at [<arcanist>/src/workflow/ArcanistPatchW
orkflow.php:397]                                                                   
  #6 ArcanistPatchWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394]

Related Objects

Event Timeline

rbalik created this task.Jan 10 2017, 9:14 PM
chad added a subscriber: chad.Jan 10 2017, 9:17 PM

Please include reproduction steps. This is always required on every bug report.

chad edited projects, added Bug Report (Needs Information), Arcanist; removed Bug Report.Jan 10 2017, 9:17 PM
rbalik added a comment.EditedJan 10 2017, 9:18 PM

Steps:

  1. Create a diffusion review with arc diff
  2. Run arc patch <ID of review>
chad added a comment.Jan 10 2017, 9:19 PM

I am also at HEAD and cannot reproduce that error. What steps am I missing?

rbalik added a comment.Jan 10 2017, 9:20 PM

Oh and libphutil is at c5848b71c10 and arcanist is at ade25facf

rbalik added a comment.Jan 10 2017, 9:20 PM

hmm, that's pretty much it. lemme make sure i'm not missing anything

rbalik added a comment.Jan 10 2017, 9:23 PM

I dunno, I get this error every time. I just tried it again patching back on the same repo that generated the diff:

reuben@devworkstation1:~/konekt-rest-api$ git add -u                       
reuben@devworkstation1:~/konekt-rest-api$ git commit                       
[test-diff 7f5b09d] test commit                                            
 1 file changed, 1 insertion(+)                                            
reuben@devworkstation1:~/konekt-rest-api$ arc diff                         
Linting...                                                                 
 LINT OKAY  No lint problems.                                              
Running unit tests...                                                      
No unit test engine is configured for this project.                        
 SKIP STAGING  Unable to determine repository for this change.             
Updating commit message...                                                 
Created a new Differential revision:                                       
        Revision URI: https://phabricator.knkdt.com/D1315                  
                                                                           
Included changes:                                                          
  M       api.php                                                          
reuben@devworkstation1:~/konekt-rest-api$ git checkout develop             
Switched to branch 'develop'                                               
Your branch is up-to-date with 'origin/develop'.                           
reuben@devworkstation1:~/konekt-rest-api$ arc patch D1315                  
Exception                                                                  
ERR-CONDUIT-CORE: Array for %Ld conversion is empty. Query: id IN (%Ld)    
(Run with `--trace` for a full exception trace.)
epriestley closed this task as a duplicate of T12092: conduit.querydiffs generates error when optional `id` argument is empty.Jan 10 2017, 9:43 PM
Phabricator · Built by Phacility