Page MenuHomePhabricator
Create Task
Maniphest T12095

Differential reads and writes draft status to different tables, leading to various UI inconsistencies
Closed, ResolvedPublic
Actions

Description

Reproduction:

  1. open a Diff, create a comment and submit
  2. create an inline-comment and submit
  3. delete the comment from 1.

What should happen?
The first comment gets deleted - no further hassle.

What happens?
The first comment gets deleted (as planned). However the "Active Revisions"-Page now shows an "Unsubmitted Comments"-bubble next to the Diff. Accepting the Diff or adding another comment wont't change this.

Versions:
phabricator

40be2d53743ca3da83b579985e0acad7d852b8d1 (Sun, Jan 8) (branched from 363084d4fa91c36938d79532dbe7372154b01530 on origin)

arcanist

9503b941cc02be637d967bb50cfb25f852e071e4 (Sat, Jan 7) (branched from ade25facfdf22aed1c1e20fed3e58e60c0be3c2b on origin)

phutil

35b57f7ab52454f697681f034bbad978658a2ff4 (Sat, Jan 7) (branched from c5848b71c10fb585b2cfdfaaee13aec2ba163c8d on origin)

sprint

800a5e776027c974140daaf90383750e2e3b9bb6 (Sep 4 2016)

Revisions and Commits

rP Phabricator
D17205rP7276af6a81f4 Make yellow "draft" bubbles more generic

Related Objects

Event Timeline

GustavHeinz created this task.Jan 11 2017, 2:24 PM
epriestley added a subscriber: epriestley.Jan 11 2017, 4:06 PM

This doesn't reproduce for me and we don't support third-party code, but it's entangled with T11114 and can stick around until I get rid of the old table.

epriestley renamed this task from "Unsubmitted Comments" after deletion of comment to Differential reads and writes draft status to different tables, leading to various UI inconsistencies.Jan 11 2017, 4:08 PM
epriestley claimed this task.
epriestley triaged this task as Low priority.
epriestley added a project: Differential.
Herald added a subscriber: eadler. · View Herald TranscriptJan 11 2017, 4:08 PM
GustavHeinz added a comment.Jan 12 2017, 8:45 AM

For what it's worth, we tried disabling the sprint-plugin but we still get the same result.

epriestley added a revision: D17205: Make yellow "draft" bubbles more generic.Jan 13 2017, 3:37 PM
epriestley closed this task as Resolved by committing rP7276af6a81f4: Make yellow "draft" bubbles more generic.Jan 13 2017, 5:02 PM
epriestley added a commit: rP7276af6a81f4: Make yellow "draft" bubbles more generic.
epriestley mentioned this in T12134: Develop a Nuance-based Phabricator reporting/support flow.Jan 20 2017, 5:32 PM
Phabricator · Built by Phacility