Err yea I didn't mean feedback as in "this is what I'd like to see" but more of bug reports. I did come across a bug but it's neither earth-shattering nor consistently reproducible.

Yeah, give us a bit longer for general feedback -- I think I'll file a feedback task tomorrow with the release cut.

We haven't started the new features yet

@avivey I updated description to include version info, repeatable and steps to reproduce, is there anything else you guys need?

I believe we see the same issue in our environment, but I didn't think much of it/rule out actual problems with our setup and just restarted the daemons the first few times it's happened.

Is this open for test/feedback (I think it's usually called "Errata" here)?

I eventually muddled though things, and I believe work here has now substantially concluded.

I'm also toying with the idea of "Shift+Click" on "Reply" to "Reply-with-Quote" but the only way to discover that would be to read the documentation.

(I normally think of myself as like a 95th percentile power user, and don't use keyboard shortcuts at all in Differential today, and suspect I still won't after these changes. However, I'm also an elite mouse power user, per J769.)

Please identify the versions of mercurial used on client/server, also the version of Phabricator in use. If you're on an older version of Phabricator it's possible that upgrading may resolve the issue.

If nothing changes, I was thinking of leaving these top-level:

That is, we show the keyboard shortcut on the dropdown along with the action.

I think if we combine dropdown with keyboard hints, it'd be a good middle ground.

I'm not sure if D17908 is going to stick, but if it does we more reasonably have room to add a caret menu here. I'm not planning to necessarily pursue this in the current iteration, but I believe there are no longer any meaningful technical blockers, just some product questions which will more or less resolve themselves if everything sticks.

I just want to note that we fixed this in less than 5 years. Learn how in my upcoming book "Unbelievably Agile Ultra-High-Velocity Software Development Which Goes So Fast it Almost Must Account For Relativistic Effects".

I don't personally, since I neither use hg or windows, but maybe @cspeckmim from the community has some suggestions.

I tried to reproduce with other users, on the same phabricator install but there is only one user with a particular windows setup (that has nothing different from other users except for his particular windows machine) that is experiencing this problem. I tried following the stack trace and adding some error_log's on the php. But my php knowledge is close to zero. In any case something like this:

We have lots of APIs for external things, but without knowing what you're trying to do specifically, we can't really give you advice here. Herald / Mail are absolutely never the correct answer. Doorkeeper, Harbormaster, Feed Hooks, all available out of the box.

Please read and follow Contributing Bug Reports.

We need a "Resolved: Ghosts" status.

For now I have a ugly idea: Change content in PhabricatorMailImplementationPHPMailerAdapter.php and add some lines to invoke another python class of my own.

See also T5462

Thank you! I read Describing Root Problems but I guess I missed some important points.

See Contributing Feature Requests, and use Ponder or Conpherence if you have general questions on how to do something in Phabricator.

If a linter could theoretically catch it (conventions, space, formatting, etc.), I think a linter should (in a perfect world) be catching it.

Do you bucket style guide violations with lint issues? While I obviously can't post internal reviews, I can give you a hand-waving indication that a non-zero percentage of comments are style-related things that aren't caught by linters.

Broadly, the technical stuff here is in fairly good shape now but I still don't truly understand what problem we're solving. From earlier, I dug this up:

I'm just going to merge this into T8250. I'm still unsure what's to become of this, but I think however that resolves will cover this.

This is effectively not a problem at HEAD, although I may make it a problem again soon. But I'm also not sure if anyone else has actually hit this, and it's a pain to fix, and even in the worst case it's less bad now because we pointer-events this. I'm just going to punt for now, let the dust settle on T12616, and we can revisit this if anyone's actually hitting it after all that.

Per T10563#221154, D17938 makes "reply" put comments in the right (threading-respecting) place and marks this complete.

(Offhand this sounds expected)

Bug reports require version information, and repeatable, detailed reproduction information. Please!

@epriestley I see, tried the same steps and it doesn't play directly within chrome. Thanks for investigating.

I can't play it in Chrome in any circumstance.

I can not play the .mov file in Chrome no matter what I try:

@chad The first video still doesn't play in Chrome (Version 58.0.3029.110 (64-bit); seems working in FF and safari now.

This is what I see in chrome (Version 58.0.3029.110 (64-bit))

Here's a screenshot of this working correctly for me in Safari:

@avivey I no longer run into this problem, please feel free to close this bug.

@epriestley not sure if the current phabricator install has been upgraded to lastest code that contains this fix yet, but the first video included in this bug which is a mov file still doesn't play. If I download it, it works, so the mov file itself is working.

While it would have saved me some time and some wondering if this kind of error message would have been in place I agree, it would ideally be in git. I'll see if there is anything about that on the git front.

We could say "checkout failed, you might have a bad hook" but I'd want to wait for more users to run into this first, and maybe try to pursue a fix in git with the upstream.

There doesn't appear to be any reasonable way for us to perform something like git checkout --skip-hooks, and I think we shouldn't even if we could.

Ha yeah that is interesting

Can you show me the output of these commands?

I can no longer reproduce the edit issue at HEAD.

In this screenshot:

In T5698#223992, @chad wrote:

Oh hai Cura uses Phabricator? I have a Lulzbot at home!

Oh hai Cura uses Phabricator? I have a Lulzbot at home!

On mobile, the hamburger menu icon is not aligned properly:

@Krinkle, @pablocarrillo I second your requests. Great suggestion. I have a large README.md that I would love to split into multiple documentation files, without losing all the formatting.

This no longer reproduces for me at HEAD of master.