all my drains are belong to PVC

(You don't actually need a leak detector, I think there's enough absorbent material underneath the sink to last a long while before it damages the floor)

Here is my bathroom sink. The right-most pipe coming out of the wall is the condensate drain from HVAC. The tailpiece is most definitely 1 1/4 and the rest of the piping is 1 1/2, at least to the naked eye.

A few more thoughts:

My terminology might be wrong throughout this but a couple thoughts:

fill in the details a bit.

(one orthogonal bug I found is that bin/drydock lease discards any blueprints provided in an attributes JSON)

One thought here for Test Plan items: performing edits with the revision loaded in two separate browser tabs. I don't think UX here is important, but probably important to make sure there's no data loss.

Since these may be prone to heavy usage with arguably minimal value for long-term persistence, you could consider a follow-up revision implementing DifferentialViewStateGarbageCollector.

I actually tried to use the extensions directory to hide Composer's vendored files and ran into this same issue.

In D20221#262095, @epriestley wrote:

Oh, good catch. Yeah, that would be an improvement.

use cases seem very weak.

We actually just ran into a situation where this would be extremely useful. We're adding a rudimentary start/end time tracing listener so we can keep tabs on our service calls. That listener uploads the data to an endpoint using an HTTPSFuture, but we want to configure it to not show up in the default echoListener (or to not be profiled at all).

In T13187#240394, @epriestley wrote:

See PHI757. Leaving inline comments on the right hand side of files not touched by diff B in an interdiff between A and B raises an error.

This is at least somewhat involved. Related behavior:

• In the standalone view, you can leave comments on either side -- and they swap sides!
• Deleting comments from either side raises a JS error ("TypeError: null is not an object (evaluating 'templates.r')"). (Actually, this looks like it applies to all standalone deletion?)

• Install XCode. Find the secret "Install Command Line Tools" option inside the Hidden Chamber of XCode and click it.

xcode-select --install should be possible without a full XCode installation.

In T13130#238582, @epriestley wrote:

Offhand, two possible issues with that:

• At least one install has an enormous number of packages (tens of thousands? Hundreds of thousands? Seventy-two billion?) and the minimum cost for a package is much, much smaller than the minimum cost of a Herald rule. If packages actually created Herald rules this install would probably explode.

13,636.

See PHI496. Multiple users have now reached the maximum level ("Heavy Wizard") on their Support characters, and we're overdue for an expansion pack to add new adventure content.

In rPc8583b016daf4931f359f128d4d7d96caa3b2139#42439, @epriestley wrote:

Thanks, D19248.

This is a buff to API humor

The harbormaster builds that we have running on revision creation can sometimes be rather slow; they're builds in our primary CI system, but with less of a priority than jobs in the submit queue. This will result in 10-30 minute delays for every revision in our monorepo. I understand the preference for only adding configuration settings when absolutely necessary, but since this may result in a significant time sink for any installs with expensive builds, is it worth keeping something around like differential.initial-state?

In the refcursor table, our current autoincrement is at 312,036,016. This is only 7% of the way to int unsigned, but the fact that we've made it to 7% in 18 months might suggest that column should be BIGINT, unless there are performance impacts of that.

+1, we've also had a handful of users request this as a per-user preference.

This information may be entirely useless, but it is somewhat related. We have a large number of repositories, with multiple clusters so this affects us in a major way.

If you go through the process manually with the web UI, are the versions OK after initial creation? After adding an observed URI?

screenshot on ambien

@bizrad6

Do you bucket style guide violations with lint issues? While I obviously can't post internal reviews, I can give you a hand-waving indication that a non-zero percentage of comments are style-related things that aren't caught by linters.

Really a very very beautiful hovercard. It's going to be great. Fantastic job. Really really proud of this hovercard.

That was unclear: we can parameterize on lots of things, just not the commit hash, which is conceivably what you want us to parameterize on.

I have a related question regarding this quote:

I agree, pagination way below the fold is rather inconspicuous

Bystander input: try page 3: https://phabricator.kde.org/source/krita/browse/master/libs/ui/?offset=200

pollice lock us in prisun.

FWIW, All packages in our monorepo have weak dominion.

How do we envision these rules applying to the following situation?

Do git ls-remote (which, curiously, seems to be significantly faster than git fetch even when git fetch is a no-op).

The default -- PhabricatorMailImplementationPHPMailerLiteAdapter

@pouyana Here's a workaround for you. In your notification.servers Phabricator configuration, add path: "/ws/" to the client server. Then, modify your apache configuration like so:

In T12240#211220, @epriestley wrote:

We could also implement "Mute Thread" in Phabricator, but I assume no one would be willing to click twice to mute a thread.

This has come up again with a slightly different use case. We want to intelligently purge tags from our staging areas. To do this, we examine refs/tags/* in the staging area, and parse out the diff IDs. It would be great if we could do this from differential.revision.search, but the attachments/constraints don't support it. The current working approach is differential.querydiffs with the IDs, parse the revision IDs out, then differential.query to get the revision statuses and their associated diffs list. This approach allows us to make significantly less queries than examining *all* closed/abandoned revisions, then calling the frozen/deprecated differential.query for the diff list.

Awesome. Things appear to be working now. I suppose I can strip out all the overrides that the most recent commit stripped out. Sweetness.

so if isFieldEditable and isTemplateField are both false, will the field still show up in getcommitmessage?

Solid.

Awesome. What do you think the time delta will be between release promotion and the fix you have being merged to master?

shouldAppearInCommitMessage() is marked as obsolete, but still seems necessary for me to implement a CustomField that behaves as follows:

After merging with upstream, we were able to increase our taskmasters up to 32, and still not come anywhere close to the number of connections that were previously used. So far, so good on our end.