Page MenuHomePhabricator

jasonrumney (Jason Rumney)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 23 2014, 5:53 AM (522 w, 1 d)
Availability
Available

Recent Activity

Jul 16 2018

jasonrumney added a comment to T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule'.

I think the following change to src/applications/herald/controller/HeraldRuleController.php line 672 (as of 185c28f307e4) should provide an immediate improvement to at least indicate that they are different rules:

Jul 16 2018, 2:18 PM · Restricted Project, Herald

Jun 6 2018

jasonrumney added a comment to rPf191a66490b1: Add controllers/search/edit engine functionality to RepositoryIdentity.

Shouldn't there be something in the Changelog about this change?

Jun 6 2018, 1:42 AM

Jan 2 2018

jasonrumney added a comment to rP14cc0abeb37f: Fix several safety issues with repository URIs.

This makes it rather annoying to create a new observed repository, as you first need to set all 6 (if both https and ssh access are configured) default URIs to read only before adding the URI to Observe.

Jan 2 2018, 9:59 AM

Jul 14 2017

jasonrumney added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Since the History is now dumbed down and separated from the Technical details on the Graph view, it might be more useful to filter out merge commits from the History view. Perhaps they can be replaced by a small "Merged to <branch>" link at the bottom of the box for the last non-merge commit that was part of the merge.

Jul 14 2017, 6:11 AM · Diffusion, Design

Jun 15 2017

jasonrumney added a comment to T12840: (maybe) bring back commit graphs in history.

+1 for bringing this back.

Jun 15 2017, 9:13 AM · Design, Diffusion

Jun 6 2017

jasonrumney added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

It doesn't try to run evil.exe until I edit the cell (the csv version, and the modified xlsx I saved myself try to start on opening).

Jun 6 2017, 3:45 AM · Security
jasonrumney added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

Actually, Excel 2016 is vulnerable. The test case is incomplete. The cell needs to be =cmd|'/C evil.exe'!A0 to trigger the issue.
By modifying the value in both the xlsx and csv files, I was able to blindly click yes on lots of warning prompts and start calc.exe. But I am not sure that modifying the value in the xlsx file is giving the same result as the export would (something may have been stripped off in the meantime...)

Jun 6 2017, 3:33 AM · Security
jasonrumney added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

It seems an up to date patched Excel 2016 is not vulnerable.

Jun 6 2017, 3:10 AM · Security
jasonrumney added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

Saving this file as csv also doesn't trigger the bug in Excel 2016 - on reopening, Excel misdetects the format as SYLK, warns about the extension not matching, then warns that an error occured during loading, and finally when you agree to continue loading as "a different format", it opens without running calc.exe or prompting to update cells.

Jun 6 2017, 3:04 AM · Security

May 18 2017

jasonrumney added Q620: How to run custom tasks with Herald Rules? (Answer 547).
May 18 2017, 6:19 AM

Apr 8 2017

jasonrumney created T12522: diffusion.commit.search requires repositories to be specified by PHID.
Apr 8 2017, 12:47 PM · Diffusion, Conduit, Bug Report

Apr 2 2017

jasonrumney added a comment to T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place.

I should also mention that phabricator.allow-email-users is false on this install. Another option to avoid backscatter spam could be to limit the error messages to registered users (maybe even regardless of that setting).

Apr 2 2017, 3:52 PM · Mail, Bug Report
jasonrumney updated the task description for T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place.
Apr 2 2017, 2:06 PM · Mail, Bug Report
jasonrumney added a comment to T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place.

Version is stable, updated about 2 hours ago.

Apr 2 2017, 2:01 PM · Mail, Bug Report
jasonrumney created T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place.
Apr 2 2017, 1:53 PM · Mail, Bug Report

Mar 20 2017

jasonrumney added a comment to D17510: Remove dead link from "External Editors" documentation.

You seem to be only considering Mac editors, where URLs seem to be a fairly standard way of launching editors that is documented in the editor's own documentation.

Mar 20 2017, 3:18 PM

Mar 19 2017

jasonrumney created T12418: Link to Configuring other editors needs updating.
Mar 19 2017, 2:58 AM · Documentation, Bug Report

Dec 9 2016

jasonrumney added a comment to T11980: Links to external systems.

I updated the summary to hopefully make the problem description more clear, and to add an additional problem which I encountered on one vendor's custom made bug tracker, where their search was returning URLs that were only temporarily valid in the session that the search was done in.

Dec 9 2016, 7:56 AM · Remarkup, Feature Request
jasonrumney updated the task description for T11980: Links to external systems.
Dec 9 2016, 7:40 AM · Remarkup, Feature Request
jasonrumney updated the task description for T11980: Links to external systems.
Dec 9 2016, 6:46 AM · Remarkup, Feature Request
jasonrumney created T11980: Links to external systems.
Dec 9 2016, 6:40 AM · Remarkup, Feature Request

Nov 16 2016

jasonrumney added a comment to T11816: Calendar: Feedback and Suggestions.

It's my fault - I edited the comment to add that link (probably based on
the same search you did) in parallel with your reply.

Nov 16 2016, 4:56 AM · Restricted Project, Calendar
jasonrumney added a comment to T11816: Calendar: Feedback and Suggestions.

Unfortunately "W. Europe Standard Time" is just one of the many unnecessarily verbose timezone names that Microsoft uses. I also had "Singapore Standard Time" and "Russian Time" (which I presume refers to Moscow, rather than any of the other dozen or so timezones in Russia) in my calendar for this week.

Nov 16 2016, 4:46 AM · Restricted Project, Calendar

Nov 15 2016

jasonrumney added a comment to T11816: Calendar: Feedback and Suggestions.

ICS import does not seem to parse VTIMEZONE entries in the ICS file. This is perhaps related to the Zimbra issues above, though in my case I am importing from outlook.office365.com. The ics contents include:

Nov 15 2016, 5:20 AM · Restricted Project, Calendar

Aug 18 2016

jasonrumney created T11493: Unable to view Harbormaster Build Plans after tagging many projects on a build plan.
Aug 18 2016, 3:40 AM · PHUI, Harbormaster, Bug Report

Aug 17 2016

jasonrumney created T11488: Herald Test thinks commits are not objects.
Aug 17 2016, 2:47 PM · Herald, Bug Report

Aug 6 2016

jasonrumney added a comment to T4245: Make repository URIs slightly prettier.

Shortname is already used for the shortname.git portion of the URI. Would it be out of the question to allow a separate path to be configured, perhaps also including nested directories?

Aug 6 2016, 4:59 AM · Prioritized, Diffusion (v3), KDE, Restricted Project

Jun 16 2016

jasonrumney added a comment to T11118: Herald Rule to assign Owners to an Audit.

On second thoughts, the flexibility of a Herald rule may already be better for me, as I want to filter out Merge Commits from auditing (at least when they are merged by an Owner), since the individual commits that are merged already have their own audit.

Jun 16 2016, 3:56 AM · Restricted Project, Audit, Herald, Owners, Feature Request

Jun 14 2016

jasonrumney added a comment to T11118: Herald Rule to assign Owners to an Audit.

Yes, that would also solve the problem for me, and would probably be an easier option for new users.

Jun 14 2016, 11:23 AM · Restricted Project, Audit, Herald, Owners, Feature Request

Jun 9 2016

jasonrumney added a comment to T10939: Support for OWNERS files.

As an alternative to Luke081515.2's request for an option, I just filed T11118. This would also allow an easy return to the old behaviour of always triggering audits, regardless of who the author is.

Jun 9 2016, 6:04 AM · Prioritized, Restricted Project, Owners
jasonrumney created T11118: Herald Rule to assign Owners to an Audit.
Jun 9 2016, 5:59 AM · Restricted Project, Audit, Herald, Owners, Feature Request

Jun 6 2016

jasonrumney added a comment to T10181: Create audit requests based on a package commits.

If a package is defined with multiple owners (or a group ownership), it is a reasonable expectation that even when an owner commits a change, other owners will review that change. This is how owners has worked up until the T10939 changes recently.

Jun 6 2016, 3:32 AM · Restricted Project, Audit, Owners, Herald, Feature Request

Oct 30 2015

jasonrumney added a comment to T814: Support HTTP Basic Auth as an authentication mechanism.

AFAIK, it is still the only way to this. I added some bits to it to automatically populate email and name when registering, for the case where authentication is done against an ActiveDirectory instance via kerberos and LDAP, which I published at https://github.com/make-all/libphremoteuser

Oct 30 2015, 10:19 AM · Restricted Project, OpenStack, Auth

Oct 1 2015

jasonrumney added a comment to T9478: Working with harbormaster.sendmessage.

It seems the change from setting the result to FAIL to throwing an exception in the case where the server does not return 200 is skipping some code after the call that was overriding the result to WAITING in the case where a build was set to wait for result. Probably this was a bug in the case where the result was already set to fail.

Oct 1 2015, 9:40 AM · Arcanist, Herald, Harbormaster
jasonrumney added a comment to T9478: Working with harbormaster.sendmessage.

Although the return code check against exactly 200 has always been there, integration with jenkins was working as expected before rPd735c7adf2d5897d3ae08f3aba12774030c0d3b1

Oct 1 2015, 6:52 AM · Arcanist, Herald, Harbormaster

Sep 1 2015

jasonrumney created T9302: Audits for owned packages no longer showing up.
Sep 1 2015, 7:51 AM · Owners, Audit

Jul 28 2015

OCram awarded T5813: Countdown should offer sorting by expiration time a Like token.
Jul 28 2015, 7:32 AM · Countdown

Jul 21 2015

jasonrumney created T8911: Calendar List view sorting happens after limits are applied.
Jul 21 2015, 7:08 AM · Calendar

Jun 13 2015

jasonrumney added inline comments to D13262: Add date format preference and respect it in date selection controls.
Jun 13 2015, 2:48 AM

Jun 4 2015

jasonrumney added a comment to T8414: Dates are rendered incorrectly for Australia/Melbourne timezone.

Not just for Australia/Melbourne, for anyone who prefers Big-Endian or Little-Endian date format to the obscure Middle-Endian format used in the US.

Jun 4 2015, 6:02 AM

May 15 2015

jasonrumney added a comment to T8183: Remove "Away" and "Sporadic" statuses..

It seems in rP2bc9dec85f038c99788eb2a2c23de0285441505d that you forgot about Calendar List view.

May 15 2015, 9:24 AM · Calendar

Mar 18 2015

jasonrumney updated the task description for T7618: Owners application unable to enter into details of owned packages.
Mar 18 2015, 7:40 AM · Owners
jasonrumney created T7618: Owners application unable to enter into details of owned packages.
Mar 18 2015, 7:39 AM · Owners

Nov 13 2014

jasonrumney added a comment to T1731: Allow users to set their VCS names.

This extension will help with the mapping of old vcs aliases: https://github.com/make-all/libphalias

Nov 13 2014, 12:55 PM · FreeBSD, Diffusion

Oct 31 2014

jasonrumney added a comment to T6411: Countdown Panel.

Likewise, we're using them for milestones. But really, what I think we want is calendars tied to projects, countdowns just seemed like the best alternative.

Oct 31 2014, 1:33 PM · Countdown

Aug 7 2014

jasonrumney created T5813: Countdown should offer sorting by expiration time.
Aug 7 2014, 2:14 AM · Countdown

Jul 11 2014

jasonrumney added a project to T5583: lintCommit column is not large enough to hold some svn URIs.: Subversion.
Jul 11 2014, 2:14 PM · Subversion

Jul 10 2014

jasonrumney created T5583: lintCommit column is not large enough to hold some svn URIs..
Jul 10 2014, 5:27 AM · Subversion