Page MenuHomePhabricator
Feed Advanced Search

May 17 2017

epriestley added a comment to T12720: Record of hibernating daemon was garbage collected.

I papered over this in the short term by restarting daemons for all instances;

May 17 2017, 12:45 PM · Customer Impact, Daemons
epriestley created T12720: Record of hibernating daemon was garbage collected.
May 17 2017, 12:41 PM · Customer Impact, Daemons
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

We currently have three distinct selection states which I think are a little muddy. The first is the keyboard selection cursor, which shows what is selected with the keyboard:

May 17 2017, 12:07 PM · Design, Differential, Inline Comments
jcox awarded T12681: Upcoming Support Product / End of Paid Prioritization a Mountain of Wealth token.
May 17 2017, 11:47 AM · Guides, Phacility
epriestley added a comment to T12681: Upcoming Support Product / End of Paid Prioritization.

@nemobis, can you walk me through the major differences you see between the proposal above and the support plans offered by other vendors like GitHub, GitLab, and Atlassian so I can make things more clear?

May 17 2017, 11:25 AM · Guides, Phacility
epriestley closed T12719: Query: Active Repository shows wrong HEAD commit as Invalid.

This is a productive environment, so I could not test to reproduce it and I don't know how can I reproduce it.

May 17 2017, 11:02 AM · Bug Report
franjesus awarded T9548: Support Mercurial's bundle2 wire protocol a Love token.
May 17 2017, 10:12 AM · Diffusion, Mercurial
nemobis added a comment to T12681: Upcoming Support Product / End of Paid Prioritization.

If I read this correctly, people would pay a certain amount regularly without any certainty or reasonable expectation to have any of the fixes or support they care about. Instead they'll need to rely on the resident haruspex to assess what they're embarking on.

May 17 2017, 9:46 AM · Guides, Phacility
QuietJoon updated the task description for T12719: Query: Active Repository shows wrong HEAD commit.
May 17 2017, 7:23 AM · Bug Report
QuietJoon updated the task description for T12719: Query: Active Repository shows wrong HEAD commit.
May 17 2017, 7:21 AM · Bug Report
QuietJoon updated the task description for T12719: Query: Active Repository shows wrong HEAD commit.
May 17 2017, 7:18 AM · Bug Report
QuietJoon created T12719: Query: Active Repository shows wrong HEAD commit.
May 17 2017, 7:17 AM · Bug Report
ernie added a comment to T12718: Local email validation with apostrophe.

Okay, but just to point out: having an apostrophe in one's name is not that exotic...

  • O'Brien
  • O'Connor
  • D'Angelo
  • O'Dowd
  • O'Malley
  • O'Hara
  • D'Arcy
  • D'Addario

So someone could quite conceivably have Chris.O'Dowd@BBC.co.uk or something like that.
Anyway, if anyone's looking for how to get around this in the future, an alternate solution to changing PhabricatorUserEmail.php would be to go into the DB phabricator_user, in table user_email, and change it directly in there, thus bypassing validation.
If you did want to change the code, though, look into http://php.net/manual/en/filter.examples.validation.php - FILTER_VALIDATE_EMAIL and FILTER_SANITIZE_EMAIL.

May 17 2017, 4:22 AM · Bug Report
epriestley changed the status of T12718: Local email validation with apostrophe from Duplicate to Wontfix.

Per T12359, we aren't interested in supporting technically-deliverable-but-bizzarely-exotic addresses in the upstream. Feel free to fork to support this kind of address.

May 17 2017, 3:55 AM · Bug Report
epriestley merged T12718: Local email validation with apostrophe into T12359: Registration does not accept valid email addresses.
May 17 2017, 3:54 AM · Bug Report
epriestley merged task T12718: Local email validation with apostrophe into T12359: Registration does not accept valid email addresses.
May 17 2017, 3:54 AM · Bug Report
ernie updated the task description for T12718: Local email validation with apostrophe.
May 17 2017, 3:45 AM · Bug Report
nextofsearch added a comment to Q356: Installation fails: Failed while trying to read schema status.

I've experienced the same error and it turns out that you need to give all privileges to all databases, not just phabricator. Hope it helps.

May 17 2017, 3:40 AM
ernie created T12718: Local email validation with apostrophe.
May 17 2017, 3:28 AM · Bug Report
JohannesMP edited P2015 Adding + button to workboard columns.
May 17 2017, 12:40 AM
JohannesMP edited P2015 Adding + button to workboard columns.
May 17 2017, 12:39 AM
epriestley closed T5232: Keyboard shortcut to create inline comment as Resolved by committing Restricted Diffusion Commit.
May 17 2017, 12:38 AM · Inline Comments, Differential
epriestley closed T8047: Differential inline reticle can persist across Quicksand navigations as Resolved by committing Restricted Diffusion Commit.
May 17 2017, 12:37 AM · Inline Comments, Quicksand
epriestley closed T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset as Resolved by committing Restricted Diffusion Commit.
May 17 2017, 12:37 AM · Inline Comments, Differential
epriestley closed T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset, a subtask of T12634: Keyboard focus reticle is generally oblivious to the world around it, as Resolved.
May 17 2017, 12:37 AM · Differential, Inline Comments

May 16 2017

epriestley added a revision to T11401: Add ability to quote, edit, view raw, view history, and remove inline comments: Unknown Object (Differential Revision).
May 16 2017, 11:56 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley added a revision to T5232: Keyboard shortcut to create inline comment: Unknown Object (Differential Revision).
May 16 2017, 11:56 PM · Inline Comments, Differential
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 16 2017, 11:56 PM · Inline Comments
gracicot added a comment to Q618: Open audit for whole branch.

Nice! The discussion is those two are interesting. Thanks for the links!

May 16 2017, 11:28 PM
epriestley added a comment to T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset.

I've marked D17919 as fixing this although it only fixes the "hover with your mouse" half. A followup change will fix the "drag-to-select-a-range" half.

May 16 2017, 11:10 PM · Inline Comments, Differential
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

I marked D17919 as fixing this. I can't reproduce it after that change (except: the drag-select behavior isn't converted yet) and we're now Quicksand-aware, although it's possible I'm just not doing the right sequence of operations.

May 16 2017, 11:09 PM · Inline Comments, Quicksand
epriestley added a revision to T8047: Differential inline reticle can persist across Quicksand navigations: Unknown Object (Differential Revision).
May 16 2017, 11:06 PM · Inline Comments, Quicksand
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 16 2017, 11:06 PM · Inline Comments
epriestley added a revision to T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset: Unknown Object (Differential Revision).
May 16 2017, 11:06 PM · Inline Comments, Differential
chad added a comment to Q618: Open audit for whole branch.

Maybe also T4348, but T5000 in general is on our "todo this year" list.

May 16 2017, 10:44 PM
gracicot added a comment to Q618: Open audit for whole branch.

Interesting read. Indeed, our code is already committed and pushed (in feature branches), so Audit seems the way to go, but reviewing commits one by one is absolutely not the desired outcome.

May 16 2017, 10:05 PM
chad added a comment to Q618: Open audit for whole branch.

I'd recommend reading https://secure.phabricator.com/phame/post/view/766/write_review_merge_publish_phabricator_review_workflow/.

May 16 2017, 9:02 PM
gracicot asked Q618: Open audit for whole branch.
May 16 2017, 8:36 PM
epriestley moved T5232: Keyboard shortcut to create inline comment from Backlog to Reticle on the Inline Comments board.
May 16 2017, 8:15 PM · Inline Comments, Differential
cspeckmim added a comment to T9269: Undoing multiple inline comments on the same line will restore the comment out of position..

doggo.png (31×35 px, 7 KB)

May 16 2017, 8:15 PM · Inline Comments, Differential
epriestley moved T1026: Request: ability to select line range for comment via touchscreen from Glitches to Reticle on the Inline Comments board.
May 16 2017, 8:15 PM · Inline Comments, Differential
epriestley added a comment to T9269: Undoing multiple inline comments on the same line will restore the comment out of position..

Sorry, yes, that was a disappointing way to phrase it. You may open a thousand editors and put any number of them between zero and all of them, inclusive, into any of the various undo states.

May 16 2017, 8:13 PM · Inline Comments, Differential
cspeckmim added a comment to T9269: Undoing multiple inline comments on the same line will restore the comment out of position..

only half of them :/

🐕

May 16 2017, 8:12 PM · Inline Comments, Differential
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 8:10 PM · Inline Comments
epriestley closed T9269: Undoing multiple inline comments on the same line will restore the comment out of position. as Resolved.

This no longer reproduces after D17916.

May 16 2017, 8:09 PM · Inline Comments, Differential
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 16 2017, 8:06 PM · Inline Comments
JohannesMP edited P2015 Adding + button to workboard columns.
May 16 2017, 7:37 PM
amckinley updated the task description for T10448: Modularize mail tags.
May 16 2017, 7:23 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley closed T12626: Update Pholio for Modular Transactions, a subtask of T10448: Modularize mail tags, as Resolved.
May 16 2017, 7:22 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley closed T12626: Update Pholio for Modular Transactions as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 7:22 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley added a revision to T12626: Update Pholio for Modular Transactions: Unknown Object (Differential Revision).
May 16 2017, 7:12 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley moved T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff from Editor to Reticle on the Inline Comments board.
May 16 2017, 6:11 PM · Inline Comments, Differential
epriestley moved T10668: When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI from Editor to Reticle on the Inline Comments board.
May 16 2017, 6:11 PM · Inline Comments, Restricted Project, Differential
epriestley closed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 6:10 PM · Inline Comments, Differential, Bug Report
epriestley closed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately, a subtask of T12634: Keyboard focus reticle is generally oblivious to the world around it, as Resolved.
May 16 2017, 6:09 PM · Differential, Inline Comments
epriestley closed T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 6:06 PM · Inline Comments, Differential, Bug Report
epriestley added a revision to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately: Unknown Object (Differential Revision).
May 16 2017, 6:06 PM · Inline Comments, Differential, Bug Report
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 16 2017, 6:06 PM · Inline Comments
chad added a revision to T12625: Update Phriction for Modular Transactions: Unknown Object (Differential Revision).
May 16 2017, 5:54 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley renamed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately from Jumping to an inline comment via URL anchor should highlight it with the keyboard focus reticle to Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.
May 16 2017, 5:39 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.

I'm inclined not to actually pursue the autofocus approach I was considering before, at least until we get a better read on whether click-to-select is a good behavior or not. Instead, I'm just going to fiddle with the UI a bit to fix the alignment issue. The new hidden inline state has some similar alignment issues.

May 16 2017, 5:38 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T5030: Improve behavior when jumping to inline comments.

(If something you care about got merged here and isn't covered at HEAD / by T12616, feel free to file a new report or feature request adhering to modern guidelines.)

May 16 2017, 5:35 PM · Inline Comments, Restricted Project, Differential
epriestley closed T5030: Improve behavior when jumping to inline comments as Wontfix.

I'm not sure this task has any specific, actionable issues remaining. Partly, it has just been open for twenty five decades and become a bit of a dumping ground.

May 16 2017, 5:34 PM · Inline Comments, Restricted Project, Differential
epriestley closed T5030: Improve behavior when jumping to inline comments, a subtask of T5179: Unearth Differential rendering technical debt, as Wontfix.
May 16 2017, 5:34 PM · Differential
epriestley added a comment to T8592: "View on previous revision" button on ghosted comment can jump to wrong place.

I think it's also possible that this was T11784.

May 16 2017, 5:27 PM · Differential, Restricted Project
epriestley added a revision to T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content: Unknown Object (Differential Revision).
May 16 2017, 5:21 PM · Inline Comments, Differential, Bug Report
epriestley closed T8420: Hidden inlines don't work properly with anchor-based navigation as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 5:12 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T8420: Hidden inlines don't work properly with anchor-based navigation: Unknown Object (Differential Revision).
May 16 2017, 5:08 PM · Inline Comments, Restricted Project, Differential
epriestley renamed T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset from Toggling File Browser on Differential while creating inline comment causes keyboard focus reticle to offset to Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset.
May 16 2017, 4:49 PM · Inline Comments, Differential
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

The keyboard reticle has been fixed but the inline reticle is still at large.

May 16 2017, 4:46 PM · Inline Comments, Quicksand
epriestley closed T12634: Keyboard focus reticle is generally oblivious to the world around it as Resolved.

I think the keyboard reticle now generally has reasonable behavior.

May 16 2017, 4:45 PM · Differential, Inline Comments
epriestley closed T12715: Availability of inline "Reply" action is inconsistent as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 4:44 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 16 2017, 4:34 PM · Inline Comments
epriestley added a revision to T12715: Availability of inline "Reply" action is inconsistent: Restricted Differential Revision.
May 16 2017, 4:34 PM · Inline Comments
chad added a comment to T12688: Inline Comment Design Opportunities for Improvement.

max-height: 600px; overflow: scroll;

May 16 2017, 4:09 PM · Design, Differential, Inline Comments
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

This is going to get even worse:

May 16 2017, 4:08 PM · Design, Differential, Inline Comments
epriestley closed T8130: Keyboard shortcut for "Done", a subtask of T1460: Add "Done" link to an inline comment, as Resolved.
May 16 2017, 3:23 PM · User Delight, Differential
epriestley closed T8130: Keyboard shortcut for "Done" as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 3:23 PM · Inline Comments, Restricted Project, Differential
epriestley closed T8131: Clicking "Done" breaks keyboard navigation as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 3:23 PM · Inline Comments, Restricted Project, Differential
epriestley closed T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 3:22 PM · Inline Comments
epriestley closed T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle, a subtask of T12634: Keyboard focus reticle is generally oblivious to the world around it, as Resolved.
May 16 2017, 3:22 PM · Differential, Inline Comments
epriestley closed T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 3:22 PM · Inline Comments, Differential
epriestley closed T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it, a subtask of T12634: Keyboard focus reticle is generally oblivious to the world around it, as Resolved.
May 16 2017, 3:22 PM · Differential, Inline Comments
epriestley closed T12632: Resizing a diff does not resize the keyboard focus reticle as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 3:21 PM · Inline Comments
epriestley closed T12632: Resizing a diff does not resize the keyboard focus reticle, a subtask of T12634: Keyboard focus reticle is generally oblivious to the world around it, as Resolved.
May 16 2017, 3:21 PM · Differential, Inline Comments
sgielen awarded T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL a The World Burns token.
May 16 2017, 3:21 PM · Bug Report
epriestley added a revision to T8130: Keyboard shortcut for "Done": Unknown Object (Differential Revision).
May 16 2017, 3:07 PM · Inline Comments, Restricted Project, Differential
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 2:32 PM · Inline Comments
epriestley added a revision to T8131: Clicking "Done" breaks keyboard navigation: Unknown Object (Differential Revision).
May 16 2017, 2:31 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 2:31 PM · Differential, Inline Comments
epriestley added a revision to T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle: Unknown Object (Differential Revision).
May 16 2017, 2:13 PM · Inline Comments
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 2:13 PM · Differential, Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 2:07 PM · Inline Comments
epriestley added a comment to T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it.

I've marked D17903 as fixing this. We still keep the comment focused, but comments no longer collapse en-masse after changes in T12616. Current state of the world is:

May 16 2017, 2:07 PM · Inline Comments, Differential
epriestley added a revision to T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it: Unknown Object (Differential Revision).
May 16 2017, 2:05 PM · Inline Comments, Differential
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Restricted Differential Revision.
May 16 2017, 2:05 PM · Differential, Inline Comments
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 2:01 PM · Differential, Inline Comments
epriestley added a revision to T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset: Unknown Object (Differential Revision).
May 16 2017, 2:01 PM · Inline Comments, Differential
epriestley added a comment to T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset.

This discusses the hover/edit reticle, but the keyboard reticle has the same bug.

May 16 2017, 1:59 PM · Inline Comments, Differential
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 1:54 PM · Differential, Inline Comments