Page MenuHomePhabricator
Feed Advanced Search

Mar 16 2017

epriestley added a comment to T12406: Importing commits which name themselves as the auditor can cause stuck tasks.

Thanks. D17507 should fix this, and will un-stick any tasks stuck in queue.

Mar 16 2017, 7:26 PM · Bug Report
epriestley added a revision to T12406: Importing commits which name themselves as the auditor can cause stuck tasks: Unknown Object (Differential Revision).
Mar 16 2017, 7:25 PM · Bug Report
tamal awarded T12101: Phabricator PHP 7 Compatibility a 100 token.
Mar 16 2017, 7:03 PM · Infrastructure, Guides
epriestley added a comment to T12409: `./bin/config set --database` does not handle deleted keys.

Thanks! D17506 isn't the most elegant possible patch, but should fix this. Let us know if you're still seeing issues after that lands.

Mar 16 2017, 7:00 PM · Bug Report
epriestley added a revision to T12409: `./bin/config set --database` does not handle deleted keys: Unknown Object (Differential Revision).
Mar 16 2017, 6:59 PM · Bug Report
gd created T12409: `./bin/config set --database` does not handle deleted keys.
Mar 16 2017, 6:37 PM · Bug Report
lvital awarded T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false a Burninate token.
Mar 16 2017, 5:58 PM · Mail, Bug Report
epriestley closed T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false as Resolved by committing Restricted Diffusion Commit.
Mar 16 2017, 5:56 PM · Mail, Bug Report
epriestley closed T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false, a subtask of T12404: Implement a first-party SMTP client, as Resolved.
Mar 16 2017, 5:56 PM · Infrastructure, Mail
epriestley added a comment to T12408: Security: "Show Raw File" in Differential generated files with overbroad permissions.

It is likely that the vulnerable code predates significant portions of the Files and permissions systems, and was just overlooked as these other systems upgraded and gained more powerful policy and permissions capabilities.

Mar 16 2017, 5:35 PM · Differential, Files, Security
chad awarded T12408: Security: "Show Raw File" in Differential generated files with overbroad permissions a Pirate Logo token.
Mar 16 2017, 5:21 PM · Differential, Files, Security
epriestley added a comment to T12408: Security: "Show Raw File" in Differential generated files with overbroad permissions.

The fix is now available on master (rP7626ec0c) and stable (rP6f879559). I've upgraded this install without incident. Per above, note that upgrading destroys evidence, so you should plan any audit or response actions you want to take before upgrading.

Mar 16 2017, 5:17 PM · Differential, Files, Security
rbalik added a comment to T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension.

We've started using countdowns on our dashboard as well and it's a little distracting/stressful to have that keep updating. It would be cool to have it fully customizable but the compromise plan you posted about would work well for us too.

Mar 16 2017, 5:14 PM · Customer Impact, Countdown, Feature Request
chad added a comment to T10319: Generate unique? profile images for each new user.

You can adjust it if you like at https://secure.phabricator.com/source/phabricator/browse/master/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php;7626ec0ce10e5a9665d84622259e073744c9872d$130

Mar 16 2017, 5:11 PM · Feature Request, People
mavit added a comment to T10319: Generate unique? profile images for each new user.

This would be totally great, if our corporate username policy didn't mandate that all usernames start with the same letter 😂

Mar 16 2017, 5:08 PM · Feature Request, People
epriestley added a revision to T12408: Security: "Show Raw File" in Differential generated files with overbroad permissions: Unknown Object (Differential Revision).
Mar 16 2017, 4:55 PM · Differential, Files, Security
jaufrecht added a comment to T12402: Report on team velocity.

That does make sense; we're using that multi-color approach for the report in the example in https://secure.phabricator.com/T12403. But we also put labels per-category, which is possible in that report because the categories are continuous over time to form ribbons, unlike this chart. For this chart, I think the mental model is that all categories are really sub-categories of the parent category "stuff we have worked on", and users only need to distinguish between high-priority and low-priority, hence the shading.

Mar 16 2017, 4:55 PM · Feature Request
epriestley created T12408: Security: "Show Raw File" in Differential generated files with overbroad permissions.
Mar 16 2017, 4:51 PM · Differential, Files, Security
epriestley added a comment to T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.

T9789 has stabilized (the majority of major transaction types now run through ModularTransactions) although it didn't end up providing much clarity here. This is no longer blocked on anything, I just need to develop a specific technical plan to resolve the "adjust" vs "expand" sequence inside transaction application so the "expand" code has access to the old text by the time it runs.

Mar 16 2017, 3:16 PM · Prioritized, Wikimedia, Remarkup
epriestley closed T9789: Make it easier to write custom transaction types as Resolved.

The system described in this task became "ModularTransactions", which feel like they're in a good place.

Mar 16 2017, 3:11 PM · Modernization, Transactions
20after4 awarded T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier a Mountain of Wealth token.
Mar 16 2017, 2:54 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley closed T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier as Resolved.

That sounds reasonable to me. We remain open to more feedback here if it does turn up, but I think we don't have a clear set of next steps otherwise. Thanks for following up!

Mar 16 2017, 2:09 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
rkettelerij added a comment to T12165: Maybe add a (fullscreen workboard) menu item or URL for link.

Currently the workboard has an option for fullscreen display. However this setting is lost when the browser refreshes. Since we're using Chrome + a Chrome autorefresh extension (SuperAutoRefresh) to display a Phabricator workboard on a bigscreen TV it would be useful if this setting is persisted across refreshes. Like ?fullscreen=yes as suggested.

Mar 16 2017, 7:48 AM · Workboards, Profile Menu Item
rkettelerij awarded T12165: Maybe add a (fullscreen workboard) menu item or URL for link a Like token.
Mar 16 2017, 7:42 AM · Workboards, Profile Menu Item
epriestley added a comment to T12406: Importing commits which name themselves as the auditor can cause stuck tasks.

(D17404 is an earlier fix for a similar issue, but for self-auditors added via Herald.)

Mar 16 2017, 5:19 AM · Bug Report
chad closed T12407: Type on public website as Wontfix.
Mar 16 2017, 5:16 AM · Bug Report
deepanjanroy updated the task description for T12407: Type on public website .
Mar 16 2017, 5:02 AM · Bug Report
deepanjanroy created T12407: Type on public website .
Mar 16 2017, 4:46 AM · Bug Report
alexmv created T12406: Importing commits which name themselves as the auditor can cause stuck tasks.
Mar 16 2017, 4:03 AM · Bug Report
chad added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Mar 16 2017, 3:18 AM · Badges (v0)
PyRowMan added a comment to T12405: Feed story failed to render.

After 6 month seeing the bug, i think i've found why it does that.

Mar 16 2017, 3:17 AM · Feed, Bug Report
epriestley added a comment to T12405: Feed story failed to render.

To move forward, we need complete reproduction instructions which we can follow to reproduce this issue in a clean environment. See Contributing Bug Reports and Providing Reproduction Steps.

Mar 16 2017, 3:10 AM · Feed, Bug Report
PyRowMan updated the task description for T12405: Feed story failed to render.
Mar 16 2017, 3:03 AM · Feed, Bug Report
PyRowMan created T12405: Feed story failed to render.
Mar 16 2017, 3:02 AM · Feed, Bug Report
chad added a comment to T421: Show it to me Calimonk!.

Do this man

Mar 16 2017, 2:00 AM · newyork, Arcanist (Milestone 1), Restricted Project, Localization, ircbot, External, DeviantArt, Database, Dashboard, Dashboards, Daemons, Conpherence, Calendar, Chatlog, Unknown Object (Project)
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
Mar 16 2017, 1:55 AM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a revision to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false: Unknown Object (Differential Revision).
Mar 16 2017, 1:10 AM · Mail, Bug Report
epriestley added a parent task for T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045]: T12404: Implement a first-party SMTP client.
Mar 16 2017, 1:06 AM · Mail, Security
epriestley added a parent task for T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false: T12404: Implement a first-party SMTP client.
Mar 16 2017, 1:06 AM · Mail, Bug Report
epriestley added subtasks for T12404: Implement a first-party SMTP client: T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045], T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.
Mar 16 2017, 1:06 AM · Infrastructure, Mail
epriestley created T12404: Implement a first-party SMTP client.
Mar 16 2017, 1:06 AM · Infrastructure, Mail
rsmarples added a comment to T12292: Diffusion commit details references HEAD -> master broken.

Try as I might, I cannot reproduce this in a test instance hosted by yourselves.
The on screen description is the same (HEAD -> master), but the actual URL it goes to is different compared to my instance, even with the same repositories loaded.

Mar 16 2017, 12:50 AM · Bug Report (Needs Information)
epriestley closed T12400: Provide self-service methods for finding users with no MFA configured, a subtask of T7639: Figure out MFA in the cluster, as Resolved.
Mar 16 2017, 12:49 AM · Phacility
epriestley closed T12400: Provide self-service methods for finding users with no MFA configured as Resolved by committing Restricted Diffusion Commit.
Mar 16 2017, 12:49 AM · Auth, Phacility

Mar 15 2017

ablekh added a comment to T12402: Report on team velocity.

@jaufrecht My pleasure. In general, using color gradients or shades is fine (and, actually, pretty much standard) for emphasizing trends. However, I would expect a use of gradients or shade of a single color to visualize a trend of a single category (topic, subject). In your case, though, the image presents trends in that fashion for multiple categories, which makes them difficult to distinguish and track. I would prefer and suggest using different colors for different categories and using a particular color's gradients or shades for each category across the time. Does it make sense to you?

Mar 15 2017, 11:54 PM · Feature Request
Taskle added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

I'm saying for you, not for me. Nevermind, I'm gathering that having verbal conversations isn't a priority for you guys and you don't see the value in it. No problem.

Mar 15 2017, 11:52 PM · Customer Impact, Restricted Project, Mail
chad added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

You already have all that in this public forum. We take feedback, feature requests, bug reports, have an open roadmap and design process - all for paying and non-paying customers.

Mar 15 2017, 11:45 PM · Customer Impact, Restricted Project, Mail
jaufrecht added a comment to T12402: Report on team velocity.

@ablekh Thank you.

Mar 15 2017, 11:40 PM · Feature Request
Taskle added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

Allow me to clarify: as a product manager I've found it incredibly useful to talk to both current paying customers as well as prospective paying customers and users of existing free products to learn about their needs and things that work well and don't work well in the spirit of improving our products. I find that qualitative conversations like this can be very useful, sometimes more useful than quantitative and written communication.

Mar 15 2017, 11:39 PM · Customer Impact, Restricted Project, Mail
chad added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

I understand your suggestion, but taking feedback over phone is just like the worst ever for us given customers outnumber us 1,000,000 to 1 or so. It's not scalable which is why we ask people to participate here.

Mar 15 2017, 11:30 PM · Customer Impact, Restricted Project, Mail
ablekh added a comment to T12402: Report on team velocity.

@jaufrecht Nice description. A quick comment on the attached image. Please take no offense, but IMHO, from the UX / usability perspective, this approach (using the same color's gradient or, in your case, shades) is pretty terrible and, as far as I know, is recommended against as the data visualization best practice. Hope this helps.

Mar 15 2017, 11:21 PM · Feature Request
jaufrecht created T12403: Multi-category burnup charts.
Mar 15 2017, 11:19 PM · Feature Request
chad added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

I'm not sure I understand. You want Phacility to spend development resources to understand your needs as a non-paying customer? As a thank-you?

Mar 15 2017, 11:10 PM · Customer Impact, Restricted Project, Mail
Taskle added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

@epriestley we're actually not, we're a SaaS users of Phabricator, self-hosted (dev.doctor.com). We are indeed free installs, but my gut is that our needs are no different than those SaaS folks that pay you. I'm offering my time as a form of thank you for what you've offered for free, though :) if you're interested in talk to large-scale customers and learning what their needs are (and even what they might pay for, as an example).

Mar 15 2017, 11:05 PM · Customer Impact, Restricted Project, Mail
epriestley added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

@Taskle, if you're a Phacility SAAS customer can you ping me at support@phacility.com with your instance name? I can't immediately find it. We're working to formalize the SAAS/prioritization relationship a little better, but we can push more weight behind requests if they're coming from paying customers vs free self-installs.

Mar 15 2017, 11:01 PM · Customer Impact, Restricted Project, Mail
jaufrecht added a comment to T5051: Burn down charts for Milestones.

Here are some additional use cases and a sample implementation that is a Burn-up chart, not a Burndown chart, plus rationale.

Mar 15 2017, 10:58 PM · Restricted Project, Wikimedia, Projects
Taskle added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

Just wanted to chime in as a SaaS customer. :) We've been using Phab from a team of 15 to now we're about 100 people, and we use it for both our engineering teams as well as task management for our client services teams.

Mar 15 2017, 10:55 PM · Customer Impact, Restricted Project, Mail
epriestley added a subtask for T1562: Build "Facts", an ETL pipeline and charting application: T12402: Report on team velocity.
Mar 15 2017, 10:30 PM · Restricted Project, Wikimedia, Facts
epriestley added a parent task for T12402: Report on team velocity: T1562: Build "Facts", an ETL pipeline and charting application.
Mar 15 2017, 10:30 PM · Feature Request
jaufrecht created T12402: Report on team velocity.
Mar 15 2017, 10:29 PM · Feature Request
epriestley added a project to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc: Phacility.

This also has SAAS customer interest.

Mar 15 2017, 10:27 PM · Customer Impact, Restricted Project, Mail
aklapper added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

If there's some remaining use case here, I'd also like to step back and understand it better since I suspect the best solution we can pursue is not any kind of UI change which makes it easier to find things by randomly typing guesses into the typeahead.

Mar 15 2017, 9:34 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T9006: Allow users to pick which Badges show on Timeline.

This got a mention in D17499, but when rendering a timeline we currently need two awards for each user who is going to get a full-sized profile image rendered.

Mar 15 2017, 7:44 PM · Badges, Restricted Project
chad closed T12398: Archived badges visible in comment form as Resolved by committing Restricted Diffusion Commit.
Mar 15 2017, 7:44 PM · Badges, Bug Report
aklapper closed T5267: Localize Phabricator as Resolved.

Awesome (thanks for the super fast answer)!

Mar 15 2017, 7:39 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

My belief is that we've satisfied all the requirements for Translatewiki to move forward on their side.

Mar 15 2017, 7:19 PM · Prioritized, Localization
aklapper added a comment to T5267: Localize Phabricator.

Seeing the long list of merged commits here (thanks Evan and Nikerabbit for elaborating and explaining needs!), are there any further code changes in Phab needed before someone could set up a "Phabricator" project at http://translatewiki.net and let volunteers start contribute translations?

Mar 15 2017, 7:17 PM · Prioritized, Localization
epriestley added a revision to T12400: Provide self-service methods for finding users with no MFA configured: Unknown Object (Differential Revision).
Mar 15 2017, 7:04 PM · Auth, Phacility
chad updated the task description for T12270: Unbeta Badges.
Mar 15 2017, 6:57 PM · Badges (v0)
chad closed T12264: Install Dashboard to Home / Favorites / Project as Resolved.

Resolved enough, unclear any benefit to installing to Favorites and Projects needs additional work to make it truly useful.

Mar 15 2017, 6:17 PM · Profile Menu Item, Dashboards (v2)
jasongilanfarr created T12401: Ability to run build rules for open revisions on a Herald Rule.
Mar 15 2017, 6:14 PM · Feature Request
chad added Q592: Projects and repositories (Answer 531).
Mar 15 2017, 5:56 PM
chad added a revision to T12398: Archived badges visible in comment form: Unknown Object (Differential Revision).
Mar 15 2017, 5:47 PM · Badges, Bug Report
epriestley created T12400: Provide self-service methods for finding users with no MFA configured.
Mar 15 2017, 4:21 PM · Auth, Phacility
epriestley added a project to T12177: Provide time-to-review statistics and reporting in Facts: Phacility.

We have SAAS customer interest in this too, now.

Mar 15 2017, 4:11 PM · Customer Impact, Differential, Restricted Project, Facts, Feature Request
epriestley added a comment to T12399: Documentation for Conduit Phrequent seems to be missing.

Go to Conduit on your install.

Mar 15 2017, 3:58 PM · Conduit, Phrequent, Feature Request
chad added a comment to T12399: Documentation for Conduit Phrequent seems to be missing.

Phrequent is a prototype application, and we don't provide support for these types of apps. Mostly it's expected that they will be incomplete and once we do move them to being officially supported they will have these features naturally (for example Conduit is "free" for any modern application.)

Mar 15 2017, 3:58 PM · Conduit, Phrequent, Feature Request
urzds added a comment to T12399: Documentation for Conduit Phrequent seems to be missing.

Is documentation available through other means than Conduit itself?

Mar 15 2017, 3:54 PM · Conduit, Phrequent, Feature Request
epriestley closed T12399: Documentation for Conduit Phrequent seems to be missing as Invalid.

Phrequent is not installed on this server. Conduit only shows methods from installed applications.

Mar 15 2017, 3:45 PM · Conduit, Phrequent, Feature Request
urzds added a project to T12399: Documentation for Conduit Phrequent seems to be missing: Conduit.
Mar 15 2017, 3:26 PM · Conduit, Phrequent, Feature Request
urzds added a project to T12399: Documentation for Conduit Phrequent seems to be missing: Phrequent.
Mar 15 2017, 3:26 PM · Conduit, Phrequent, Feature Request
urzds created T12399: Documentation for Conduit Phrequent seems to be missing.
Mar 15 2017, 3:26 PM · Conduit, Phrequent, Feature Request
pmatos updated Q592: Projects and repositories from to Projects and repositories.
Mar 15 2017, 3:05 PM · Diffusion, Projects
remusvrm reopened Q586: Is there a reason way I can not add a subscriber to a question in Ponder?.
Mar 15 2017, 3:04 PM · Ponder
remusvrm updated the answer details for Q586: Is there a reason way I can not add a subscriber to a question in Ponder? (Answer 527).
Mar 15 2017, 3:03 PM
pmatos updated Q591: Difference between shortname and callsign from to Difference between shortname and callsign.
Mar 15 2017, 3:02 PM · Diffusion
remusvrm updated Q590: Is it possible to change to Notify instead of Email when someone comments on my answer in Pondor? from to Is it possible to change to Notify instead of Email when someone comments on my answer in Pondor?.
Mar 15 2017, 2:50 PM · Ponder
chad awarded Phabricator Gold to recipient: hsb.
Mar 15 2017, 2:15 PM
hsb backed I2 Donate to Phacility with $75.00 USD.
Mar 15 2017, 2:12 PM · Phacility
ivo updated the task description for T12398: Archived badges visible in comment form.
Mar 15 2017, 9:11 AM · Badges, Bug Report
ivo created T12398: Archived badges visible in comment form.
Mar 15 2017, 9:10 AM · Badges, Bug Report
eliaspro created T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale.
Mar 15 2017, 2:08 AM · Bug Report
epriestley added a comment to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails.

Probably bump the version unconditionally now

Mar 15 2017, 1:10 AM · Bug Report, Clusters, Diffusion

Mar 14 2017

chad added a revision to T10390: Dashboards v2 (UX): Unknown Object (Differential Revision).
Mar 14 2017, 11:36 PM · Dashboards (v2)
epriestley added a revision to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails: Unknown Object (Differential Revision).
Mar 14 2017, 10:37 PM · Bug Report, Clusters, Diffusion
epriestley added a revision to T12296: Improve Phacility repository import performance: Unknown Object (Differential Revision).
Mar 14 2017, 10:25 PM · Customer Impact, Diffusion, Ops
epriestley added a revision to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails: Unknown Object (Differential Revision).
Mar 14 2017, 10:25 PM · Bug Report, Clusters, Diffusion
cspeckmim added Q585: Using Spaces within a large organisation (Answer 530).
Mar 14 2017, 9:42 PM
epriestley added a comment to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails.

(For example, if the goal was to very aggressively optimize for minimizing network traffic, we could read the entire repository history to figure out which refs were ancestors of other refs first? Then we could drop those and only ask for descendant refs. But this seems crazy, since it's saying that ~20 bytes of network traffic is more costly than like one hundred million disk I/O operations?)

Mar 14 2017, 9:04 PM · Bug Report, Clusters, Diffusion
epriestley added a comment to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails.

it has to compare "What do I have" vs. "What do you have"

Mar 14 2017, 8:57 PM · Bug Report, Clusters, Diffusion