Page MenuHomePhabricator

Importing commits which name themselves as the auditor can cause stuck tasks
Closed, ResolvedPublic

Description

A commit authored by me, containing Auditors: alexmv will create a stuck task during importing; the daemon will report:

EXCEPTION: (PhutilProxyException) Error while executing Task ID 43985148. {>} (PhabricatorApplicationTransactionValidationException) Validation errors:
  - The author of a commit can not be an auditor. at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:851]
 arcanist(head=master, ref.master=79a9f9e30f97), phabricator(head=master, ref.master=17229c67eb3b), phutil(head=master, ref.master=2e95e727bffd), pytest-phabricator(head=5be92a18cd4d0b72f70303cc862cbc69e49a3af8, ref.master=1939f1e4f656)
   #0 <#2> PhabricatorApplicationTransactionEditor::applyTransactions(PhabricatorRepositoryCommit, array) called at [<phabricator>/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php:102]
   #1 <#2> PhabricatorRepositoryCommitHeraldWorker::parseCommit(PhabricatorRepository, PhabricatorRepositoryCommit) called at [<phabricator>/src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php:51]
   #2 <#2> PhabricatorRepositoryCommitParserWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:123]
   #3 <#2> PhabricatorWorker::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php:171]
   #4 <#2> PhabricatorWorkerActiveTask::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php:22]
   #5 PhabricatorTaskmasterDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:219]
   #6 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:131]

This repeats indefinitely. Likely related to D17181, which introduced the check?

Versions reported above have minor but likely irrelevant changes from:

  • phabricator 216f6be11ece53cb1daafc8fff636dbdb0d7ef3d, aka 2017 week 8 plus the stable cherry-pick just after it.
  • libphutil 76983f49b179e575187c7dc5098cd1fbfac300c7
  • arcanist 822bc53ca306e06314560d8a76f68771d732e8e0

Revisions and Commits

Restricted Differential Revision

Event Timeline

(D17404 is an earlier fix for a similar issue, but for self-auditors added via Herald.)

epriestley added a revision: Restricted Differential Revision.Mar 16 2017, 7:25 PM

Thanks. D17507 should fix this, and will un-stick any tasks stuck in queue.

epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Mar 16 2017, 8:57 PM
epriestley added a commit: Restricted Diffusion Commit.