- The "Qualities" constraint in badges.search accepts numeric strings like "102". Maybe just drop this constraint from Conduit? I don't really love how badge qualities work internally, and if we hide them we don't have to fix this yet.
- PhabricatorRecipientHasBadgeEdgeType seems to still be around
Description
Description
Revisions and Commits
Revisions and Commits
| rP Phabricator | |||
| D17482 Add award and revoke conduit calls to Badges | |||
| D17447 Remove needRecipients and needAwards from Badges | |||
| D17360 Funbeta Badges | |||
| D17411 Re-center timeline badges | |||
| D17562 | rP080bf064c4a3 Remove obsolete Badges edge types | ||
| D17561 | rP6f80a04699f8 Paginate the profile badges view | ||
| D17503 | rPaef2a39a81b0 Add Badges to UserCache | ||
| D17487 | rPd73df58cc6c3 Prevent use of the "quality" constraint in the Badge search API | ||
| D17471 | rPe0918883e7f5 Add date awarded to profile badges | ||
| D17448 | rP08b18ac5f5b4 Remove needBadges from PhabricatorUser | ||
| D17449 | rP664d9fa3ed4c Touch up Badges emails | ||
| D17422 | rP5cb4c76bef6b Add a lipsum generator for Badges | ||
| D17412 | rPeec6cd865c85 Miscellanous badge fixes | ||
| D17410 | rP80cccebca292 Build a Badges page for Profiles | ||
| D17402 | rP3eae9a368de0 Modular Transactions for Badges | ||
| D17392 | rPe2868a0da24c Remove ability to edit Badge forms | ||
| D17361 | rPe0cd3062d5ab Restrict all crumbs to 240 max width | ||
Related Objects
Related Objects
- Mentioned In
- T12511: Add Support For User Definable Macro Or Template Markup to Phriction Similar To WikiMedia Templates
rP186460888d31: Funbeta Badges
T12387: Typo in code.
rPfa569c35d30e: Add award and revoke conduit calls to Badges
rPd2a420d13abd: Remove needRecipients and needAwards from Badges
rP730d88c414d0: Re-center timeline badges - Mentioned Here
- D17422: Add a lipsum generator for Badges
T9010: Allow badges to have any Font Awesome icon
T10698: Comment previews should display user badges under the author's profile image.
T10798: Limit, order recipients list in BadgeView
Event Timeline
Comment Actions
I'm fine with just declining to implement that, it just seems like something we should fix if we're calling it a bug.
Comment Actions
I'm just trying to understand the feedback. There are points that come very close to "redesign badges" to which I'm like years away from doing, if ever.
Comment Actions
After D17422, I used bin/lipsum to generate about 20,000 badges. (They all have USERS permission so the permission checks are about as fast as possible.)
The Profile → Badges page isn't actually that bad, only about ~2s. Not great, but not as bad as I'd feared.
The bigger issue is that every page with a timeline also spends ~2s just doing badge stuff.
Comment Actions
Do you have a rough suggestion on what to do with badges.search? Seems like noone would use these feature regardless.
Comment Actions
I'll send you some kind of something-or-other for dropping "Quality" from Conduit for the moment.