Page MenuHomePhabricator
Create Task
Maniphest T12270

Unbeta Badges
Closed, ResolvedPublic
Actions

Assigned To
chad
Authored By
chad
Feb 15 2017, 8:23 PM
Tags
Referenced Files
F2930751: Screen Shot 2017-02-15 at 11.48.17 AM.png
Feb 15 2017, 8:23 PM
F2931241: Screen Shot 2017-02-15 at 12.14.35 PM.png
Feb 15 2017, 8:23 PM
F2930434: Screen Shot 2017-02-15 at 11.32.03 AM.png
Feb 15 2017, 8:23 PM
F2930562: Screen Shot 2017-02-15 at 11.36.44 AM.png
Feb 15 2017, 8:23 PM
F2930396: Screen Shot 2017-02-15 at 11.28.19 AM.png
Feb 15 2017, 8:23 PM
F2931094: Screen Shot 2017-02-15 at 12.06.15 PM.png
Feb 15 2017, 8:23 PM
F2930565: Screen Shot 2017-02-15 at 11.37.51 AM.png
Feb 15 2017, 8:23 PM
F2931053: Screen Shot 2017-02-15 at 12.04.36 PM.png
Feb 15 2017, 8:23 PM
View All 14 Files
Subscribers
chad
epriestley
johnny-bit
joshuaspence
matthewrbowker
• tomekj2ee
Tokens
"Baby Tequila" token, awarded by avivey."Like" token, awarded by joshuaspence.

Description

  • The "Qualities" constraint in badges.search accepts numeric strings like "102". Maybe just drop this constraint from Conduit? I don't really love how badge qualities work internally, and if we hide them we don't have to fix this yet.
  • PhabricatorRecipientHasBadgeEdgeType seems to still be around

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Related Objects

Event Timeline

chad created this task.Feb 15 2017, 8:23 PM

Why do we need T10698 specifically? Seems overkill.

epriestley added a subscriber: epriestley.Feb 15 2017, 8:36 PM

I'm fine with just declining to implement that, it just seems like something we should fix if we're calling it a bug.

chad added a comment.Feb 15 2017, 8:37 PM

I'm just trying to understand the feedback. There are points that come very close to "redesign badges" to which I'm like years away from doing, if ever.

chad added a revision: Restricted Differential Revision.Feb 15 2017, 9:00 PM
chad added a commit: Restricted Diffusion Commit.Feb 15 2017, 9:06 PM
chad updated the task description. (Show Details)Feb 15 2017, 9:14 PM
matthewrbowker added a subscriber: matthewrbowker.Feb 16 2017, 5:29 PM
chad added a revision: Restricted Differential Revision.Feb 21 2017, 10:52 PM
chad added a commit: Restricted Diffusion Commit.Feb 21 2017, 10:53 PM
chad updated the task description. (Show Details)Feb 21 2017, 11:15 PM
chad added a revision: Restricted Differential Revision.Feb 23 2017, 7:47 PM
chad added a commit: Restricted Diffusion Commit.Feb 23 2017, 10:22 PM
chad added a revision: Restricted Differential Revision.Feb 24 2017, 8:57 PM
chad added a commit: Restricted Diffusion Commit.Feb 24 2017, 9:15 PM
chad added revisions: Restricted Differential Revision, Restricted Differential Revision.Feb 24 2017, 9:51 PM
chad updated the task description. (Show Details)Feb 24 2017, 9:53 PM
chad added a revision: Restricted Differential Revision.Feb 24 2017, 11:00 PM
chad updated the task description. (Show Details)Feb 24 2017, 11:01 PM
chad added a commit: Restricted Diffusion Commit.Feb 24 2017, 11:51 PM
joshuaspence added a subscriber: joshuaspence.Feb 25 2017, 6:01 AM
epriestley added a revision: Restricted Differential Revision.Feb 27 2017, 1:18 PM
epriestley added a comment.Feb 27 2017, 4:10 PM

After D17422, I used bin/lipsum to generate about 20,000 badges. (They all have USERS permission so the permission checks are about as fast as possible.)

The Profile → Badges page isn't actually that bad, only about ~2s. Not great, but not as bad as I'd feared.

The bigger issue is that every page with a timeline also spends ~2s just doing badge stuff.

chad added a comment.Feb 27 2017, 4:30 PM

thedude

epriestley added a commit: Restricted Diffusion Commit.Feb 27 2017, 5:10 PM
chad added a revision: Restricted Differential Revision.Mar 2 2017, 3:06 AM
chad added a revision: Restricted Differential Revision.Mar 2 2017, 3:08 AM
chad added a revision: Restricted Differential Revision.Mar 2 2017, 3:21 AM
chad added a commit: Restricted Diffusion Commit.Mar 2 2017, 2:30 PM
chad added a commit: Restricted Diffusion Commit.
chad updated the task description. (Show Details)Mar 2 2017, 9:47 PM
• tomekj2ee added a subscriber: • tomekj2ee.Mar 3 2017, 12:40 AM
chad updated the task description. (Show Details)Mar 3 2017, 4:58 PM
chad added a revision: Restricted Differential Revision.Mar 6 2017, 6:08 PM
johnny-bit added a subscriber: johnny-bit.Mar 6 2017, 6:12 PM
chad added a commit: Restricted Diffusion Commit.Mar 6 2017, 6:13 PM
chad updated the task description. (Show Details)Mar 6 2017, 7:02 PM
chad updated the task description. (Show Details)Mar 8 2017, 1:58 AM

... and then there was one ...

joshuaspence awarded a token.Mar 8 2017, 5:13 AM
avivey awarded a token.Mar 8 2017, 11:31 AM
chad added a comment.Mar 8 2017, 7:45 PM

Do you have a rough suggestion on what to do with badges.search? Seems like noone would use these feature regardless.

chad added a revision: Restricted Differential Revision.Mar 8 2017, 8:34 PM
epriestley added a comment.Mar 9 2017, 7:29 PM

I'll send you some kind of something-or-other for dropping "Quality" from Conduit for the moment.

epriestley added a revision: Restricted Differential Revision.Mar 9 2017, 7:43 PM
epriestley added a commit: Restricted Diffusion Commit.Mar 9 2017, 8:27 PM
chad mentioned this in T12387: Typo in code..Mar 12 2017, 4:08 AM
chad updated the task description. (Show Details)Mar 15 2017, 6:57 PM
chad added a revision: Restricted Differential Revision.Mar 16 2017, 3:18 AM
chad added a commit: Restricted Diffusion Commit.Mar 17 2017, 5:38 PM
epriestley added a revision: Restricted Differential Revision.Mar 24 2017, 9:01 PM
epriestley added a revision: Restricted Differential Revision.
epriestley added a commit: Restricted Diffusion Commit.Mar 24 2017, 9:11 PM
epriestley added a commit: Restricted Diffusion Commit.
chad closed this task as Resolved.Mar 24 2017, 9:32 PM
epriestley mentioned this in T12511: Add Support For User Definable Macro Or Template Markup to Phriction Similar To WikiMedia Templates.Apr 6 2017, 2:51 PM
Phabricator · Built by Phacility