Page MenuHomePhabricator

Unbeta Badges
Closed, ResolvedPublic

Assigned To
Authored By
chad
Feb 15 2017, 8:23 PM
Attached Files
F2930751: Screen Shot 2017-02-15 at 11.48.17 AM.png
Feb 15 2017, 8:23 PM
F2931241: Screen Shot 2017-02-15 at 12.14.35 PM.png
Feb 15 2017, 8:23 PM
F2930434: Screen Shot 2017-02-15 at 11.32.03 AM.png
Feb 15 2017, 8:23 PM
F2930562: Screen Shot 2017-02-15 at 11.36.44 AM.png
Feb 15 2017, 8:23 PM
F2930396: Screen Shot 2017-02-15 at 11.28.19 AM.png
Feb 15 2017, 8:23 PM
F2931094: Screen Shot 2017-02-15 at 12.06.15 PM.png
Feb 15 2017, 8:23 PM
F2930565: Screen Shot 2017-02-15 at 11.37.51 AM.png
Feb 15 2017, 8:23 PM
F2931053: Screen Shot 2017-02-15 at 12.04.36 PM.png
Feb 15 2017, 8:23 PM
Tokens
"Baby Tequila" token, awarded by avivey."Like" token, awarded by joshuaspence.

Description

  • The "Qualities" constraint in badges.search accepts numeric strings like "102". Maybe just drop this constraint from Conduit? I don't really love how badge qualities work internally, and if we hide them we don't have to fix this yet.
  • PhabricatorRecipientHasBadgeEdgeType seems to still be around

Event Timeline

Why do we need T10698 specifically? Seems overkill.

I'm fine with just declining to implement that, it just seems like something we should fix if we're calling it a bug.

I'm just trying to understand the feedback. There are points that come very close to "redesign badges" to which I'm like years away from doing, if ever.

After D17422, I used bin/lipsum to generate about 20,000 badges. (They all have USERS permission so the permission checks are about as fast as possible.)

The ProfileBadges page isn't actually that bad, only about ~2s. Not great, but not as bad as I'd feared.

The bigger issue is that every page with a timeline also spends ~2s just doing badge stuff.

... and then there was one ...

Do you have a rough suggestion on what to do with badges.search? Seems like noone would use these feature regardless.

I'll send you some kind of something-or-other for dropping "Quality" from Conduit for the moment.