Page MenuHomePhabricator
Feed Advanced Search

Aug 3 2017

hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Doesn't look like the repository will even attempt to clone over HTTPS:

Aug 3 2017, 7:31 AM · Feature Request

Aug 2 2017

joshuaspence added a comment to T12950: Regenerating thumbnails for memes is difficult.
In T12950#230520, @chad wrote:

Why did they need regenerating in the first place?

Aug 2 2017, 9:40 PM · Feature Request, Macros
chad added a comment to T12950: Regenerating thumbnails for memes is difficult.

Why did they need regenerating in the first place?

Aug 2 2017, 9:38 PM · Feature Request, Macros
joshuaspence created T12950: Regenerating thumbnails for memes is difficult.
Aug 2 2017, 9:12 PM · Feature Request, Macros
chad edited projects for T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one, added: Profile Menu Item; removed Workboards.
Aug 2 2017, 5:19 PM · Dashboards
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

This is an unusually low-tech solution but I can't think of any reasons why it won't work.

Aug 2 2017, 4:46 PM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

I'm obviously low on AM brian power today.

Aug 2 2017, 4:45 PM · Dashboards
epriestley renamed T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one from If a ProfileMenu has Link items, and one or more have request URI as the link target, highlight the first one to If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.
Aug 2 2017, 4:43 PM · Dashboards
rfreebern added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

Heh, that was going to be my suggestion in the original discourse post, but I figured it was too simplistic. Glad to hear we're on the same page. Thanks everyone!

Aug 2 2017, 4:42 PM · Dashboards
epriestley renamed T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one from Build a Workboard Query MenuItem? to If a ProfileMenu has Link items, and one or more have request URI as the link target, highlight the first one.
Aug 2 2017, 4:40 PM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

That sounds much easier than all the solutions I came up with.

Aug 2 2017, 4:39 PM · Dashboards
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

Is there any reason that the rule "if any menu items have the same link target as the request URI, highlight the first one" wouldn't work?

Aug 2 2017, 4:37 PM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

Or maybe there is a simple way to get the link to highlight, I couldn't think of one though.

Aug 2 2017, 4:33 PM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

A link doesn't stay highlighted if clicked on. Like dashboards, I can understand wanting multiple board views from the sidebar.

Aug 2 2017, 4:33 PM · Dashboards
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.
  • What's the root problem?
  • Why can't they use links?
  • How is this different from T12374?
Aug 2 2017, 4:31 PM · Dashboards
chad triaged T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one as Wishlist priority.
Aug 2 2017, 4:22 PM · Dashboards
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Oh, I didn't even expect that option to be configurable on Phacility given it's a security related setting. I'll turn it on and do some speed tests next week to see if I get any measurable difference in cloning.

Aug 2 2017, 2:04 PM · Feature Request
epriestley added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Have you enabled diffusion.allow-http-auth?

Aug 2 2017, 12:19 PM · Feature Request
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

When you click Clone in the Phacility UI on a repository, it doesn't show any HTTPS URLs. It's possible it works if you copy the URL from the address bar, but the UI in Phacility itself doesn't give any kind of indication that it will work.

Aug 2 2017, 5:07 AM · Feature Request

Aug 1 2017

chad added a comment to T10598: Options to display Real Name instead of username everywhere.

Feel free to use our Discourse for general admin questions (as opposed to our working tasks). Thank you!

Aug 1 2017, 6:16 PM · Feature Request
jessjohnson added a comment to T10598: Options to display Real Name instead of username everywhere.

@ofbeaton Thanks for the tips. Sounds better than the approach we are using to slightly modify the code base.

Aug 1 2017, 6:10 PM · Feature Request
ofbeaton added a comment to T10598: Options to display Real Name instead of username everywhere.

@jessjohnson We use puppet to deploy phabricator stable from a copy on a local file server, then have it run a shell script that applies our patches using git apply on .patch files. Lastly we restart services.

Aug 1 2017, 5:18 AM · Feature Request
jessjohnson added a comment to T10598: Options to display Real Name instead of username everywhere.

@ofbeaton Just curious what's your strategy on applying patches as part of your deployment for phabricator? Do you use a find/replace strategy? Apply diffs?

Aug 1 2017, 3:03 AM · Feature Request

Jul 31 2017

joshuaspence added a revision to T12919: Healthcheck endpoint for alternate file domain: D18303: Allow `/status/` endpoint to be served through alternate file domain.
Jul 31 2017, 11:13 AM · Files

Jul 27 2017

isfs added a comment to T12629: Start daemons that should be running but aren't.

Agreed. I haven't experienced the problem since I upgraded, so I think it was related to an earlier fix, even if it wasn't the identified fix (which should have already been in my install when I did have the problems). There's nothing that needs to be addressed here.

Jul 27 2017, 9:22 PM · Daemons, Feature Request
epriestley closed T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded. as Invalid.

This is vague and may not actually identify a problem; I don't plan to pursue it.

Jul 27 2017, 4:50 PM · Diffusion, Feature Request
epriestley merged T12278: Choose specific form on Create Subtask into T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.
Jul 27 2017, 4:29 PM · Feature Request
epriestley merged task T12278: Choose specific form on Create Subtask into T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.
Jul 27 2017, 4:29 PM · Maniphest, Feature Request
epriestley closed T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way as Wontfix.

This seems to mostly be a matter of taste, and we already have behavior similar to the behavior of git, which seems reasonable.

Jul 27 2017, 4:28 PM · Diffusion, Feature Request
epriestley closed T12601: Set default arguments of `ArcanistWorkflow` as Invalid.
Jul 27 2017, 2:40 PM · Feature Request
epriestley closed T12629: Start daemons that should be running but aren't as Invalid.

We aren't going to implement a bin/phd start-missing-daemon command.

Jul 27 2017, 2:32 PM · Daemons, Feature Request
epriestley renamed T12891: Phacility does not currently offer instances in the Sydney region from Slow cloning over Phacility SSH for large repository to Phacility does not currently offer instances in the Sydney region.
Jul 27 2017, 2:18 PM · Feature Request
epriestley merged T12939: Ponder seems to ignore all email settings into T10448: Modularize mail tags.
Jul 27 2017, 1:33 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged T12909: Calendar ignores email preferences if a user is invited via a project into T10448: Modularize mail tags.
Jul 27 2017, 1:31 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

Jul 24 2017

chad closed T12931: Fallback for incorrect default branch in Diffusion could be nicer as Resolved by committing rP69a7d57c3fda: Add a branch selector to Diffusion.
Jul 24 2017, 8:41 PM · Feature Request, Diffusion

Jul 23 2017

chad added a revision to T12931: Fallback for incorrect default branch in Diffusion could be nicer: D18267: Add a branch selector to Diffusion.
Jul 23 2017, 1:28 AM · Feature Request, Diffusion

Jul 21 2017

chad added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

I'll add a link too, it's reasonable.

Jul 21 2017, 11:32 PM · Feature Request, Diffusion
aubort added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

The problem here is the default for the default branch, when the user didn't set it explicitly. In a user perspective it's then hard to know there's this option at all. Some link to set the default branch from the error could be more clear, but I don't think that's a common in phab to do that.

Jul 21 2017, 11:16 PM · Feature Request, Diffusion
chad edited projects for T12931: Fallback for incorrect default branch in Diffusion could be nicer, added: Feature Request; removed Bug Report.
Jul 21 2017, 10:31 PM · Feature Request, Diffusion

Jul 17 2017

chad merged T12925: Warn more loudly when diffusion setups are broken? into T12896: It isn’t obvious when repository observation breaks.
Jul 17 2017, 10:49 PM · Diffusion, Feature Request

Jul 14 2017

ivo created T12921: Link to referenced object in transaction emails.
Jul 14 2017, 1:46 PM · Mail

Jul 13 2017

20after4 added a comment to T12896: It isn’t obvious when repository observation breaks.

We"solved" the problem with a small python daemon that pings repository_statusmessage.epoch every minute and calculates the delta. When these deltas surpass Phabricator's max delta (21,600 sec) we page the oncall. For repositories that are mission critical, we use a smaller value. It obviously isn't a perfect solution, but it gets the job done and it's been extremely stable.

Jul 13 2017, 7:34 PM · Diffusion, Feature Request

Jul 12 2017

joshuaspence created T12919: Healthcheck endpoint for alternate file domain.
Jul 12 2017, 9:58 PM · Files
chad added a comment to T12792: Consider an option to disable all popup notifications.

What if they're on the page, is that notification annoying? I love click that little guy.

Jul 12 2017, 6:13 PM · Feature Request, Customer Impact, Notifications
jmeador added a comment to T12792: Consider an option to disable all popup notifications.

+1, we've also had a handful of users request this as a per-user preference.

Jul 12 2017, 6:11 PM · Feature Request, Customer Impact, Notifications
saga.karlsson added a comment to T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.

Or just have a subtask-array configurable, going with the inline approach mentioned above:

Jul 12 2017, 1:29 PM · Feature Request
saga.karlsson added a comment to T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.

Also, it would be great if you can choose an optional "default subtask subtype" where you configure the subtypes. Something like this:

Jul 12 2017, 1:26 PM · Feature Request

Jul 11 2017

joshuaspence added a revision to T12910: Allow SES to be used for inbound mail: D18205: Add SNS mail endpoint.
Jul 11 2017, 1:53 PM · Mail

Jul 10 2017

epriestley added a comment to T12911: Better handling for users subscribed to objects they cannot see.

T4411 discusses some similar issues, although it predates Spaces and focuses on subscribers rather than assignees.

Jul 10 2017, 10:59 PM · Spaces, Feature Request
sshannin created T12911: Better handling for users subscribed to objects they cannot see.
Jul 10 2017, 10:52 PM · Spaces, Feature Request
joshuaspence created T12910: Allow SES to be used for inbound mail.
Jul 10 2017, 12:20 PM · Mail
joshuaspence updated the task description for T12908: Allow verbosity of Aphlict log to be reduced.
Jul 10 2017, 6:31 AM · Aphlict, Feature Request
joshuaspence created T12908: Allow verbosity of Aphlict log to be reduced.
Jul 10 2017, 6:31 AM · Aphlict, Feature Request

Jul 9 2017

chad updated the image for Feature Request from F1014086: project.png to F5039280: profile.
Jul 9 2017, 7:33 PM

Jul 8 2017

SphtKr added a comment to T12447: Missing documentation for crafting raw Conduit API requests.

The page implies that all I should need to do is POST up, for example, the following:

Can you point me at where that's implied so I can make it more clear? That isn't currently expected to work. ... We do not currently support a blob of JSON as the post body, and the documentation shouldn't imply that we do (if it does, I'll fix it).

Jul 8 2017, 7:46 AM · Conduit, Feature Request
avivey added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

Methinks that the Rube Goldberg solution for this would be to get unittest.skip to have another argument with a task number, and then validate with lint/runtime that it look like T1234. And then maybe grep the body of the ticket for the filename.

Jul 8 2017, 4:03 AM · Herald, Feature Request
csilvers added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

Can you change the syntax to something like @unittest.skip("Reasoning behind this decision...")?

Jul 8 2017, 3:06 AM · Herald, Feature Request
epriestley added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

That is, I think the right tool for the job is either runtime enforcement or lint enforcement: make unittest.skip() with no reason fail (so the tests don't pass) or make lint raise a warning like "unittest.skip() must have a comment above it explaining the plan for re-enabling the test.".

Jul 8 2017, 12:55 AM · Herald, Feature Request
epriestley added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

Can you change the syntax to something like @unittest.skip("Reasoning behind this decision...")?

Jul 8 2017, 12:46 AM · Herald, Feature Request
csilvers added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

I know about T9853, but if there's still a chance you might consider merging that upstream, there are a few folks here at Khan Academy who are excited by the feature. Here's one example:

Jul 8 2017, 12:40 AM · Herald, Feature Request

Jul 7 2017

epriestley merged task T12903: Can not visually differentiate between "stalled" and "open" tasks on a workboard into T10333: Add groups to workboard columns.
Jul 7 2017, 11:26 PM · Workboards, Feature Request
epriestley added a comment to T12903: Can not visually differentiate between "stalled" and "open" tasks on a workboard.

This is either T10333 or T4863. I'd guess the former will happen first. Filter is probably the best workaround until then. See also T12374 maybe, although I think that task involved a lot of meandering.

Jul 7 2017, 11:26 PM · Workboards, Feature Request
greggrossmeier created T12903: Can not visually differentiate between "stalled" and "open" tasks on a workboard.
Jul 7 2017, 11:20 PM · Workboards, Feature Request

Jul 6 2017

jmeador added a comment to T12896: It isn’t obvious when repository observation breaks.

This information may be entirely useless, but it is somewhat related. We have a large number of repositories, with multiple clusters so this affects us in a major way.

Jul 6 2017, 11:35 PM · Diffusion, Feature Request
epriestley added a comment to T12901: Support access policies for saved queries.

Have you actually tested this scenario yourself?

Jul 6 2017, 4:24 PM · Feature Request
eliaspro added a comment to T12901: Support access policies for saved queries.

Edit the Saved Query to contain something sensitive

This isn't possible.

Jul 6 2017, 4:15 PM · Feature Request
epriestley closed T12901: Support access policies for saved queries as Wontfix.

Edit the Saved Query to contain something sensitive

Jul 6 2017, 3:59 PM · Feature Request
eliaspro added a comment to T12901: Support access policies for saved queries.

A user might have a saved query which contains sensitive information no one else should know about.

How would other users discover the query's ID?

Jul 6 2017, 3:25 PM · Feature Request
epriestley added a comment to T12896: It isn’t obvious when repository observation breaks.

From elsewhere:

Jul 6 2017, 3:19 PM · Diffusion, Feature Request
epriestley added a comment to T12901: Support access policies for saved queries.

A user might have a saved query which contains sensitive information no one else should know about.

Jul 6 2017, 3:17 PM · Feature Request
eliaspro created T12901: Support access policies for saved queries.
Jul 6 2017, 3:15 PM · Feature Request
eliaspro added a comment to T12896: It isn’t obvious when repository observation breaks.

Also related: T12417: Show failing status of Diffusion repositories in top main menu bar.

Jul 6 2017, 1:23 PM · Diffusion, Feature Request

Jul 5 2017

alexmv added a comment to T12792: Consider an option to disable all popup notifications.

We've also had a request for this (disabling the in-application popups) at #dropbox, as a per-user preference.

Jul 5 2017, 11:46 PM · Feature Request, Customer Impact, Notifications
mruuska added a comment to T11535: Make it possible for arc land to disable upstream branch tracking.

Severely needed. .arcconfig should be able to control where things land without arguments. I also question the choice made in D10058 where branch tracking seems to be used as a indicator of a branch created with arc-feature. Since arc-feature is in no way central to arc use, I think it should not be assumed that it will be used. And regular workflows and GUI tools will use git-branch instead, with tracking.

Jul 5 2017, 1:10 PM · Arcanist, Restricted Project

Jul 4 2017

mavit created T12896: It isn’t obvious when repository observation breaks.
Jul 4 2017, 4:19 PM · Diffusion, Feature Request

Jul 2 2017

quark.zju added a comment to T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".

Parsing hg export metadata is an elegant solution. # HG changeset patch could imply sourceControlSystem = 'hg'. Thanks for merging the task!

Jul 2 2017, 7:30 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley merged task T12890: Add sourceControlSystem parameter to differential.createrawdiff into T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".
Jul 2 2017, 7:22 PM · Feature Request
epriestley merged T12890: Add sourceControlSystem parameter to differential.createrawdiff into T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".
Jul 2 2017, 7:22 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
quark.zju added a comment to T12890: Add sourceControlSystem parameter to differential.createrawdiff.

The background is the Mercurial community wants to try Phabricator as an experimental review system. It's using emails now. I'd like to make Phabricator workflow as convenient as traditional email workflow.

Jul 2 2017, 7:16 PM · Feature Request
epriestley added a comment to T12890: Add sourceControlSystem parameter to differential.createrawdiff.

I'm writing a Mercurial extension to send changesets to Differential like hg email provided by patchbomb extension.

Jul 2 2017, 6:51 PM · Feature Request
quark.zju created T12890: Add sourceControlSystem parameter to differential.createrawdiff.
Jul 2 2017, 6:47 PM · Feature Request

Jun 30 2017

jcox added a comment to T12880: Expose the ability to add some JS to every page.

Haha to be clear we're using an open-source self-hosted tracking solution, I was just throwing GA out there as an example. But I do understand your point vis-a-vis data security.

Jun 30 2017, 5:37 PM · Feature Request
epriestley added a comment to T12880: Expose the ability to add some JS to every page.

I guess everyone uses GMail nowadays anyway (as mandated by international galactic law) so my paranoia is probably mostly moot because they can undetectably read all email communication anyway.

Jun 30 2017, 5:14 PM · Feature Request
epriestley closed T12880: Expose the ability to add some JS to every page as Wontfix.

I think you probably won't be able to answer most of those questions with Google Analytics. For example, bots will never hit client-side analytics, so any question about bots probably can't be served by GA. Likewise, GA can't see Conduit/API activity.

Jun 30 2017, 2:45 PM · Feature Request
jcox added a comment to T12880: Expose the ability to add some JS to every page.

Why do you want to track users with Google Analytics or a similar library?

Jun 30 2017, 2:17 PM · Feature Request
epriestley added a comment to T12885: Warning For Past Events.

I think it's probably reasonable for us to warn about RSVP'ing to an event which has already ended. I'd guess this is usually a mistake, and in cases where it isn't some kind of weird off-label workflow is taking place and the warning is probably fine.

Jun 30 2017, 2:09 PM · Calendar, Feature Request

Jun 29 2017

CodeMouse92 created T12885: Warning For Past Events.
Jun 29 2017, 11:11 PM · Calendar, Feature Request
epriestley added a comment to T12880: Expose the ability to add some JS to every page.

Why do you want to track users with Google Analytics or a similar library?

Jun 29 2017, 4:07 PM · Feature Request
chad closed T12882: testing form configurations as Invalid.
Jun 29 2017, 7:18 AM · Feature Request
exp10r3r created T12882: testing form configurations.
Jun 29 2017, 7:13 AM · Feature Request
avivey added a comment to T12876: Improve initial arc land experience when destination repo is empty.

in T6722#197239 I had the same problem with "land revision from Web UI" :)

Jun 29 2017, 4:26 AM · Arcanist

Jun 28 2017

jcox added a comment to T12880: Expose the ability to add some JS to every page.

image.png (553×414 px, 298 KB)

Jun 28 2017, 7:55 PM · Feature Request
chad added a comment to T12880: Expose the ability to add some JS to every page.

tumblr_inline_op017kGTqT1teupc5_540.gif (345×498 px, 2 MB)

Jun 28 2017, 7:50 PM · Feature Request
jcox created T12880: Expose the ability to add some JS to every page.
Jun 28 2017, 7:42 PM · Feature Request
StingRayZA added a comment to T12873: Ability to display custom message during externally linked login prompt.

Thanks for this - suggested solution works perfectly!

Jun 28 2017, 10:20 AM · Feature Request

Jun 27 2017

amckinley created T12876: Improve initial arc land experience when destination repo is empty.
Jun 27 2017, 7:48 PM · Arcanist
epriestley closed T12875: How to see all user keys uploaded as Invalid.

See T12874. Your account will be disabled if you continue creating tasks like this. Follow the instructions you were given.

Jun 27 2017, 4:14 PM · Feature Request
marcoscorvalan created T12875: How to see all user keys uploaded .
Jun 27 2017, 3:34 PM · Feature Request
chad added a comment to T12874: HOw to see ALL user Keys uploaded.

See Support Resources

Jun 27 2017, 3:23 PM · Feature Request
chad closed T12874: HOw to see ALL user Keys uploaded as Invalid.
Jun 27 2017, 3:22 PM · Feature Request