Page MenuHomePhabricator
Create Task
Maniphest T10598

Options to display Real Name instead of username everywhere
Closed, DuplicatePublic
Actions

Description

root problem: usernames do not effectively communicate who a user is in my corporate environment, their real name does.

For those of us using LDAP (specifically Active Directory) registration in a corporate environment, our usernames are things like txf045 for a user like Tiffany Flanders. We already import the users Real Name through the LDAP integration, but seeing their username everywhere is confusing.

It would be great if there was an option we could enable to display their real name everywhere their username would usually be displayed.

Thank you for your consideration.

Related Objects

Event Timeline

ofbeaton created this task.Mar 16 2016, 2:07 AM
dereckson added a subscriber: dereckson.Mar 16 2016, 2:11 AM

I'm not sure this is a problem of Phabricator. It sounds like a problem of your LDAP conventions.

chad closed this task as a duplicate of T2950: Possibility to display the RealName instead of the UserName.Mar 16 2016, 2:12 AM
chad added a subscriber: chad.

Wow yeah, that's terrible.

dereckson added a comment.Mar 16 2016, 2:14 AM

@ofbeaton For more context and arguments to give if you wish to review your LDAP conventions, see T3167#32426.

ofbeaton added a comment.Mar 16 2016, 2:25 AM

Thanks, I thought I had searched before filing, but apparently not with the right terms. Thanks for the information. I wish I could change the LDAP conventions, but I control Phabricator, not Corporate IT LDAP in other departments.

chad added a comment.Mar 16 2016, 2:32 AM

If you're willing to maintain a fork / patch, this is probably just a few extra lines of code to get most of them.

chad added a comment.EditedMar 16 2016, 2:36 AM
diff --git a/src/applications/phid/PhabricatorObjectHandle.php b/src/applications/phid/PhabricatorObjectHandle.php
index 2b626f2..ad2ff9e 100644
--- a/src/applications/phid/PhabricatorObjectHandle.php
+++ b/src/applications/phid/PhabricatorObjectHandle.php
@@ -340,7 +340,7 @@ final class PhabricatorObjectHandle
   public function getLinkName() {
     switch ($this->getType()) {
       case PhabricatorPeopleUserPHIDType::TYPECONST:
-        $name = $this->getName();
+        $name = $this->getFullName();
         break;
       default:
         $name = $this->getFullName();
chad added a comment.Mar 16 2016, 2:43 AM

@ofbeaton ^^ That single line should convert 90% of the name links, if you need.

ofbeaton added a comment.Mar 19 2016, 10:20 PM

Thanks @chad, that worked great. I added applying the patch to our deployment script for phabricator. Much appreciated.

jessjohnson added a subscriber: jessjohnson.Aug 1 2017, 3:03 AM

@ofbeaton Just curious what's your strategy on applying patches as part of your deployment for phabricator? Do you use a find/replace strategy? Apply diffs?

ofbeaton added a comment.EditedAug 1 2017, 5:18 AM

@jessjohnson We use puppet to deploy phabricator stable from a copy on a local file server, then have it run a shell script that applies our patches using git apply on .patch files. Lastly we restart services.

Where appropriate/possible we drop in modules/extensions instead of changing the core code itself. Thankfully we haven't had to rebuild our current set of patches in a fairly long time.

Would much rather see upstream take on more options -- but they aren't, even when it's bugs (only a little salty), so what you gonna do? Have to fork :(

jessjohnson added a comment.Aug 1 2017, 6:10 PM

@ofbeaton Thanks for the tips. Sounds better than the approach we are using to slightly modify the code base.

chad added a comment.Aug 1 2017, 6:16 PM

Feel free to use our Discourse for general admin questions (as opposed to our working tasks). Thank you!

ofbeaton added a comment.Feb 2 2018, 6:40 PM

For those visiting from the future via search, I have decided to publish the unofficial patch in a github repo, as it breaks once in awhile due to upstream changes.

https://github.com/ofbeaton/phabricator-fullname

Support requests in how to use it should be directed at the github issues page.

Phabricator · Built by Phacility