Page MenuHomePhabricator

Set default arguments of `ArcanistWorkflow`
Closed, InvalidPublic

Description

The original motivation is to let arc diff use --lintall by default so our people don't need to pass the argument manually every time.

One solution I can think of is to add a setArgument method to ArcanistWorkflow so we can add --lintall argument in a customised ArcanistConfiguration.

Event Timeline

wjiang created this task.Apr 20 2017, 12:57 AM
wjiang added a subscriber: joshuaspence.

You are probably raising messages at "warning" severity, but want to raise them at "error" severity. See, e.g., here for a description:

T4287#47494

wjiang added a comment.EditedApr 20 2017, 1:13 AM

You are probably raising messages at "warning" severity, but want to raise them at "error" severity. See, e.g., here for a description:

T4287#47494

Not really, we actually want people to be responsible for the files they changed not just the changed lines.

The only behavior of --lintall is to make warnings act like errors. Just raise everything at error severity to achieve the same thing without patching anything.

The only behavior of --lintall is to make warnings act like errors. Just raise everything at error severity to achieve the same thing without patching anything.

Thanks for explanation :) I think we don't need this task anymore.

epriestley closed this task as Invalid.Jul 27 2017, 2:40 PM