Page MenuHomePhabricator

Ponder seems to ignore all email settings
Closed, ResolvedPublic


Observed Behavior:
After commenting on an answer to a ponder question, I become subscribed to any other answers or comments in the question. I have all of my settings in Email Preferences set to notify, but I still receive emails.

Expected Behavior:
Phabricator should be giving me notifications instead of emails.

Phabricator Version:
da2fbbf9926dd8b88f87763d2eb9e8f42b750916 (Apr 27 2017) (branched from 85ff1d5c2df03a7892eb14aec7eac6080e104714 on origin)
5d0f5afca8cdba3effa822b1d0f0ed3d90fec8b6 (Apr 25 2017)
a900d7b63e954e221efe140f0f33d3d701524aae (Apr 23 2017)

Reproduction Steps:
Comment on an answer that someone else made, to a question in Ponder that a third person made.

Revisions and Commits

Event Timeline

I suspect this is actually more like: actions on Ponder answers are not covered by the "Ponder Questions" email preferences, because a "Ponder Answer" is not the same type of object as a "Ponder Question".

Specifically, PonderAnswerTransaction does not add mail tags.

This will all be mooted by T10448.

I'm just going to merge this into T10448.

If you want to "fix" this prior to that, I think it's likely to be: add getMailTags() to PonderAnswerTransaction and have it return PonderQuestionTransaction::MAILTAG_OTHER for all transactions, to cover all "Answer" actions under the "Other question activity not listed above occurs." preference.