Page MenuHomePhabricator
Feed Advanced Search

Apr 20 2022

epriestley closed T13623: Notifications may fail to paginate with GROUP BY error as Resolved.

I think this was resolved. I nuked Discourse anyway so it's effectively resolved until another report shows up.

Apr 20 2022, 7:11 PM · Restricted Project, Notifications

Mar 12 2021

epriestley added a revision to T13623: Notifications may fail to paginate with GROUP BY error: D21609: Fix a followup notification paging error with partial objects.
Mar 12 2021, 5:08 PM · Restricted Project, Notifications

Mar 11 2021

epriestley added a revision to T13623: Notifications may fail to paginate with GROUP BY error: D21603: Fix an error when users receive notifications about objects they can no longer see.
Mar 11 2021, 6:34 PM · Restricted Project, Notifications
epriestley reopened T13623: Notifications may fail to paginate with GROUP BY error as "Open".

An issue arose when a user loads a page of notifications which include stories they don't have permission to view.

Mar 11 2021, 6:26 PM · Restricted Project, Notifications

Feb 26 2021

epriestley closed T13623: Notifications may fail to paginate with GROUP BY error as Resolved.

I deployed this and nothing blew up, presuming this is resolved.

Feb 26 2021, 11:50 PM · Restricted Project, Notifications
epriestley added a revision to T13623: Notifications may fail to paginate with GROUP BY error: D21577: Fix an issue where paginating notifications could fail a GROUP BY test.
Feb 26 2021, 6:45 PM · Restricted Project, Notifications
epriestley triaged T13623: Notifications may fail to paginate with GROUP BY error as Low priority.
Feb 26 2021, 6:37 PM · Restricted Project, Notifications

Feb 25 2021

epriestley added a comment to T13068: Refinements for "Mute Notifications".

When users are @mentioned on an object, render their name in a disabled style if they've been muted.

Feb 25 2021, 7:26 PM · Notifications, Mail

Sep 19 2019

epriestley updated the task description for T9515: Build a "quorum" mechanism and associated UI.
Sep 19 2019, 8:02 PM · Restricted Project, Notifications, Phacility, Auth

Sep 18 2019

epriestley updated the task description for T9515: Build a "quorum" mechanism and associated UI.
Sep 18 2019, 5:18 PM · Restricted Project, Notifications, Phacility, Auth

Mar 16 2019

epriestley placed T9515: Build a "quorum" mechanism and associated UI up for grabs.
Mar 16 2019, 8:41 PM · Restricted Project, Notifications, Phacility, Auth

Feb 25 2019

epriestley added a comment to T13068: Refinements for "Mute Notifications".

A very mild point in favor of this feature is that we haven't seen any negative feedback or confusion, although I think you might be the first user to say they actually like/use it.

Feb 25 2019, 2:31 PM · Notifications, Mail
20after4 added a comment to T13068: Refinements for "Mute Notifications".

FWIW I appreciate and use the mute feature (though only occasionally)

Feb 25 2019, 2:16 PM · Notifications, Mail

Jan 2 2019

epriestley moved T6162: Add an "Email and unread notification" option in user's Email Preferences from Backlog to Future on the Mail board.
Jan 2 2019, 5:05 PM · Notifications, llvm, Restricted Project, Mail

Apr 20 2018

epriestley closed T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view as Resolved by committing rP70d67a3908b8: Fix the most significant "phantom notification" badness.
Apr 20 2018, 12:24 AM · Wikimedia, Notifications

Apr 19 2018

epriestley added a comment to T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.

After D19384, we'll automatically mark these "phantom" notifications as read when you open the menu to review them:

Apr 19 2018, 6:09 PM · Wikimedia, Notifications
epriestley added a revision to T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view: D19384: Fix the most significant "phantom notification" badness.
Apr 19 2018, 5:59 PM · Wikimedia, Notifications

Feb 8 2018

epriestley added a project to T9031: When I ignore subscription changes, I'm not notified of being cc'ed: Mail.
Feb 8 2018, 8:49 PM · Mail, Notifications
epriestley added a revision to T9031: When I ignore subscription changes, I'm not notified of being cc'ed: D19035: When users are subscribed explicitly, count them as "mentioned".
Feb 8 2018, 8:37 PM · Mail, Notifications
epriestley added a comment to T13068: Refinements for "Mute Notifications".

I largely agree. This is getting leeway because it's backed by support mana (PHI126 basically just asks for this feature, verbatim). I think the actual change in D19033 is small enough that I don't feel too bad about giving this a shot, but I'd like this feature to see significant use and not generate a lot of confusion/support load if it's going to stay in the upstream. I'm also more comfortable trying this because it's very easy to revert.

Feb 8 2018, 8:10 PM · Notifications, Mail
avivey added a comment to T13068: Refinements for "Mute Notifications".

For what it's worth, I think the Mute feature adds a lot of complexities to the system, in excess to the norms of the last few years:

  • Code to handle it in the sending mechanism
  • Prioritizing this feature against any other notify feature (like T9031)
  • UI to show the to the muting user (on the object and in /mail/?)
  • UI to show to other users that this user will not be notified (What if all members of a project are muting a thread?)
  • Can a mailing list/project mute a topic?
  • "why did I not receive this notification?" - there's still some issues about this - novice users don't know/understand /mail/, and admins can't see this for them. I suspect this question will require a written checklist somewhere.
Feb 8 2018, 7:37 PM · Notifications, Mail
epriestley added a comment to T13068: Refinements for "Mute Notifications".

If this feature doesn't see much use, I'd like to remove or deemphasize it (for example, by moving it to a keystroke or removing the UI and just providing access via !mute) at some point since I think UI space in the curtain is premium real estate. This doesn't need to be 200 mutes per user per day, but I could imagine this seeing essentially zero use.

Feb 8 2018, 6:59 PM · Notifications, Mail
epriestley triaged T13068: Refinements for "Mute Notifications" as Low priority.
Feb 8 2018, 6:55 PM · Notifications, Mail

Nov 8 2017

Twilight added a comment to T8883: Allow desktop notifications to replace normal notifications.

Could this be closed now that Phab supports this? (in /settings/user/Username/page/notifications/)

Nov 8 2017, 3:27 AM · Notifications

Oct 11 2017

fzhan removed a member for Notifications: fzhan.
Oct 11 2017, 6:25 AM
fzhan added a member for Notifications: fzhan.
Oct 11 2017, 6:24 AM

Sep 13 2017

epriestley closed T12979: Sticky notifications no longer appear as Resolved by committing rP29f625ef6882: Make "No Notifications" setting less broad, and fix a bug with default display….
Sep 13 2017, 10:32 PM · Notifications
epriestley added a revision to T12979: Sticky notifications no longer appear: D18600: Make "No Notifications" setting less broad, and fix a bug with default display behavior.
Sep 13 2017, 9:59 PM · Notifications
epriestley claimed T12979: Sticky notifications no longer appear.

This is also affecting other persistent sticky notifications, notably "Read-Only Mode" and "High Security Mode". I need "Read-Only" mode for PHI36 so I'll take a look at this.

Sep 13 2017, 9:39 PM · Notifications

Sep 12 2017

chad added a project to T12979: Sticky notifications no longer appear: Notifications.
Sep 12 2017, 2:45 AM · Notifications

Aug 28 2017

chad closed T8944: Unread vs read notifications are difficult to distinguish when viewed at an indirect angle on a 13" Macbook Air as Resolved by committing rPed75250f1a9d: Update notification UI a little.
Aug 28 2017, 9:52 PM · PHUI, Notifications
chad added a revision to T8944: Unread vs read notifications are difficult to distinguish when viewed at an indirect angle on a 13" Macbook Air: D18485: Update notification UI a little.
Aug 28 2017, 9:49 PM · PHUI, Notifications
chad closed T7843: Marking all notifications as read - action flow tedious as Resolved.
Aug 28 2017, 8:50 PM · Notifications
chad added a revision to T7843: Marking all notifications as read - action flow tedious: D18483: Don't prompt to mark notifications as read if we don't need to.
Aug 28 2017, 8:50 PM · Notifications

Aug 23 2017

chad closed T12792: Consider an option to disable all popup notifications as Resolved by committing rP63bd1784b08c: Allow more granularity on real-time notifications.
Aug 23 2017, 9:45 PM · Feature Request, Customer Impact, Notifications
chad added a revision to T12792: Consider an option to disable all popup notifications: D18457: Allow more granularity on real-time notifications.
Aug 23 2017, 9:37 PM · Feature Request, Customer Impact, Notifications
chad added a comment to T12792: Consider an option to disable all popup notifications.

Should be quick to implement.

Aug 23 2017, 5:38 PM · Feature Request, Customer Impact, Notifications
chad claimed T12792: Consider an option to disable all popup notifications.
Aug 23 2017, 5:38 PM · Feature Request, Customer Impact, Notifications

Aug 16 2017

epriestley merged task T5891: Add button to notification panel to concatenate notifications on the same objects into T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Aug 16 2017, 6:58 PM · Notifications
epriestley added a comment to T5891: Add button to notification panel to concatenate notifications on the same objects.

I'm going to merge this into T12963, which isn't exactly the same but overlaps this substantially. It's possible we'll pursue a more narrow "vacation review" mode eventually, but we'd want to finish T12963 first and make sure it didn't adequately address this problem on its own.

Aug 16 2017, 6:58 PM · Notifications

Aug 6 2017

chad closed T8878: Make desktop notifications more discoverable as Resolved.

It's discoverable in settings just fine.

Aug 6 2017, 3:44 AM · User Preferences, Notifications

Jul 12 2017

chad added a comment to T12792: Consider an option to disable all popup notifications.

What if they're on the page, is that notification annoying? I love click that little guy.

Jul 12 2017, 6:13 PM · Feature Request, Customer Impact, Notifications
jmeador added a comment to T12792: Consider an option to disable all popup notifications.

+1, we've also had a handful of users request this as a per-user preference.

Jul 12 2017, 6:11 PM · Feature Request, Customer Impact, Notifications

Jul 5 2017

alexmv added a comment to T12792: Consider an option to disable all popup notifications.

We've also had a request for this (disabling the in-application popups) at #dropbox, as a per-user preference.

Jul 5 2017, 11:46 PM · Feature Request, Customer Impact, Notifications

Jun 18 2017

chad added a revision to T7843: Marking all notifications as read - action flow tedious: D18133: Remove dialog from "Mark All Read" notifications.
Jun 18 2017, 5:41 PM · Notifications

Jun 2 2017

epriestley added a comment to T12792: Consider an option to disable all popup notifications.

Arguments against:

Jun 2 2017, 11:03 PM · Feature Request, Customer Impact, Notifications
epriestley created T12792: Consider an option to disable all popup notifications.
Jun 2 2017, 10:40 PM · Feature Request, Customer Impact, Notifications

May 12 2017

mirage315 closed Q614: Does notification server has some ring tone when message pop up? as resolved.
May 12 2017, 1:43 AM · Notifications

May 4 2017

mirage315 updated Q614: Does notification server has some ring tone when message pop up? from Does notification server has some ring tone when message popup? to Does notification server has some ring tone when message pop up?.
May 4 2017, 5:53 AM · Notifications

May 3 2017

amckinley merged T12666: Make Conpherence sidebar show unread counts into T7332: Notification / Message icons should update in real-time.
May 3 2017, 11:54 PM · Conpherence (v4), Aphlict, Notifications

Apr 17 2017

epriestley moved T8878: Make desktop notifications more discoverable from Backlog to Desktop/Push on the Notifications board.
Apr 17 2017, 12:09 PM · User Preferences, Notifications
epriestley moved T8883: Allow desktop notifications to replace normal notifications from Backlog to Desktop/Push on the Notifications board.
Apr 17 2017, 12:09 PM · Notifications
epriestley moved T8924: Add push notification support from Backlog to Desktop/Push on the Notifications board.
Apr 17 2017, 12:09 PM · Notifications
epriestley moved T11008: Desktop notification action doesn't work after browsing away from Backlog to Desktop/Push on the Notifications board.
Apr 17 2017, 12:09 PM · Notifications
epriestley edited projects for T6162: Add an "Email and unread notification" option in user's Email Preferences, added: Notifications; removed Aphlict.
Apr 17 2017, 12:08 PM · Notifications, llvm, Restricted Project, Mail
epriestley moved T7332: Notification / Message icons should update in real-time from Backlog to vNext on the Aphlict board.
Apr 17 2017, 12:08 PM · Conpherence (v4), Aphlict, Notifications
epriestley moved T9515: Build a "quorum" mechanism and associated UI from Backlog to Future on the Notifications board.
Apr 17 2017, 12:07 PM · Restricted Project, Notifications, Phacility, Auth
epriestley moved T7332: Notification / Message icons should update in real-time from Backlog to Javascript! on the Conpherence (v4) board.
Apr 17 2017, 11:33 AM · Conpherence (v4), Aphlict, Notifications
epriestley moved T7332: Notification / Message icons should update in real-time from Backlog to v4 on the Conpherence board.
Apr 17 2017, 11:19 AM · Conpherence (v4), Aphlict, Notifications

Mar 29 2017

epriestley merged task T12469: Add option to manage email preferences for harbormaster into T10448: Modularize mail tags.
Mar 29 2017, 2:52 PM · Harbormaster, Notifications
Pawka created T12469: Add option to manage email preferences for harbormaster.
Mar 29 2017, 1:26 PM · Harbormaster, Notifications

Feb 21 2017

meshulam added a comment to T7843: Marking all notifications as read - action flow tedious.

Agreed this dialog is pretty annoying.

Feb 21 2017, 6:36 PM · Notifications

Jan 10 2017

epriestley merged task T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail into T10448: Modularize mail tags.
Jan 10 2017, 4:56 PM · Restricted Project, Mail, Audit, Notifications
epriestley added a comment to T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail.

I'm just going to merge this into T10448, this task doesn't have anything not already covered there.

Jan 10 2017, 4:56 PM · Restricted Project, Mail, Audit, Notifications

Jan 8 2017

epriestley merged T12078: Toolbar shows I have notifications when I have none. into T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.
Jan 8 2017, 12:37 AM · Wikimedia, Notifications
epriestley merged T12078: Toolbar shows I have notifications when I have none. into T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.
Jan 8 2017, 12:37 AM · Wikimedia, Notifications
epriestley merged task T12078: Toolbar shows I have notifications when I have none. into T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.
Jan 8 2017, 12:37 AM · Notifications, Bug Report
epriestley merged task T12078: Toolbar shows I have notifications when I have none. into T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.
Jan 8 2017, 12:37 AM · Notifications, Bug Report
Mnkras created T12078: Toolbar shows I have notifications when I have none..
Jan 8 2017, 12:33 AM · Notifications, Bug Report

Jan 4 2017

yelirekim updated subscribers of T9515: Build a "quorum" mechanism and associated UI.
Jan 4 2017, 6:04 PM · Restricted Project, Notifications, Phacility, Auth
epriestley added a comment to T9515: Build a "quorum" mechanism and associated UI.

100% accurate mockup of this feature

Jan 4 2017, 6:04 PM · Restricted Project, Notifications, Phacility, Auth
yelirekim added a comment to T9515: Build a "quorum" mechanism and associated UI.

hqdefault.jpg (360×480 px, 16 KB)

Jan 4 2017, 6:04 PM · Restricted Project, Notifications, Phacility, Auth

Oct 24 2016

aklapper created T11782: Inconsistent mail notification subject ([Updated] vs [Merged]) depending on from which task a duplicate task was merged.
Oct 24 2016, 11:10 AM · Mail, Maniphest, Bug Report

Oct 19 2016

stevex added a comment to T8145: Support global/broadcast notifications.

As said in Q501 it will be useful to have some components (e.g. an administrative panel) that appear on top of all the dashboards.

Oct 19 2016, 12:26 PM · Notifications

Sep 16 2016

epriestley merged T11649: User changing the task access to a project which another user is not member of, leads to a not visible active notification. into T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.
Sep 16 2016, 1:24 PM · Wikimedia, Notifications

Aug 10 2016

fooishbar added a comment to T8145: Support global/broadcast notifications.

Does anyone have a use case for this which isn't maintenance notifications?

Aug 10 2016, 9:26 PM · Notifications

Aug 5 2016

eadler added a project to T7887: method to dismiss/acknowledge individual notifications: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Notifications
eadler added a project to T9515: Build a "quorum" mechanism and associated UI: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Notifications, Phacility, Auth
eadler added a project to T9284: Generate mail and notifications for an object when it is mentioned on another object: Restricted Project.
Aug 5 2016, 5:09 PM · Restricted Project, Mail, Notifications

Aug 4 2016

epriestley added a comment to T8145: Support global/broadcast notifications.

(Possibly it might be easier to select the correct audience in Phabricator since you can use projects or other rules, but all of the use cases here and elsewhere just want to hit everyone, I think.)

Aug 4 2016, 5:32 PM · Notifications
epriestley added a comment to T8145: Support global/broadcast notifications.

Yeah, basically like the Facebook Rooster system except making it act as "pinned notifications" instead of "pinned dashboard panels". We could do either, reasonably, although it's slightly messier to do a real-time notification of "a new panel appeared on all dashboards, go look". But I'm basically not sure why this is better than email in any case where the users are employees.

Aug 4 2016, 5:30 PM · Notifications
epriestley added a comment to T8145: Support global/broadcast notifications.

I think a global banner (or some equally omnipresent, persistent element) is reasonable for "this system is going down in a couple of minutes". But if that's the only really good use case we have for it, though, I wonder if we shouldn't just build a "shutdown in X minutes" feature that automatically does this, counts down, stops new batch jobs from starting, maybe pauses builds, puts the system into read-only when the countdown finishes, etc. -- a dedicated "graceful shutdown" feature instead of just a broadcast feature. I don't think any of these things are really problems today, but I could imagine more of a "shutdown process" being useful in the future.

Aug 4 2016, 5:27 PM · Notifications
chad added a comment to T8145: Support global/broadcast notifications.

The "Rooster" system we had at Facebook is essentially a panel (closable) that would persist on every homepage. I would be OK forcing a panel onto all dashboards if the users can also close it. I think we need closable panels for NUX anyways. But the issue is this is still a "pull" notification, meaning the user has to visit a page to get the information. A "push" system (notification, email) is better for things like downtime. "pull" systems are good for just general FYI stuff (all-hands meeting upcoming).

Aug 4 2016, 5:23 PM · Notifications
bjshively added a comment to T8145: Support global/broadcast notifications.

To your point, we did have some users complain that even just on the primary dashboard a ticking timer was a bit distracting. But, you know, when your boss's boss's boss asks if something is feasible, you at least look into it. :) And I think countdown scenario aside, a global information display that doesn't assume the user has some specific dashboard config is potentially valuable.

Aug 4 2016, 5:10 PM · Notifications
bjshively added a comment to T8145: Support global/broadcast notifications.

@epriestley, somewhat an edict from on high, but I do think there is potentially some value in a persistent banner (a single row tall, similar to the main phab bar but perhaps even a bit skinnier.)

Aug 4 2016, 5:08 PM · Notifications
epriestley updated subscribers of T8145: Support global/broadcast notifications.

@bjshively, for this use case:

Aug 4 2016, 4:49 PM · Notifications
epriestley added a comment to T8145: Support global/broadcast notifications.
  • T11427 is similar.
  • T10855 discusses a similar and possibly overlapping use case (mirroring system status into Phabricator), but I believe that use case isn't after global/on-all-pages notifications.
Aug 4 2016, 4:44 PM · Notifications
epriestley renamed T8145: Support global/broadcast notifications from Send notification from command line? to Support global/broadcast notifications.
Aug 4 2016, 4:37 PM · Notifications

Jul 25 2016

eadler added a project to T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail: Restricted Project.
Jul 25 2016, 4:54 PM · Restricted Project, Mail, Audit, Notifications

Jul 16 2016

epriestley added a parent task for T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail: T10448: Modularize mail tags.
Jul 16 2016, 5:33 PM · Restricted Project, Mail, Audit, Notifications
epriestley moved T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail from Backlog to v3 on the Mail board.
Jul 16 2016, 2:25 PM · Restricted Project, Mail, Audit, Notifications
epriestley moved T7004: Don't send email whilst online from Backlog to Far Future on the Mail board.
Jul 16 2016, 2:25 PM · Notifications, Mail

Jul 8 2016

epriestley closed T11097: Pop-up notifications picked up a timestamp as a side effect as Resolved by committing rPbd6d300282ec: Strip timestamps from popup notification bubbles.
Jul 8 2016, 2:46 PM · Notifications
epriestley added a revision to T11097: Pop-up notifications picked up a timestamp as a side effect: D16258: Strip timestamps from popup notification bubbles.
Jul 8 2016, 2:41 PM · Notifications

Jun 6 2016

epriestley added a comment to T11103: Browser do not connect to aphlict (notification) server using ssl terminating nginx reverse proxy.

T10402 is the "check client/server agreement about HTTPS" task.

Jun 6 2016, 6:54 PM · Notifications, Aphlict, Bug Report
asherkin added a comment to T11103: Browser do not connect to aphlict (notification) server using ssl terminating nginx reverse proxy.

Configuring the Preamble script is important for reverse-proxied configurations (you probably need to set REMOTE_ADDR up as well), and required for many things - which is why it is part of the install guide.

Jun 6 2016, 6:45 PM · Notifications, Aphlict, Bug Report
chad closed T11103: Browser do not connect to aphlict (notification) server using ssl terminating nginx reverse proxy as Resolved.
Jun 6 2016, 6:44 PM · Notifications, Aphlict, Bug Report
cguenther added a comment to T11103: Browser do not connect to aphlict (notification) server using ssl terminating nginx reverse proxy.

Wow, thanks for your fast and precise answers!! Using the file

Jun 6 2016, 6:39 PM · Notifications, Aphlict, Bug Report
asherkin added a comment to T11103: Browser do not connect to aphlict (notification) server using ssl terminating nginx reverse proxy.

We ran into this on a recent install - the fix was to configure the Preamble script to tell Phabricator it was being accessed over HTTPS (else it filtered out the HTTPS notification server) - check to see if "Connected" or "Disconnected" at the bottom of the notification popup (menu at the top of the screen - see this install). If you just get a grey bar at the bottom without either, you're hitting the same case where the client doesn't think it has a valid notification server.

Jun 6 2016, 6:21 PM · Notifications, Aphlict, Bug Report
eadler added a comment to T11103: Browser do not connect to aphlict (notification) server using ssl terminating nginx reverse proxy.
https://hub.docker.com/r/hachque/phabricator/

is not supported by this install

Jun 6 2016, 5:30 PM · Notifications, Aphlict, Bug Report