Page MenuHomePhabricator

Generate mail and notifications for an object when it is mentioned on another object
Open, Needs TriagePublic

Description

I would like to receive emails/notifications when a task that I am subscribed to is mentioned. I had a situation in which someone's diff basically said "this is now possible because Txyz has been resolved". Their understanding was, in fact, incorrect and I only came across it because I was browsing through recently closed tickets in order to generate a weekly report. This would have allowed me to notice this issue (misunderstanding of the state of a particular task) earlier.

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a subscriber: joshuaspence.

(Happy to implement this if it is desirable for the upstream)

chad awarded a token.Aug 30 2015, 4:26 PM
chad added a subscriber: chad.

sounds good to me

epriestley added a subscriber: epriestley.EditedAug 31 2015, 1:02 PM

Implementing this feature just involves deleting the code in PhabricatorApplicationTransaction->shouldHideForMail() which prevents these from sending mail.

They're currently hidden because:

  • when you're subscribed to both objects (task/task, task/commit, commit/revision, etc.), this tends to generate a duplicate event which has no value to you (you get mail about X having a comment, and about Y being mentioned in a comment on X);
  • the value of these is normally pretty low;
  • general issues in T9161.

I'd like to have a clearer path forward on T9161 before pursuing this.

It's probably also worthwhile to implement some idea of "related events", and pass that down the Editor stack, so if we tell user A about the original edit, they don't get notifications or mail about the implicit edit on the related object. Maybe.

epriestley renamed this task from Notifications for mentions to Generate mail and notifications for an object when it is mentioned on another object.EditedAug 31 2015, 1:04 PM
epriestley edited projects, added Mailing Lists; removed Maniphest.
epriestley edited projects, added Mail; removed Mailing Lists.

(A similar block in shouldHideForFeed() prevents these from publishing redundant feed stories, and stops the actual notifications.)

chad added a comment.Aug 31 2015, 4:00 PM

oh, I completely misread this. I thought it was mentioned me not mentioned thing I'm subscribed to. I'd like to recant my 'sounds great' to 'idk'.

eadler added a subscriber: eadler.Mar 22 2016, 9:59 PM
eadler added a project: Restricted Project.Aug 5 2016, 5:09 PM