Page MenuHomePhabricator
Feed Advanced Search

May 16 2017

epriestley moved T5232: Keyboard shortcut to create inline comment from Backlog to Reticle on the Inline Comments board.
May 16 2017, 8:15 PM · Inline Comments, Differential
epriestley moved T1026: Request: ability to select line range for comment via touchscreen from Glitches to Reticle on the Inline Comments board.
May 16 2017, 8:15 PM · Inline Comments, Differential
epriestley added a comment to T9269: Undoing multiple inline comments on the same line will restore the comment out of position..

Sorry, yes, that was a disappointing way to phrase it. You may open a thousand editors and put any number of them between zero and all of them, inclusive, into any of the various undo states.

May 16 2017, 8:13 PM · Inline Comments, Differential
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 8:10 PM · Inline Comments
epriestley closed T9269: Undoing multiple inline comments on the same line will restore the comment out of position. as Resolved.

This no longer reproduces after D17916.

May 16 2017, 8:09 PM · Inline Comments, Differential
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 16 2017, 8:06 PM · Inline Comments
epriestley moved T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff from Editor to Reticle on the Inline Comments board.
May 16 2017, 6:11 PM · Inline Comments, Differential
epriestley moved T10668: When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI from Editor to Reticle on the Inline Comments board.
May 16 2017, 6:11 PM · Inline Comments, Restricted Project, Differential
epriestley closed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 6:10 PM · Inline Comments, Differential, Bug Report
epriestley closed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately, a subtask of T12634: Keyboard focus reticle is generally oblivious to the world around it, as Resolved.
May 16 2017, 6:09 PM · Differential, Inline Comments
epriestley closed T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 6:06 PM · Inline Comments, Differential, Bug Report
epriestley added a revision to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately: Unknown Object (Differential Revision).
May 16 2017, 6:06 PM · Inline Comments, Differential, Bug Report
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 16 2017, 6:06 PM · Inline Comments
epriestley renamed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately from Jumping to an inline comment via URL anchor should highlight it with the keyboard focus reticle to Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.
May 16 2017, 5:39 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.

I'm inclined not to actually pursue the autofocus approach I was considering before, at least until we get a better read on whether click-to-select is a good behavior or not. Instead, I'm just going to fiddle with the UI a bit to fix the alignment issue. The new hidden inline state has some similar alignment issues.

May 16 2017, 5:38 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T5030: Improve behavior when jumping to inline comments.

(If something you care about got merged here and isn't covered at HEAD / by T12616, feel free to file a new report or feature request adhering to modern guidelines.)

May 16 2017, 5:35 PM · Inline Comments, Restricted Project, Differential
epriestley closed T5030: Improve behavior when jumping to inline comments as Wontfix.

I'm not sure this task has any specific, actionable issues remaining. Partly, it has just been open for twenty five decades and become a bit of a dumping ground.

May 16 2017, 5:34 PM · Inline Comments, Restricted Project, Differential
epriestley closed T5030: Improve behavior when jumping to inline comments, a subtask of T5179: Unearth Differential rendering technical debt, as Wontfix.
May 16 2017, 5:34 PM · Differential
epriestley added a comment to T8592: "View on previous revision" button on ghosted comment can jump to wrong place.

I think it's also possible that this was T11784.

May 16 2017, 5:27 PM · Differential, Restricted Project
epriestley added a revision to T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content: Unknown Object (Differential Revision).
May 16 2017, 5:21 PM · Inline Comments, Differential, Bug Report
epriestley closed T8420: Hidden inlines don't work properly with anchor-based navigation as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 5:12 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T8420: Hidden inlines don't work properly with anchor-based navigation: Unknown Object (Differential Revision).
May 16 2017, 5:08 PM · Inline Comments, Restricted Project, Differential
epriestley renamed T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset from Toggling File Browser on Differential while creating inline comment causes keyboard focus reticle to offset to Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset.
May 16 2017, 4:49 PM · Inline Comments, Differential
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

The keyboard reticle has been fixed but the inline reticle is still at large.

May 16 2017, 4:46 PM · Inline Comments, Quicksand
epriestley closed T12634: Keyboard focus reticle is generally oblivious to the world around it as Resolved.

I think the keyboard reticle now generally has reasonable behavior.

May 16 2017, 4:45 PM · Differential, Inline Comments
epriestley closed T12715: Availability of inline "Reply" action is inconsistent as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 4:44 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 16 2017, 4:34 PM · Inline Comments
epriestley added a revision to T12715: Availability of inline "Reply" action is inconsistent: Unknown Object (Differential Revision).
May 16 2017, 4:34 PM · Inline Comments
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

This is going to get even worse:

May 16 2017, 4:08 PM · Design, Differential, Inline Comments
epriestley closed T8130: Keyboard shortcut for "Done", a subtask of T1460: Add "Done" link to an inline comment, as Resolved.
May 16 2017, 3:23 PM · User Delight, Differential
epriestley closed T8130: Keyboard shortcut for "Done" as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 3:23 PM · Inline Comments, Restricted Project, Differential
epriestley closed T8131: Clicking "Done" breaks keyboard navigation as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 3:23 PM · Inline Comments, Restricted Project, Differential
epriestley closed T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 3:22 PM · Inline Comments
epriestley closed T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle, a subtask of T12634: Keyboard focus reticle is generally oblivious to the world around it, as Resolved.
May 16 2017, 3:22 PM · Differential, Inline Comments
epriestley closed T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 3:22 PM · Inline Comments, Differential
epriestley closed T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it, a subtask of T12634: Keyboard focus reticle is generally oblivious to the world around it, as Resolved.
May 16 2017, 3:22 PM · Differential, Inline Comments
epriestley closed T12632: Resizing a diff does not resize the keyboard focus reticle as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 3:21 PM · Inline Comments
epriestley closed T12632: Resizing a diff does not resize the keyboard focus reticle, a subtask of T12634: Keyboard focus reticle is generally oblivious to the world around it, as Resolved.
May 16 2017, 3:21 PM · Differential, Inline Comments
epriestley added a revision to T8130: Keyboard shortcut for "Done": Unknown Object (Differential Revision).
May 16 2017, 3:07 PM · Inline Comments, Restricted Project, Differential
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 2:32 PM · Inline Comments
epriestley added a revision to T8131: Clicking "Done" breaks keyboard navigation: Unknown Object (Differential Revision).
May 16 2017, 2:31 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 2:31 PM · Differential, Inline Comments
epriestley added a revision to T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle: Unknown Object (Differential Revision).
May 16 2017, 2:13 PM · Inline Comments
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 2:13 PM · Differential, Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 2:07 PM · Inline Comments
epriestley added a comment to T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it.

I've marked D17903 as fixing this. We still keep the comment focused, but comments no longer collapse en-masse after changes in T12616. Current state of the world is:

May 16 2017, 2:07 PM · Inline Comments, Differential
epriestley added a revision to T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it: Unknown Object (Differential Revision).
May 16 2017, 2:05 PM · Inline Comments, Differential
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 2:05 PM · Differential, Inline Comments
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 2:01 PM · Differential, Inline Comments
epriestley added a revision to T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset: Unknown Object (Differential Revision).
May 16 2017, 2:01 PM · Inline Comments, Differential
epriestley added a comment to T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset.

This discusses the hover/edit reticle, but the keyboard reticle has the same bug.

May 16 2017, 1:59 PM · Inline Comments, Differential
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 1:54 PM · Differential, Inline Comments
epriestley added a revision to T12632: Resizing a diff does not resize the keyboard focus reticle: Unknown Object (Differential Revision).
May 16 2017, 1:54 PM · Inline Comments
epriestley added a revision to T8047: Differential inline reticle can persist across Quicksand navigations: Unknown Object (Differential Revision).
May 16 2017, 1:47 PM · Inline Comments, Quicksand
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 1:47 PM · Differential, Inline Comments
epriestley created T12717: KeyboardShortcutManager is not Quicksand-aware.
May 16 2017, 1:45 PM · Inline Comments, Quicksand
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 1:39 PM · Differential, Inline Comments
epriestley moved T8047: Differential inline reticle can persist across Quicksand navigations from Glitches to Reticle on the Inline Comments board.
May 16 2017, 1:28 PM · Inline Comments, Quicksand
epriestley closed T11093: DifferentialInlineCommentEditor retains state across Quicksand requests as Resolved.

I believe this is now resolved by the series of changes attached to T12616. In particular, D17840 introduced Quicksand-aware state to changeset lists.

May 16 2017, 1:26 PM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley closed T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000 as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 1:20 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

That's partly because "\n" isn't a newline in bash:

May 16 2017, 12:58 PM · Bug Report
epriestley added a comment to T12616: Modernize display code for inline comments.

I think we're mostly in the clear, now. This stuff likely introduces some bugs beyond the (mostly minor) ones I'm aware of, but I think it's all correct enough in the substantial ways. I'm going to take a break for a bit; I may get back to it tonight and land everything or may wait until tomorrow.

May 16 2017, 12:45 AM · Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 12:36 AM · Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 12:35 AM · Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 12:35 AM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 16 2017, 12:33 AM · Inline Comments

May 15 2017

epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 15 2017, 11:49 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 15 2017, 11:30 PM · Inline Comments
epriestley changed the point value for T12715: Availability of inline "Reply" action is inconsistent from 2 to 1.
May 15 2017, 11:27 PM · Inline Comments
• tomekj2ee awarded T8783: Unprototype Nuance (v1) a Love token.
May 15 2017, 10:30 PM · Nuance, Restricted Project
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 15 2017, 10:10 PM · Inline Comments
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

All of the inline comment icons got mis-aligned slightly a while ago. This is particularly visible with "Reply", I think. Note that the tooltip is centered, but the icon is too low (I think?) and too far to the right.

May 15 2017, 9:12 PM · Design, Differential, Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 15 2017, 8:15 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 15 2017, 7:53 PM · Inline Comments
epriestley moved T12715: Availability of inline "Reply" action is inconsistent from Backlog to Glitches on the Inline Comments board.
May 15 2017, 7:43 PM · Inline Comments
epriestley created T12715: Availability of inline "Reply" action is inconsistent.
May 15 2017, 7:43 PM · Inline Comments
epriestley added a comment to T4096: Generated gif-macros are not animated.

@jeffprouty Shoot us an email at support@phacility.com with details about your instance and the issue you're hitting if you're a paying customer; see also https://admin.phacility.com/book/phacility/article/support/.

May 15 2017, 5:54 PM · Macros
epriestley removed a project from T12714: `differential.createcomment` can race automatic revision closure: EditEngine.
May 15 2017, 5:10 PM · Transactions, Bug Report, Restricted Project
epriestley added a project to T12714: `differential.createcomment` can race automatic revision closure: EditEngine.
May 15 2017, 5:10 PM · Transactions, Bug Report, Restricted Project
epriestley added a project to T12714: `differential.createcomment` can race automatic revision closure: Transactions.
May 15 2017, 5:10 PM · Transactions, Bug Report, Restricted Project
epriestley created T12714: `differential.createcomment` can race automatic revision closure.
May 15 2017, 5:09 PM · Transactions, Bug Report, Restricted Project
epriestley reassigned T12713: Can't view user profiles from epriestley to chad.
May 15 2017, 3:48 PM · Bug Report
epriestley added a comment to T12713: Can't view user profiles.

Go for it, a couple emails came in that I'm still digging through. Thanks!

May 15 2017, 3:47 PM · Bug Report
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

We currently (at least, in theory) prevent this situation from ever occurring by preventing simultaneous tagging with both "Warp Drive > Thermocoupling" and "Warp Drive > Milestone 1". Since a task can not appear in both a milestone and subproject of a particular parent task, users can never be faced with the opportunity to perform a destructive drag operation.

May 15 2017, 3:39 PM · Bug Report
epriestley claimed T12713: Can't view user profiles.
May 15 2017, 3:31 PM · Bug Report
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

Many of the patches you've personally contributed in the past have bypassed the bulk of the requirements under the "Rise to Prominence" clause of Contributing Code, since you have a history with the project, are a member of Community, and have generally contributed very focused patches with clear context:

May 15 2017, 3:11 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

Okay. When a task is in "Warp Drive > Thermocoupling" and "Warp Drive > Milestone 1", and you view the "Warp Drive" board and drag the task from "Milestone 1" to "Backlog", what do you expect to happen to the projecs the task is tagged with?

May 15 2017, 2:52 PM · Bug Report
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

Per above, see Planning. If that isn't clear, let me know how we could improve it.

May 15 2017, 2:48 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

Do you expect a task to be able to be tagged with "Warp Drive" and also simultaneously tagged with subproject "Warp Drive > Thermocoupling"?
Do you expect a task to be able to be tagged with "Warp Drive" and also simultaneously tagged with milestone "Warp Drive > Milestone 1"?

May 15 2017, 2:44 PM · Bug Report
epriestley added a comment to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

This should now be resolved in HEAD of master and stable. Thanks for the report!

May 15 2017, 1:45 PM · Projects, Bug Report
epriestley closed T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them as Resolved by committing Restricted Diffusion Commit.
May 15 2017, 1:44 PM · Projects, Bug Report
epriestley renamed T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them from Project profile broken to Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.
May 15 2017, 1:43 PM · Projects, Bug Report
epriestley edited projects for T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them, added: Bug Report, Projects; removed Bug Report (Needs Information).
May 15 2017, 1:42 PM · Projects, Bug Report
epriestley added a revision to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them: Unknown Object (Differential Revision).
May 15 2017, 1:38 PM · Projects, Bug Report
epriestley added a comment to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

I'll just ship up the "unbreak" diff, and you can either counter-diff me or figure out something else.

May 15 2017, 1:36 PM · Projects, Bug Report
epriestley updated subscribers of T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

I think more narrow reproduction instructions are:

May 15 2017, 1:35 PM · Projects, Bug Report
epriestley edited projects for T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them, added: Bug Report (Needs Information); removed Bug Report.
May 15 2017, 11:12 AM · Projects, Bug Report
epriestley added a comment to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

I can't reproduce this. Here's an example of a profile working correctly for me locally:

May 15 2017, 11:12 AM · Projects, Bug Report
epriestley closed T12712: Sort tasks in the advance search by creation date as Resolved.

Select "Order By: Creation (Newest First)" or "Order By: Creation (Oldest First)".

May 15 2017, 11:10 AM · Feature Request
epriestley added a comment to T12707: Add "watching" to Project ApplicationSearch.

ah mkay

May 15 2017, 12:16 AM · Projects