Page MenuHomePhabricator

"View on previous revision" button on ghosted comment can jump to wrong place
Closed, DuplicatePublic


When I click "View on previous revision" on a ghosted comment, it opens /DXXXX?id=YYYY#inline-ZZZZ in a new tab.

When the page fully finishes loading, I am often viewing a part of the diff completely unrelated to where the comment was originally posted. When this happens, I do see the comment for a split second, but then it will almost instantaneously scroll out of view.

I haven't fully tracked this down, but what I think is happening is that my browser is jumping to the anchor tag before all files have finished loading, and then as files load into view, that either changes my scroll position or keeps the scroll position fixed while changing what's visible in the current browser viewport.

(It's possible that this is a dupe or a sub-part of T5030. Feel free to merge it in if so.)

Event Timeline

jhurwitz raised the priority of this task from to Needs Triage.
jhurwitz updated the task description. (Show Details)
jhurwitz added projects: Restricted Project, Differential.
jhurwitz added subscribers: jhurwitz, angie, sbezek.

This is likely the same as T5030, but I haven't observed it myself and haven't spent the time to try to reproduce it.

@jhurwitz can you confirm these tasks are the same?

I suspect they're the same, but I'm not confident. I'm happy with closing this as a duplicate, and then trying to repro after T5030 is fixed.

angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Sep 10 2015, 6:38 PM

I think it's also possible that this was T11784.