Page MenuHomePhabricator
Feed Advanced Search

Feb 16 2017

epriestley removed a watcher for Feature Request: • tawels74.
Feb 16 2017, 12:09 PM
CodingNickNick awarded T2393: Adds a "Needs Verification" state to Audits a Love token.
Feb 16 2017, 11:40 AM · Restricted Project, Audit
epriestley updated subscribers of T12276: Allow to configure arc commit message.

Also, please work with other KDE project members to discuss KDE priorities and needs downstream, then have a single point of contact (nominally, @bcooksley) bring them upstream once there is consensus on the nature and priority of problems. Currently, you, @abika, and @bcooksley are all independently interacting with this upstream.

Feb 16 2017, 12:24 AM · KDE, Feature Request
avivey awarded T12271: When users accept a revision, allow them to accept for a subset of package/project reviewers they could accept for a Yellow Medal token.
Feb 16 2017, 12:24 AM · Audit, Restricted Project, Differential

Feb 15 2017

epriestley added a comment to T12276: Allow to configure arc commit message.

What specific modifications are you interested in making to the messages?

Feb 15 2017, 11:55 PM · KDE, Feature Request
epriestley merged T12274: Find/filter inline comments that are not "Done" into T8909: Provide ability to hide all inline or done comments.
Feb 15 2017, 10:35 PM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD
epriestley merged task T12274: Find/filter inline comments that are not "Done" into T8909: Provide ability to hide all inline or done comments.
Feb 15 2017, 10:35 PM · Differential, Feature Request
epriestley added a comment to T2794: Implement Phage (like Hypershell).

I'm making some amount of progress here, although I've only made it slightly past "run SSH in a loop" so far.

Feb 15 2017, 9:42 PM · Phage, Infrastructure
epriestley edited the content of Object Name Prefixes / Monograms.
Feb 15 2017, 9:35 PM
epriestley added a comment to T11050: Allow resigning from a review you are not directly responsible for.

Worth mentioning is that you can query for exact(username) to get a dashboard for only individual reviews, but this is a partial solution; there's no way to get a dashboard for "all my stuff, except stuff I've explicitly said I don't care about".

Feb 15 2017, 9:31 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley added a comment to T11050: Allow resigning from a review you are not directly responsible for.

This task has meandered a bit, but the current behavior is this:

Feb 15 2017, 9:30 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley added a project to T12272: Allow users to accept on behalf of packages they control a containing package for: Owners.
Feb 15 2017, 9:02 PM · Owners, Audit, Restricted Project, Differential
epriestley created T12272: Allow users to accept on behalf of packages they control a containing package for.
Feb 15 2017, 9:02 PM · Owners, Audit, Restricted Project, Differential
epriestley added a comment to T12270: Unbeta Badges.

I'm fine with just declining to implement that, it just seems like something we should fix if we're calling it a bug.

Feb 15 2017, 8:36 PM · Badges (v0)
epriestley created T12271: When users accept a revision, allow them to accept for a subset of package/project reviewers they could accept for.
Feb 15 2017, 8:32 PM · Audit, Restricted Project, Differential
epriestley created T12268: Make the grey "Unverified User" dot accurately reflect the new universal behavior.
Feb 15 2017, 11:19 AM · Mail, People
epriestley added a comment to T12266: arc set-config encoding XXX not work.

I think it was historically possible for third-party code to read custom config, but not possible for them to add new settings until D16928 (Nov 2016), which might be why we don't warn about bad values. Should be fine to do so now, though.

Feb 15 2017, 11:13 AM · Bug Report
epriestley edited this Badge.
Feb 15 2017, 11:07 AM
epriestley closed T11114: Move Differential to EditEngine as Resolved.

I think we've ended up in a fairly stable place here, and remaining work generally has existing tasks motivating it in terms of features (like T10967 for reviewers, T10574 for acceptance rules, T2543 for revision states, various tasks for inlines, T9713 for commit message parsing). Obsoleted transaction types also need migrations (but they should happen alongside the migrations that other features require so we're minimizing the number of weeks with migrations that need special planning) and this dumb mess got left in PhabricatorModularTransaction.php and will probably be there for an uncomfortably long time:

Feb 15 2017, 1:23 AM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential

Feb 14 2017

epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

We'll probably implement a Phabricator-side mute-this-thread in connection with T10448, I'm just guessing that some of the users complaining that GMail mute doesn't work won't consider clicking a link in the email body, then clicking "Mute Thread" to be an acceptable solution.

Feb 14 2017, 7:01 PM · Restricted Project, Mail, Feature Request
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

I'm pretty sure we can't generate our own Message-ID with Amazon SES, at least -- although we use the HTTP API, not the SMTP API, and maybe the rules differ. Not sure about other providers.

Feb 14 2017, 6:56 PM · Restricted Project, Mail, Feature Request
epriestley closed T12263: Javascript licence as Invalid.

See the LICENSE file for license information.

Feb 14 2017, 6:49 PM · Feature Request
epriestley edited the content of Starmap.
Feb 14 2017, 3:25 PM
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 14 2017, 3:17 PM · Phage, Infrastructure
epriestley added a comment to T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for.

(Or we should just remove CAN_JOIN -- is there any actual use case for read-only rooms? If there is, shouldn't users still be able to join those rooms in order to follow them, just not send messages?)

Feb 14 2017, 3:08 PM · Conpherence (v4), Security
epriestley added a comment to T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for.

A related issue is that CAN_EDIT does not imply CAN_JOIN, so users with CAN_EDIT but no CAN_JOIN can get a policy error while trying to join.

Feb 14 2017, 3:07 PM · Conpherence (v4), Security
epriestley added a comment to T12258: Diviner atom document status inverted when searching.

(Your diagnosis of the root cause was also correct.)

Feb 14 2017, 12:05 PM · Diviner, Bug Report
epriestley added a comment to T12258: Diviner atom document status inverted when searching.

I deployed D17346 and rebuilt the indexes on this install with bin/search index --type DivinerLiveSymbol and behavior now seems correct. Thanks for the report!

Feb 14 2017, 12:05 PM · Diviner, Bug Report
epriestley added a comment to T12013: Enabling zlib.output_compression results in wrong Content-Length.

Please file a new task following the instructions in Contributing Bug Reports if you'd like us to take a look. We need all that information before we can start looking at a bug.

Feb 14 2017, 12:00 PM · Bug Report
epriestley added a subtask for T12101: Phabricator PHP 7 Compatibility: T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.
Feb 14 2017, 11:54 AM · Infrastructure, Guides
epriestley added a parent task for T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts: T12101: Phabricator PHP 7 Compatibility.
Feb 14 2017, 11:54 AM · Bug Report
epriestley renamed T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts from `arc liberate` fails on Phabricator miraculously with PHP 7.1 to PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.
Feb 14 2017, 11:54 AM · Bug Report
epriestley merged task T12262: ./bin/repository update - throws segfault into T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.
Feb 14 2017, 11:53 AM · Bug Report
epriestley merged T12262: ./bin/repository update - throws segfault into T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.
Feb 14 2017, 11:53 AM · Bug Report
epriestley added a comment to T12262: ./bin/repository update - throws segfault.

I'm going to merge this into T12196; this is almost certainly an issue with PHP7. Upgrading to PHP 7.1.2 may resolve it.

Feb 14 2017, 11:53 AM · Bug Report

Feb 13 2017

epriestley closed T12237: Amazon SES has suspended outbound mail from secure.phabricator.com as Resolved.

Possible followups from D17344:

Feb 13 2017, 11:06 PM · Mail, Phacility, Ops
epriestley set the image for KDE to F2868791: profile.
Feb 13 2017, 11:03 PM
epriestley closed T12258: Diviner atom document status inverted when searching as Resolved by committing Restricted Diffusion Commit.
Feb 13 2017, 9:12 PM · Diviner, Bug Report
epriestley added a project to T12258: Diviner atom document status inverted when searching: Diviner.
Feb 13 2017, 9:08 PM · Diviner, Bug Report
epriestley added a comment to T10538: Bridge GitHub to Phabricator.

See Planning for help with timelines and status.

Feb 13 2017, 9:07 PM · Nuance, GitHub
epriestley added a revision to T12258: Diviner atom document status inverted when searching: Unknown Object (Differential Revision).
Feb 13 2017, 9:07 PM · Diviner, Bug Report
epriestley closed T12255: Landing differential from other author does not preserve ownership as Invalid.

See downstream for general discussion. See T12256 / T12257 for upstream followups.

Feb 13 2017, 8:45 PM · KDE, Bug Report
epriestley created T12257: Add an "author email" field to the "Differential Diff" Herald rule.
Feb 13 2017, 8:42 PM · KDE, Herald, Differential
epriestley created T12256: Parse multiple commits and commit metadata from "git show" and "git format-patch".
Feb 13 2017, 8:29 PM · Differential, KDE
epriestley closed T10105: Disabled account should disable all outbound mail as Wontfix.

Example: I disabled a bogus user when the "confirm your e-mail" MTA job was on its ~200th attempt. It's now at its ~240th attempt :)

Feb 13 2017, 6:42 PM · llvm, Restricted Project, Mail, Bug Report
epriestley added a project to T12255: Landing differential from other author does not preserve ownership: KDE.
Feb 13 2017, 6:08 PM · KDE, Bug Report
epriestley added a revision to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com: Unknown Object (Differential Revision).
Feb 13 2017, 5:58 PM · Mail, Phacility, Ops
epriestley updated subscribers of T12255: Landing differential from other author does not preserve ownership.

This is a copy of downstream https://phabricator.kde.org/T5242. See that task for discussion.

Feb 13 2017, 5:54 PM · KDE, Bug Report
epriestley renamed T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks from Only evaluate newly added mentions when applying transactions to remarkup blocks to Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.
Feb 13 2017, 4:46 PM · Prioritized, Wikimedia, Remarkup
epriestley created P2031 sell_private_user_data_to_the_highest_bidder.diff.
Feb 13 2017, 4:24 PM
epriestley merged T12254: re-subscribes on edit into T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.
Feb 13 2017, 3:57 PM · Prioritized, Wikimedia, Remarkup
epriestley merged task T12254: re-subscribes on edit into T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.
Feb 13 2017, 3:57 PM · Bug Report
epriestley added a comment to T12253: null in remarkup rather than comment reference when quoting a comment in audit.

Thanks, this should now be fixed in HEAD of master. Let us know if you run into anything else.

Feb 13 2017, 3:44 PM · Diffusion, Bug Report
epriestley closed T12253: null in remarkup rather than comment reference when quoting a comment in audit as Resolved by committing Restricted Diffusion Commit.
Feb 13 2017, 3:44 PM · Diffusion, Bug Report
epriestley added a revision to T12253: null in remarkup rather than comment reference when quoting a comment in audit: Unknown Object (Differential Revision).
Feb 13 2017, 3:42 PM · Diffusion, Bug Report
epriestley claimed T12253: null in remarkup rather than comment reference when quoting a comment in audit.
Feb 13 2017, 3:38 PM · Diffusion, Bug Report
epriestley closed T12245: When creating an auth provider, the header says "Enabled" but you haven't created it yet as Resolved.

Resolved by D17337.

Feb 13 2017, 3:03 PM · Auth
epriestley closed T12252: Unhandled Exception ("RuntimeException") at Conduit Call Logs page as Resolved by committing Restricted Diffusion Commit.
Feb 13 2017, 2:24 PM · Conduit, Bug Report
epriestley claimed T12252: Unhandled Exception ("RuntimeException") at Conduit Call Logs page.
Feb 13 2017, 2:23 PM · Conduit, Bug Report
epriestley removed a watcher for Bug Report: • greedhector28.
Feb 13 2017, 2:22 PM
epriestley removed a watcher for Bug Report: • Alexmoon2.
Feb 13 2017, 2:22 PM
epriestley added a revision to T12252: Unhandled Exception ("RuntimeException") at Conduit Call Logs page: Unknown Object (Differential Revision).
Feb 13 2017, 2:18 PM · Conduit, Bug Report
epriestley added a comment to T12177: Provide time-to-review statistics and reporting in Facts.

The WMF downstream has some similar discussion here and in linked tasks:

Feb 13 2017, 1:17 PM · Customer Impact, Differential, Restricted Project, Facts, Feature Request
epriestley added a project to T12177: Provide time-to-review statistics and reporting in Facts: Differential.
Feb 13 2017, 1:06 PM · Customer Impact, Differential, Restricted Project, Facts, Feature Request
epriestley renamed T12177: Provide time-to-review statistics and reporting in Facts from Use case for Facts and ETL to Provide time-to-review statistics and reporting in Facts.
Feb 13 2017, 1:06 PM · Customer Impact, Differential, Restricted Project, Facts, Feature Request
epriestley triaged T12251: Add author information when creating a build in Buildkite as Wishlist priority.
Feb 13 2017, 12:56 PM · Harbormaster, Feature Request
epriestley edited the content of Changelog.
Feb 13 2017, 12:44 PM
epriestley created 2017 Week 6 (Mid February).
Feb 13 2017, 12:43 PM
epriestley closed T12249: Test-BR as Invalid.
Feb 13 2017, 10:32 AM · Bug Report

Feb 12 2017

epriestley added a comment to T12172: Better color scheme for diffs.

T5701 describes a strategy for Pygments styles. I don't think we should tackle that as an accessibility issue, but I think building it as a user preference issue is reasonable.

Feb 12 2017, 1:10 PM · Accessibility, Feature Request
epriestley added a comment to T12173: Support Buildkite as a Harbormaster target.

If you configure your project so that arc unit runs your tests and then make your Buildkite build run arc unit --everything --target $HARBORMASTER_TARGET_PHID --conduit-token ..., you should get full reporting support. Then arc unit on its own will also work, arc diff will get the same integration, etc.

Feb 12 2017, 12:43 PM · Harbormaster, Phacility
johnny-bit awarded T7930: Let Calendar provide date services to other applications a Love token.
Feb 12 2017, 10:35 AM · Calendar

Feb 11 2017

epriestley deleted Linkable Object Auto Increment.
Feb 11 2017, 9:53 PM
epriestley added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

hiding policy controls when creating panels in context of the Arrange Panels page seems like a good way to minimize this

Feb 11 2017, 3:15 PM · Dashboards
epriestley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

No idea if realistic, but what if this "feature" is only enabled on installs of less than 6 months (or with the right db schema or something)?

Feb 11 2017, 2:37 PM · Customer Impact, Feature Request
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

Those seem to have been the magic words:

Feb 11 2017, 12:59 PM · Mail, Phacility, Ops
epriestley added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

Panels can currently appear on multiple dashboards, so we can't use the dashboard's policy for them directly. If we could, you could always see any panel by creating a new dashboard you have permission to see, adding every panel to it, and looking at the panel you wanted.

Feb 11 2017, 12:06 PM · Dashboards
• greedhector28 awarded T12245: When creating an auth provider, the header says "Enabled" but you haven't created it yet a Dislike token.
Feb 11 2017, 4:10 AM · Auth
epriestley added a comment to T12238: Write a script to populate a Phacility instance with the "Locations" scenario.

The LocationsResource file is completely copy/pasted and wrong (still refers to "Instances").

Feb 11 2017, 12:55 AM · Phacility
epriestley added a comment to T5301: Inline Remarkup escaping.

I think the complexity of those rules exceeds their utility.

Feb 11 2017, 12:42 AM · Remarkup
epriestley added a comment to T12238: Write a script to populate a Phacility instance with the "Locations" scenario.

Base scenario should create the appropriate edge tables.

Feb 11 2017, 12:13 AM · Phacility
epriestley closed T12224: Phortune "Autopay" on View controller does not respect disabled payment methods as Resolved by committing Restricted Diffusion Commit.
Feb 11 2017, 12:02 AM · Phortune
epriestley created T12245: When creating an auth provider, the header says "Enabled" but you haven't created it yet.
Feb 11 2017, 12:00 AM · Auth

Feb 10 2017

epriestley added a comment to T12238: Write a script to populate a Phacility instance with the "Locations" scenario.

And phabricator.developer-mode and phabricator.developer-mode and phabricator.developer-mode and also phabricator.show-prototypes.

Feb 10 2017, 11:39 PM · Phacility
epriestley added a comment to T12238: Write a script to populate a Phacility instance with the "Locations" scenario.

We should suggest configuring phabricator.developer-mode and phabricator.developer-mode (for UIExamples, to see icons).

Feb 10 2017, 11:38 PM · Phacility
epriestley created T12244: Provide a crude way to selectively disable reads and writes of repository devices by setting flags on Almanac bindings.
Feb 10 2017, 6:03 PM · Restricted Project, Almanac
epriestley closed T12242: arc commandeer as Resolved.
Feb 10 2017, 5:48 PM · Feature Request
epriestley added a comment to T12242: arc commandeer.

I suppose that I'm being lazy, but the exact same argument exists for arc close-revision or arc upload.

Feb 10 2017, 5:27 PM · Feature Request
epriestley closed T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log as Resolved.

The db001 issue is still an issue, but the shard has managed to stay just under 80% for the last couple of weeks so we're not in any immediate peril. As followups, I think T12217 and T12218 better capture the broader issues here.

Feb 10 2017, 5:12 PM · Phacility, Ops, Applications
epriestley closed T12150: Restricting Push not working as Invalid.

We haven't received any more information about this in a little more than two weeks, and don't know how to reproduce it so we can't move forward. Feel free to file a new task if you're able to come up with reproduction steps which work in a clean environment.

Feb 10 2017, 5:10 PM · Bug Report (Needs Information)
epriestley added a comment to T12157: Make it visibly clearer that a Phabricator user account has been disabled.

I think there are some more things worth doing here, but user profiles should be significantly more clear after recent changes. Here's @demo on this install now:

Feb 10 2017, 5:07 PM · Profile, Feature Request
epriestley added a comment to T12167: Unable to edit menu items on mobile.

Oh we already had one of these

Feb 10 2017, 5:05 PM · Profile Menu Item, Bug Report
epriestley closed T12168: Upgrading: Owners Packages/Commits now use edges as Resolved.

Presuming this is resolved since it's extremely boring and I ran it here and on every instance in the production cluster last week without any issues, but yell if you run into problems.

Feb 10 2017, 5:05 PM · Diffusion (v3), Installing & Upgrading, Audit
epriestley closed T12173: Support Buildkite as a Harbormaster target, a subtask of T9456: Evaluate upstream support for third-party build systems, as Resolved.
Feb 10 2017, 5:04 PM · Restricted Project, Harbormaster
epriestley closed T12173: Support Buildkite as a Harbormaster target as Resolved.

Presuming this is resolved since we haven't seen any evidence otherwise, but feel free to file followups if you run into issues or limitations.

Feb 10 2017, 5:04 PM · Harbormaster, Phacility
epriestley updated the task description for T12174: Home Menu Errata.
Feb 10 2017, 4:59 PM · Dashboards (v2), Profile Menu Item
epriestley closed T12198: Database seen as uninitialized after upgrade....cannot recover as Invalid.

We haven't received information that lets us reproduce this in about a week.

Feb 10 2017, 4:57 PM · Bug Report (Needs Information)
epriestley added a comment to T12218: Reduce the operational cost of a larger Phacility cluster.

I scratched at the surface of T2794, but @chad also bought me a larger monitor so I can put more SSH terminals on it which should buy us another few weeks.

Feb 10 2017, 4:55 PM · Ops, Phacility
epriestley added a comment to T12222: Add custom fields to the "Task Action..." menu.
  • Why do you track "percent complete"? What do you use it for?
  • Is it actually accurate? Developers are notoriously bad at estimating project timelines, so I would naively guess that a "Percent" field would have almost no relationship to reality.
Feb 10 2017, 4:55 PM · Maniphest, Feature Request
epriestley added a revision to T12224: Phortune "Autopay" on View controller does not respect disabled payment methods: Unknown Object (Differential Revision).
Feb 10 2017, 4:50 PM · Phortune