Page MenuHomePhabricator

Diviner atom document status inverted when searching
Closed, ResolvedPublic

Description

Reproduction steps:

Expected Result:

  • I see a list of open Diviner Atoms

Observed Result:

Version Information:

Just guessing, but it seems like it's caused by the ordering of the second and third expressions at DivinerLiveSymbolFulltextEngine.php$35-37 since the phabricator_diviner.diviner_livesymbol.graphHash is only nulled when the atom is deleted?

Event Timeline

I deployed D17346 and rebuilt the indexes on this install with bin/search index --type DivinerLiveSymbol and behavior now seems correct. Thanks for the report!

(Your diagnosis of the root cause was also correct.)

successkid

+1 for random grepping. Thanks for the fix!