Page MenuHomePhabricator
Create Task
Maniphest T12258

Diviner atom document status inverted when searching
Closed, ResolvedPublic
Actions

Description

Reproduction steps:

Expected Result:

  • I see a list of open Diviner Atoms

Observed Result:

Version Information:

  • rP9c62a10989e0
  • rARC67a47acebd6b
  • rPHU58fb3b94464e

Just guessing, but it seems like it's caused by the ordering of the second and third expressions at DivinerLiveSymbolFulltextEngine.php$35-37 since the phabricator_diviner.diviner_livesymbol.graphHash is only nulled when the atom is deleted?

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

faulconbridge created this task.Feb 13 2017, 8:49 PM
epriestley added a revision: Restricted Differential Revision.Feb 13 2017, 9:07 PM
epriestley added a project: Diviner.Feb 13 2017, 9:08 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Feb 13 2017, 9:12 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a subscriber: epriestley.Feb 14 2017, 12:05 PM

I deployed D17346 and rebuilt the indexes on this install with bin/search index --type DivinerLiveSymbol and behavior now seems correct. Thanks for the report!

epriestley added a comment.Feb 14 2017, 12:05 PM

(Your diagnosis of the root cause was also correct.)

faulconbridge added a comment.Feb 14 2017, 1:00 PM

successkid

+1 for random grepping. Thanks for the fix!

Phabricator · Built by Phacility