See also PHI1275. Now that Phriction supports relative references in [[ ... ]] syntax, moves should be able to modify those references.

New before:

• Remove "h1" rule, which is never used (the largest header is "<h2>", with the page header being "<h1>").
• Adjust sizes a bit more.
• Remove redundant weird override in some other file.
• Simplify margins slightly.

This also means that the actual page header (for example, the document title on a Phriction page) may be smaller than an <h1> in the same document.

• Add a couple of extra non-semantic newlines to the test cases for prettiness.

• More wordsmithing.

Oh, I edited "an to edit" into "an rule to edit" or something. Perhaps not my greatest work.

• Wordsmithing.

I'm just going to close this in the hope it fades quietly into the night now that it has been "fixed".

D20563 probably fixes mail. I don't think (?) it will fix notifications but haven't hunted that down yet.

• Share more API in Differential.
• Add support in Diffusion for good measure.

This likely affects other similar dialogs. The fix is to duct-tape something in Quicksand to something in the "click an area to click a link" behavior, most likely.

Oh, sure, that's pretty reasonable.

Shouldn't DifferentialTransactionEditor->buildMailBody() get an update to use this new API?

¯\_(ツ)_/¯

The changelog for PHP 7.3.6 mentions "Fixed possible crashes, because of inconsistent PCRE cache and opcache SHM reset." which might be relevant, but no bug link so who knows.

This is the last of my linter improvement diffs for a while.

A sort of broad issue here is that Herald sometimes knows (or could know, or could guess, or maybe could speculate) that a rule won't do what you expect, but it doesn't tell you.

I think this is about as good as we're going to get, and we've only taken a very small step toward the precipice of a self-aware Herald that hates humankind.