HomePhabricator

Require valid comments to contain at least one non-whitespace character

Description

Require valid comments to contain at least one non-whitespace character

Summary:
See downstream https://phabricator.wikimedia.org/T88655. This is very marginal, but we currently allow comments consisting of only whitespace.

These are probably always mistakes, so treat them like completely empty comments.

(We intentionally do not trim leading or trailing whitespace from comments when posting them becuase leading spaces can be used to trigger codeblock formatting.)

Test Plan:

  • Posted empty, nonempty, and whitespace-only comments.
  • Whitespace-only comments now have the same behavior as truly empty comments (e.g., do not actually generate a transaction).

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20562

Details

Provenance
epriestleyAuthored on May 30 2019, 7:23 PM
epriestleyPushed on May 30 2019, 10:15 PM
Reviewer
amckinley
Differential Revision
D20562: Require valid comments to contain at least one non-whitespace character
Parents
rP874720480775: Clean up "phabricator.timezone" configuration instructions a little bit
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22926
Build 31453: Run Core Tests