Description

See D20558, which I cowboy'd because it (probably?) blocked the normal review flow. It's now stuck as a draft.

When a user takes a "Close Revision" action or we discover a commit and close a revision in response, we should also promote the revision out of "Draft".

(We shouldn't do this if a revision is abandoned, because "abandon a draft" is an explicit supported workflow.)

Revisions and Commits

rP Phabricator
	D20565	rP760406762a6f When a revision is closed, always promote it out of draft

Related Objects

Mentioned Here: D20558: Test for "CAN_INTERACT" on comment edits in a way that survives objects which only implement "CAN_VIEW"

Event Timeline

epriestley created this task.May 28 2019, 5:22 PM

Herald added a subscriber: amckinley. · View Herald TranscriptMay 28 2019, 5:22 PM

epriestley triaged this task as Low priority.May 28 2019, 5:22 PM

epriestley added a revision: D20565: When a revision is closed, always promote it out of draft.May 31 2019, 1:18 PM

epriestley closed this task as Resolved by committing rP760406762a6f: When a revision is closed, always promote it out of draft.Jun 4 2019, 1:56 PM

epriestley claimed this task.

epriestley added a commit: rP760406762a6f: When a revision is closed, always promote it out of draft.

When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promoteClosed, ResolvedPublicActions

Description

Revisions and Commits

Related Objects

Event Timeline

When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promote
Closed, ResolvedPublic
Actions