Page MenuHomePhabricator

After reloading transactions for the recipient while building transaction mail, put them in the input order
ClosedPublic

Authored by epriestley on May 30 2019, 10:37 PM.

Details

Summary

Ref T13303. In D20525 I fixed an issue where transaction rendering could use cached values with the wrong viewer by reloading transactions.

However, reloading transactions may also reorder them as a side effect, since withPHIDs(...) does not imply an order. This can make transaction rendering order in mail wrong/inconsistent.

Instead, reorder the transactions before continuing so mail transaction order is consistent.

Test Plan

Applied a group of transactions to a task, saw a more consistent rendering order in mail after the change.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.