After reloading transactions for the recipient while building transaction mail, put them in the input order
ClosedPublic
Actions

Authored by epriestley on May 30 2019, 10:37 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes

Commits

rP81134d7e7d54: After reloading transactions for the recipient while building transaction mail…

Summary

Ref T13303. In D20525 I fixed an issue where transaction rendering could use cached values with the wrong viewer by reloading transactions.

However, reloading transactions may also reorder them as a side effect, since withPHIDs(...) does not imply an order. This can make transaction rendering order in mail wrong/inconsistent.

Instead, reorder the transactions before continuing so mail transaction order is consistent.

Test Plan

Applied a group of transactions to a task, saw a more consistent rendering order in mail after the change.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 30 2019, 10:37 PM

Harbormaster completed remote builds in B22929: Diff 49054.May 30 2019, 10:39 PM

epriestley requested review of this revision.May 30 2019, 10:39 PM

epriestley mentioned this in T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.May 30 2019, 11:15 PM

amckinley accepted this revision.May 30 2019, 11:50 PM

This revision is now accepted and ready to land.May 30 2019, 11:50 PM

Closed by commit rP81134d7e7d54: After reloading transactions for the recipient while building transaction mail… (authored by epriestley). · Explain WhyMay 31 2019, 12:15 AM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP81134d7e7d54: After reloading transactions for the recipient while building transaction mail….

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

5 lines

Diff 49056

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

After reloading transactions for the recipient while building transaction mail, put them in the input orderClosedPublicActions