Page MenuHomePhabricator

Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles").
ClosedPublic

Authored by epriestley on May 30 2019, 3:07 PM.

Details

Summary

See downstream https://phabricator.wikimedia.org/T902. Currently, timezones are rendered with their raw internal names (like America/Los_Angeles) which include underscores.

Replacing underscores with spaces is a more human-readable (and perhaps meaningfully better for things like screen readers, although this is pure speculation).

There's some vague argument against this, like "administrators may need to set a raw internal value in phabricator.timezone and this could mislead them", but we already give a pretty good error message if you do this and could improve hinting if necessary.

Test Plan

Viewed timezone list in Settings and the timezone "reconcile" dialog, saw a more-readable "Los Angeles".

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 30 2019, 3:07 PM
epriestley requested review of this revision.May 30 2019, 3:09 PM
epriestley edited the summary of this revision. (Show Details)May 30 2019, 3:20 PM
amckinley accepted this revision.May 30 2019, 7:00 PM
amckinley edited the test plan for this revision. (Show Details)

¯\_(ツ)_/¯

This revision is now accepted and ready to land.May 30 2019, 7:00 PM
epriestley edited the summary of this revision. (Show Details)May 30 2019, 7:03 PM