Page MenuHomePhabricator

Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles").
ClosedPublic

Authored by epriestley on May 30 2019, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 5:32 AM
Unknown Object (File)
Thu, Nov 21, 11:24 AM
Unknown Object (File)
Thu, Nov 21, 11:07 AM
Unknown Object (File)
Sat, Nov 16, 11:52 PM
Unknown Object (File)
Oct 21 2024, 7:19 AM
Unknown Object (File)
Oct 20 2024, 2:40 PM
Unknown Object (File)
Oct 20 2024, 9:48 AM
Unknown Object (File)
Oct 19 2024, 7:41 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T902. Currently, timezones are rendered with their raw internal names (like America/Los_Angeles) which include underscores.

Replacing underscores with spaces is a more human-readable (and perhaps meaningfully better for things like screen readers, although this is pure speculation).

There's some vague argument against this, like "administrators may need to set a raw internal value in phabricator.timezone and this could mislead them", but we already give a pretty good error message if you do this and could improve hinting if necessary.

Test Plan

Viewed timezone list in Settings and the timezone "reconcile" dialog, saw a more-readable "Los Angeles".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable