Page MenuHomePhabricator

Add a "View Task" button to HTML mail from Maniphest
ClosedPublic

Authored by epriestley on Thu, May 30, 5:15 PM.

Details

Summary

See downstream https://phabricator.wikimedia.org/T1050. Some time ago, we added a "View Revision" button to Differential mail. This hasn't created any problems and generally seems good / desirable.

It isn't trivial to just add everywhere since we need a translation string in each case, but at least add it to Maniphest for now. Going forward, we can fill in more applications as they come up.

Test Plan

Used bin/mail show-outbound --id <x> --dump-html:

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 30, 5:15 PM
epriestley requested review of this revision.Thu, May 30, 5:16 PM
amckinley accepted this revision.Thu, May 30, 7:06 PM

Shouldn't DifferentialTransactionEditor->buildMailBody() get an update to use this new API?

This revision is now accepted and ready to land.Thu, May 30, 7:06 PM

Oh, sure, that's pretty reasonable.

  • Share more API in Differential.
  • Add support in Diffusion for good measure.
This revision was automatically updated to reflect the committed changes.