Page MenuHomePhabricator

Add a "View Task" button to HTML mail from Maniphest
ClosedPublic

Authored by epriestley on May 30 2019, 5:15 PM.
Tags
None
Referenced Files
F18803955: D20561.id49053.diff
Sat, Oct 18, 5:06 AM
F18764133: D20561.id49052.diff
Tue, Oct 7, 4:27 AM
F18683075: D20561.id49047.diff
Fri, Sep 26, 7:01 AM
F18672264: D20561.id.diff
Thu, Sep 25, 7:08 AM
F18644307: D20561.diff
Sep 19 2025, 4:50 AM
F18616730: D20561.diff
Sep 14 2025, 6:48 PM
F18601223: D20561.diff
Sep 13 2025, 11:51 AM
F18570296: D20561.id49053.diff
Sep 10 2025, 3:20 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T1050. Some time ago, we added a "View Revision" button to Differential mail. This hasn't created any problems and generally seems good / desirable.

It isn't trivial to just add everywhere since we need a translation string in each case, but at least add it to Maniphest for now. Going forward, we can fill in more applications as they come up.

Test Plan

Used bin/mail show-outbound --id <x> --dump-html:

Screen Shot 2019-05-30 at 10.11.35 AM.png (478×616 px, 95 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Shouldn't DifferentialTransactionEditor->buildMailBody() get an update to use this new API?

This revision is now accepted and ready to land.May 30 2019, 7:06 PM

Oh, sure, that's pretty reasonable.

  • Share more API in Differential.
  • Add support in Diffusion for good measure.