Page MenuHomePhabricator

Add a "View Task" button to HTML mail from Maniphest
ClosedPublic

Authored by epriestley on May 30 2019, 5:15 PM.
Tags
None
Referenced Files
F19304711: D20561.id49047.diff
Wed, Dec 24, 3:20 PM
F19151828: D20561.diff
Dec 10 2025, 10:51 PM
F19151816: D20561.diff
Dec 10 2025, 10:49 PM
F19104487: D20561.id49047.diff
Dec 5 2025, 2:18 PM
F19075173: D20561.diff
Dec 1 2025, 8:48 AM
F19075153: D20561.diff
Dec 1 2025, 8:40 AM
F19075148: D20561.diff
Dec 1 2025, 8:38 AM
F19075135: D20561.diff
Dec 1 2025, 8:36 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T1050. Some time ago, we added a "View Revision" button to Differential mail. This hasn't created any problems and generally seems good / desirable.

It isn't trivial to just add everywhere since we need a translation string in each case, but at least add it to Maniphest for now. Going forward, we can fill in more applications as they come up.

Test Plan

Used bin/mail show-outbound --id <x> --dump-html:

Screen Shot 2019-05-30 at 10.11.35 AM.png (478×616 px, 95 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Shouldn't DifferentialTransactionEditor->buildMailBody() get an update to use this new API?

This revision is now accepted and ready to land.May 30 2019, 7:06 PM

Oh, sure, that's pretty reasonable.

  • Share more API in Differential.
  • Add support in Diffusion for good measure.