Page MenuHomePhabricator

Add "bin/herald rule ..." to modify Herald rules from the CLI
ClosedPublic

Authored by epriestley on Fri, May 31, 2:59 PM.

Details

Summary

Depends on D20566. Ref T13298. See PHI1280. Currently, there's no clean way to disable problematic personal rules. This comes up occasionally and sometimes isn't really the best approach to solving a problem, but is a generally reasonable capability to provide.

Allow Herald rules (including personal rules) to be disabled/enabled via bin/herald rule ... --disable/--enable.

Test Plan

Used the CLI to disable and enable a personal rule.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, May 31, 2:59 PM
epriestley requested review of this revision.Fri, May 31, 3:01 PM
jmeador added inline comments.
src/applications/herald/management/HeraldRuleManagementWorkflow.php
39

Not sure if there's a translation here, but the grammar seems a bit icky.

78

Assuming exmaple is the British spelling of example.

epriestley updated this revision to Diff 49061.Fri, May 31, 4:32 PM
  • Wordsmithing.
amckinley accepted this revision.Sun, Jun 2, 8:33 AM
amckinley added inline comments.
src/applications/herald/management/HeraldRuleManagementWorkflow.php
39

Yeah, "a rule" seems to have been the intent.

This revision is now accepted and ready to land.Sun, Jun 2, 8:33 AM
epriestley added a comment.EditedSun, Jun 2, 2:30 PM

Oh, I edited "an to edit" into "an rule to edit" or something. Perhaps not my greatest work.

epriestley updated this revision to Diff 49064.Tue, Jun 4, 2:02 PM
  • More wordsmithing.