Page MenuHomePhabricator

Improve Herald profiling information available in transcripts
Closed, ResolvedPublic

Description

See PHI1280. An install is seeing slow (~20s transcript total time) evaluation from Herald but we currently don't provide the tools to dig into this and understand it.

These tools have to be a bit involved: we can't just time each rule, because rules share conditions, and building the field value for a condition is often the most expensive part. Conditions are also evaluated lazily, and rule and condition evaluation may trigger evaluation of other rules or conditions via [ Another Herald rule ].

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision

Event Timeline

epriestley triaged this task as Normal priority.May 27 2019, 2:54 PM
epriestley created this task.
epriestley added a revision: Restricted Differential Revision.May 31 2019, 2:33 PM
epriestley added a revision: Restricted Differential Revision.May 31 2019, 2:59 PM
epriestley added a commit: Restricted Diffusion Commit.Jun 4 2019, 2:12 PM
epriestley added a commit: Restricted Diffusion Commit.Jun 5 2019, 3:50 PM
epriestley closed this task as Resolved.EditedNov 7 2020, 12:09 AM
epriestley claimed this task.

The profiling in D20566 seems satisfactory, and has been useful in resolving or understanding a few performance-related issues.