Page MenuHomePhabricator

Require valid comments to contain at least one non-whitespace character
ClosedPublic

Authored by epriestley on May 30 2019, 7:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 1, 2:14 PM
Unknown Object (File)
Tue, Jun 28, 4:15 PM
Unknown Object (File)
Sat, Jun 25, 7:39 AM
Unknown Object (File)
Thu, Jun 23, 7:05 PM
Unknown Object (File)
Tue, Jun 21, 11:00 PM
Unknown Object (File)
Sun, Jun 19, 6:05 PM
Unknown Object (File)
Thu, Jun 16, 6:27 AM
Unknown Object (File)
Wed, Jun 15, 12:05 PM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T88655. This is very marginal, but we currently allow comments consisting of only whitespace.

These are probably always mistakes, so treat them like completely empty comments.

(We intentionally do not trim leading or trailing whitespace from comments when posting them becuase leading spaces can be used to trigger codeblock formatting.)

Test Plan
  • Posted empty, nonempty, and whitespace-only comments.
  • Whitespace-only comments now have the same behavior as truly empty comments (e.g., do not actually generate a transaction).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable