Page MenuHomePhabricator

When triggering audits, count "Accepted" revisions as successfully reviewed
ClosedPublic

Authored by epriestley on May 30 2019, 11:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 7:19 AM
Unknown Object (File)
Fri, Dec 20, 5:05 PM
Unknown Object (File)
Mon, Dec 16, 12:40 PM
Unknown Object (File)
Mon, Dec 16, 4:50 AM
Unknown Object (File)
Fri, Dec 13, 4:46 PM
Unknown Object (File)
Thu, Dec 12, 10:55 PM
Unknown Object (File)
Thu, Dec 12, 10:55 PM
Unknown Object (File)
Sat, Dec 7, 8:21 PM
Subscribers
None

Details

Summary

See PHI1118. That issue may describe more than one bug, but the recent ordering changes to the import pipeline likely make this at least part of the problem.

Previously, commits would always close associated revisions before we made it to the "publish" step. This is no longer true, so we might be triggering audits on a commit before the associated revision actually closes.

Accommodate this by counting a revision in either "Accepted" or "Published (Was Previously Accepted)" as "reviewed".

Test Plan
  • With commit C affecting paths in package P with "Audit Unreviewed Commits and Commits With No Owner Involvement", associated with revision R, with both R and C authored by the same user, and "R" in the state "Accepted", used bin/repository reparse --publish <hash> to republish the commit.
  • Before change: audit by package P triggered.
  • After change: audit by package P no longer triggered.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable