Page MenuHomePhabricator
Differential D20558

Test for "CAN_INTERACT" on comment edits in a way that survives objects which only implement "CAN_VIEW"
ClosedPublicDraft
Actions

Authored by epriestley on May 28 2019, 5:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 12:48 PM
Unknown Object (File)
Mon, Nov 11, 2:13 AM
Unknown Object (File)
Mon, Nov 11, 12:37 AM
Unknown Object (File)
Oct 24 2024, 11:35 AM
Unknown Object (File)
Oct 22 2024, 11:03 AM
Unknown Object (File)
Oct 21 2024, 4:33 PM
Unknown Object (File)
Oct 9 2024, 12:23 PM
Unknown Object (File)
Oct 9 2024, 12:23 PM
View All Files
Subscribers
None
Tokens
"Manufacturing Defect?" token, awarded by amckinley.

Details

Reviewers
amckinley
Maniphest Tasks
T13289: Plans: 2019 Week 21-23 Bonus Content
Commits
rP53b9acfb7d58: Test for "CAN_INTERACT" on comment edits in a way that survives objects which…
Summary

Ref T13289. See D20551. In D20551, I implemented some "CAN_INTERACT" checks against certain edits, but these checks end up testing "CAN_INTERACT" against objects like Conpherence threads which do not support a distinct "CAN_INTERACT" permission. I misrembered how the "CAN_INTERACT" fallback to "CAN_VIEW" actually works: it's not fully automatic, and needs some explicit "interact, or view if interact is not available" checks.

Use the "interact" wrappers to test these policies so they fall back to "CAN_VIEW" if an object does not support "CAN_INTERACT". Generally, objects which have a "locked" state have a separate "CAN_INTERACT" permission; objects which don't have a "locked" state do not.

Test Plan

Created and edited comments in Conpherence (or most applications other than Maniphest).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 28 2019, 5:14 PM
This revision was not accepted when it landed; it landed in state Draft.May 28 2019, 5:14 PM
This revision was landed with ongoing or failed builds.
Closed by commit rP53b9acfb7d58: Test for "CAN_INTERACT" on comment edits in a way that survives objects which… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP53b9acfb7d58: Test for "CAN_INTERACT" on comment edits in a way that survives objects which….
epriestley added a comment.May 28 2019, 5:18 PM

I just landed this since comments won't work without it, yell if it seems retroactively bad.

epriestley added a comment.May 28 2019, 5:19 PM

Oh, this is also interesting: this never undrafted. We should probably make "land" force things to undraft.

Harbormaster completed remote builds in B22915: Diff 49042.May 28 2019, 5:19 PM
amckinley awarded a token.May 28 2019, 5:20 PM
epriestley mentioned this in T13300: When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promote.May 28 2019, 5:22 PM
epriestley mentioned this in D20648: Update one straggling "CAN_INTERACT" check in comment removal.Jul 11 2019, 10:51 PM
epriestley mentioned this in rPaacc62463d61: Prevent editing and deleting comments in locked conversations.Jul 11 2019, 10:53 PM
epriestley mentioned this in rP41ea204144ab: Update one straggling "CAN_INTERACT" check in comment removal.Jul 11 2019, 11:10 PM

Revision Contents
Changeset List

Diff 49043

View Options

src/applications/policy/filter/PhabricatorPolicyFilter.php

Loading...
View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Loading...
Phabricator · Built by Phacility