Page MenuHomePhabricator

Herald only triggers for commits once, during the initial publish phase
Open, NormalPublic

Description

Long ago, Herald had some inconsistent behaviors:

  • For commits, it triggered (at most) once when the commit was discovered.
  • For revisions, it triggered when the revision was updated.
  • For other objects, it triggered on every update.

We've removed the inconsistency in revision behavior and Differential now triggers on every update.

Commits should probably also trigger on every update, so you can write rules like [ Project tags ][ include ][ xyz ] and get an action if someone later adds that tag to a commit. However, if we just ship this, existing rules like "Run Build Plan" will start firing on every comment.

We also would probably need a "commit is published" condition. This is pretty much the same as T13041 so maybe we could just reuse that?

This is easy, but disruptive, and seems generally very low-priority since it primarily serves the idol of consistency today rather than any actual use cases.


Related, see PHI1264. If users interact with an unpublished commit after it has imported, it currently does not send email/notifications/etc. This is incorrect: explicit user interaction with unpublished commits should work normally.

Event Timeline

epriestley triaged this task as Normal priority.May 27 2019, 3:34 PM
epriestley created this task.
epriestley updated the task description. (Show Details)Sep 25 2019, 4:00 PM
epriestley added a subscriber: mves.

I've moved the issue in PHI1264 (roughly, "commenting on an unpublished commit should still work normally") here from T13284, since it ended up not really fitting into that scope particularly well.