Page MenuHomePhabricator

When a revision is closed, always promote it out of draft
ClosedPublic

Authored by epriestley on May 31 2019, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 5:18 AM
Unknown Object (File)
Sat, Jan 25, 8:48 AM
Unknown Object (File)
Sat, Jan 25, 5:11 AM
Unknown Object (File)
Sat, Jan 25, 5:11 AM
Unknown Object (File)
Sat, Jan 25, 5:10 AM
Unknown Object (File)
Sat, Jan 25, 5:10 AM
Unknown Object (File)
Mon, Dec 30, 4:08 AM
Unknown Object (File)
Mon, Dec 30, 12:36 AM
Subscribers
None

Details

Summary

Fixes T13300. Currently, if you create a revision and then immediately land it (either using --draft or just beating Harbormaster to the punch) it can be stuck in "Draft" forever.

Instead, count landing changes like this as a publishing action.

Test Plan
  • Used arc diff --hold to create a revision, then pushed the commit immediately.
  • Before change: revision closed, but was stuck in draft.
  • After change: revision closed and was promoted out of draft.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable