Page MenuHomePhabricator

When a revision is closed, always promote it out of draft
ClosedPublic

Authored by epriestley on May 31 2019, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 31, 8:30 PM
Unknown Object (File)
Sat, May 31, 8:22 PM
Unknown Object (File)
May 27 2025, 8:28 AM
Unknown Object (File)
May 26 2025, 6:31 PM
Unknown Object (File)
May 9 2025, 2:58 PM
Unknown Object (File)
May 7 2025, 1:17 PM
Unknown Object (File)
Apr 29 2025, 1:58 AM
Unknown Object (File)
Apr 21 2025, 9:36 PM
Subscribers
None

Details

Summary

Fixes T13300. Currently, if you create a revision and then immediately land it (either using --draft or just beating Harbormaster to the punch) it can be stuck in "Draft" forever.

Instead, count landing changes like this as a publishing action.

Test Plan
  • Used arc diff --hold to create a revision, then pushed the commit immediately.
  • Before change: revision closed, but was stuck in draft.
  • After change: revision closed and was promoted out of draft.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable