Page MenuHomePhabricator

When a revision is closed, always promote it out of draft
ClosedPublic

Authored by epriestley on May 31 2019, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 11:55 AM
Unknown Object (File)
Sat, Apr 6, 7:57 AM
Unknown Object (File)
Tue, Apr 2, 12:44 AM
Unknown Object (File)
Sat, Mar 30, 10:47 PM
Unknown Object (File)
Sat, Mar 23, 7:22 AM
Unknown Object (File)
Sat, Mar 23, 7:22 AM
Unknown Object (File)
Feb 9 2024, 2:36 PM
Unknown Object (File)
Jan 25 2024, 4:11 AM
Subscribers
None

Details

Summary

Fixes T13300. Currently, if you create a revision and then immediately land it (either using --draft or just beating Harbormaster to the punch) it can be stuck in "Draft" forever.

Instead, count landing changes like this as a publishing action.

Test Plan
  • Used arc diff --hold to create a revision, then pushed the commit immediately.
  • Before change: revision closed, but was stuck in draft.
  • After change: revision closed and was promoted out of draft.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable