Page MenuHomePhabricator

When a revision is closed, always promote it out of draft
ClosedPublic

Authored by epriestley on May 31 2019, 1:18 PM.
Tags
None
Referenced Files
F18001858: D20565.id.diff
Sat, Aug 2, 9:22 AM
F17982390: D20565.diff
Fri, Aug 1, 7:24 PM
F17829378: D20565.id49063.diff
Jul 26 2025, 10:03 AM
Unknown Object (File)
May 31 2025, 8:30 PM
Unknown Object (File)
May 31 2025, 8:22 PM
Unknown Object (File)
May 27 2025, 8:28 AM
Unknown Object (File)
May 26 2025, 6:31 PM
Unknown Object (File)
May 9 2025, 2:58 PM
Subscribers
None

Details

Summary

Fixes T13300. Currently, if you create a revision and then immediately land it (either using --draft or just beating Harbormaster to the punch) it can be stuck in "Draft" forever.

Instead, count landing changes like this as a publishing action.

Test Plan
  • Used arc diff --hold to create a revision, then pushed the commit immediately.
  • Before change: revision closed, but was stuck in draft.
  • After change: revision closed and was promoted out of draft.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable