Page MenuHomePhabricator

When a revision is closed, always promote it out of draft
ClosedPublic

Authored by epriestley on May 31 2019, 1:18 PM.
Tags
None
Referenced Files
F19045290: D20565.id.diff
Thu, Nov 27, 7:04 AM
F19037673: D20565.id.diff
Wed, Nov 26, 1:03 AM
F19017173: D20565.id.diff
Nov 23 2025, 6:56 AM
F18996396: D20565.diff
Nov 20 2025, 3:04 AM
F18872237: D20565.id.diff
Nov 5 2025, 3:04 AM
F18847019: D20565.id49063.diff
Oct 29 2025, 10:26 PM
F18755169: D20565.id49058.diff
Oct 5 2025, 4:05 AM
F18630088: D20565.diff
Sep 16 2025, 10:44 AM
Subscribers
None

Details

Summary

Fixes T13300. Currently, if you create a revision and then immediately land it (either using --draft or just beating Harbormaster to the punch) it can be stuck in "Draft" forever.

Instead, count landing changes like this as a publishing action.

Test Plan
  • Used arc diff --hold to create a revision, then pushed the commit immediately.
  • Before change: revision closed, but was stuck in draft.
  • After change: revision closed and was promoted out of draft.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable