I'm going to push this out to next week since D19586 probably has a few minor issues with it and it's close to the release cut. It adds a lot of new policy checks which weren't explicit before, so I'd guess it may cause a few improper policy errors on things which are actually allowed. I caught a bunch of them (like "Mute Thread") but probably didn't get every single one.

These are actually removed in 2018 Week 33. See T13186 for a small amount of followup and discussion, although there isn't too much new information beyond what's here.

I think everything we know about has been resolved.

@epriestley
After i upgraded my application to the newest version，which swap the search engine to ‘Ferret’，I reindexed several times，but I can not get any result.These is my version information：
phabricator33756bcf1d70ea5579dff1ab276bbe660d10494c (Tue, Oct 3) (branched from f9110b87abf337dd1e7714d755775e53cffd4db9 on origin)arcanist0a7f403333fe9082b39bd007b9d5f9e765c8b9ce (Tue, Oct 3) (branched from c804c5026011f27614a7bbdb2bb32cab590d68ca on origin)phutilb400c6b04bb247a3e0f1941390bc450f36ac2ccd (Tue, Oct 3) (branched from 9f9c33797a3ebbf1c4dcaa474a0c4e0b32d5396a on origin)diff2.8.1 at /usr/bin/diffgit1.7.1 at /usr/bin/githgNot Availablepygmentize2.0.2 at /usr/bin/pygmentizesvn1.6.11 at /usr/bin/svn

Looks to be caused by this commit rPb75a4151c8996c5dfb1c8c14378fe3259666eac2

https://discourse.phabricator-community.org/t/daemons-tasks-crashing-in-a-loop-during-reindex/506

Running the reindex led to a couple crash looping tasks on my end:

In T12974#231875, @saggid wrote:

Very intresting update. Now we can search in projects code, as i see? Thanks for this supir dupir project guys)

Very intresting update. Now we can search in projects code, as i see? Thanks for this supir dupir project guys)

kind of sad this isn't called pherret

This seems to have calmed down.

In https://hackerone.com/reports/259246 (not currently disclosed) a researcher found an actual issue with figlet. Although it would probably be hard to develop into a practical attack, it does make me feel better about the decision to pull all this stuff into PHP (not just dot) when the dot issue was originally identified.

Maybe I'll put it on A, I guess ("Toggle All"), so it's sort of near q, which is similar (collapse/expand).

Toggle each individual comment's visibility to the opposite but only if it's not for the current diff~

If it's a toggle, what do you expect us to do if you press it with some inlines hidden and others visible?

Is there opportunity for a hotkey to hide/show all inline comments? Or since it's accessible from the topbar is the intent not to add hotkeys?

+1 for not adding undo behaviour. I too avoid yellow undo bars by saving empty comments. Alternatively, I guess, you could put a "Permanently delete" link in the undo bar so with one extra click you could whisk it away (which actually would be easier than going through the edit, empty, save dance).

Well, I'm half mistaken. What you're seeing is a bug.

(Oh, no, I'm mistaken.)

Removing the text and re-saving the inline comment is supposed to enable an Undo? Hmm..

That's supposed to leave an "Undo" bar, still want us to fix the bug?

(I can reproduce on this install)

I think I found a minor bug. If I'm fairly confident that I want to remove my draft inline comment I'll Edit → Delete Text → Save rather than just Trash - I think just so I don't end up with that yellow box that asks if I want to Undo.

One of our engineers is having a similar issue with slightly different error, running "arc install-certificate" would always fail with the following error:

This might not be totally related but

1. I really love being able to see the filename while scrolling through files
2. It would be useful to have something similar to Diffusion's File Search on a Differential revision, to quickly jump to files based on name. The f sidebar helps a little but it's organized in a file-system layout which means the folder location needs to be known.

In D18112 I've marked 3 items as done (unsubmitted), but the header bar is still white, my expectation is it turns yellow.

The objectives UI wasn't solving any specific problem or really motivated by any particular request, I largely just wanted to try it out and see if it made it a little easier to navigate diffs in general. I think at least some of the feedback in the vein of T8250 is roughly "it's hard to see the big picture when changes have a lot of comments", and it seemed worth trying to see if we could make the big picture a little more clear without splitting the UI apart completely. Some (most?) IDEs have similar features, where either things like functions/classes, or lint warnings, or compile errors, are marked in the scrollbar or a small view of the file is shown:

Is there a pre-cursor to D17955 I should read up on? Or was T8250 the main impetus?

I could go either way. At least 0/2 feels bad since it then gives the impression we think you should be marking stuff done. Let's just kill the 0/2 case. Only show / if 1 is marked done and see how that feels. I can clean up the UI before cut too.

If you haven't checked anything and are the author (i.e., today, button is visible and says "0 / 2"), clicking it takes you to the first inline. That's at least a plausibly useful behavior?

I probably should spend more time thinking about this UI, or maybe I should have taken more notes when I designed it.

"3 Unsubmitted" is the three synthetic lint about "TODO"s in the code (see T12806).

On D18102 I see other people's unsaved comments, I think. I also expect 0/2 to only be visible to the whoever can mark stuff done. Otherwise maybe just 2 or nothing?

Comments are fine.

Clicking "Cancel" after starting an inline comment leaves "0/1 Comments" in header. (do you want tasks or comments for these issues?)

You can leave comments on the left hand side of a 2-up view -- that is, scrolling in EITHER of these areas on 2-up would trigger the problem:

We could change the behavior to "tap and hold to begin a range + drag".

Unless they have some seriously alien hands and an predilection to scroll in the middle of the screen

In T12733#224703, @epriestley wrote:

As such, I think it's reasonable to expect Differential to serve a more shallow role on small devices, more akin to "keeping abreast of changes" than "performing detailed review", and reasonable to not try to support every review feature on mobile, since these devices are secondary/support devices until everyone gets really excited about coding on the go using their thumbs, a virtual keyboard, and a tiny screen.

I'd be fine removing the range select on mobile.

I understand why the behavior has changed, and I'm not particularly opposed to keeping it as-is. I can easily reach over the line number - it's just that it initially appeared as a regression so I had to note it here.

This is an intentional change to address T1026 (allowing inline ranges to be added via touchscreen devices). Previously, it wasn't possible to comment on a range of lines on, e.g., an iPhone/iPad.

On mobile I very quickly get an inline comment box when scrolling which then takes focus so scrolling is aborted.

Synthetic comments (made by lint) are currently shown in the sidebar annotation with a pencil ( ) icon.

• The persistent header should now select more intuitive changesets.
• The scrollbar annotation is now disabled for trackpad "aesthetic" scrollbars (like the 0-width scrollbar on OSX if you don't have a mouse connected to your laptop). If we retain the element, I plan to enable it eventually, it just requires us to move content around and generally make a larger change.
• The scrollbar annotation is now disabled unless phabricator.show-prototypes is enabled.
• The scrollbar annotation should generally work better and be more useful now.
• I've deployed these changes to this host.

This is pretty awesome improvement! Small feedback, the new scrollbar area is a bit hard to use on Safari with Apple's disappearing/reappearing scrollbars. They end up overlapping and it can make the Phabricator scrollbar area harder to use/click on etc. Would be nice if the scrollbar area shifted left while scrolling or if it were on the left side of the screen or some other magical solution.