Page MenuHomePhabricator

Clean up virtual "_ft_rank" column for query construction of Ferret objects
ClosedPublic

Authored by epriestley on Oct 23 2017, 10:09 PM.
Tags
None
Referenced Files
F18091801: D18728.id44955.diff
Thu, Aug 7, 12:54 AM
F18090969: D18728.diff
Wed, Aug 6, 6:19 PM
F17986434: D18728.id44957.diff
Fri, Aug 1, 9:22 PM
F17958659: D18728.id.diff
Fri, Aug 1, 7:12 AM
F17940795: D18728.diff
Thu, Jul 31, 4:45 AM
F17831053: D18728.diff
Jul 26 2025, 11:39 AM
F17760106: D18728.diff
Jul 22 2025, 7:13 PM
F17708011: D18728.id44955.diff
Jul 16 2025, 4:03 PM
Subscribers
None

Details

Summary

Ref T12974. Ferret object queries SELECT a virtual "_ft_rank" column for relevance ordering.

Currently, they always SELECT this column. That's fine and doesn't hurt anything, but makes developing and debugging things kind of a pain since every query has this , blah blah _ft_rank junk.

Instead, construct this column only if we're actually going to use it.

Mostly, this cleans up DarkConsole / query logs a bit.

Test Plan

Viewed normal query results on various pages, viewed global search results, ordered Maniphest tasks by normal stuff and by "Relevance".

Viewed DarkConsole, saw no more "_ft_rank" junk on normal pages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster completed remote builds in B18735: Diff 44955.
This revision is now accepted and ready to land.Oct 23 2017, 11:00 PM
This revision was automatically updated to reflect the committed changes.