Page MenuHomePhabricator

Clean up virtual "_ft_rank" column for query construction of Ferret objects
ClosedPublic

Authored by epriestley on Oct 23 2017, 10:09 PM.
Tags
None
Referenced Files
F19821708: D18728.diff
Sat, Mar 7, 12:02 AM
F19812592: D18728.diff
Wed, Mar 4, 5:33 AM
F19745556: D18728.diff
Sun, Feb 15, 3:44 PM
F19507880: D18728.id44957.diff
Jan 9 2026, 11:54 PM
F19507879: D18728.id44955.diff
Jan 9 2026, 11:54 PM
F19507878: D18728.id.diff
Jan 9 2026, 11:54 PM
F19507877: D18728.diff
Jan 9 2026, 11:54 PM
F19154285: D18728.id44957.diff
Dec 11 2025, 2:09 PM
Subscribers
None

Details

Summary

Ref T12974. Ferret object queries SELECT a virtual "_ft_rank" column for relevance ordering.

Currently, they always SELECT this column. That's fine and doesn't hurt anything, but makes developing and debugging things kind of a pain since every query has this , blah blah _ft_rank junk.

Instead, construct this column only if we're actually going to use it.

Mostly, this cleans up DarkConsole / query logs a bit.

Test Plan

Viewed normal query results on various pages, viewed global search results, ordered Maniphest tasks by normal stuff and by "Relevance".

Viewed DarkConsole, saw no more "_ft_rank" junk on normal pages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster completed remote builds in B18735: Diff 44955.
This revision is now accepted and ready to land.Oct 23 2017, 11:00 PM
This revision was automatically updated to reflect the committed changes.