Page MenuHomePhabricator

Clean up virtual "_ft_rank" column for query construction of Ferret objects
ClosedPublic

Authored by epriestley on Oct 23 2017, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:55 PM
Unknown Object (File)
Tue, Apr 2, 8:39 AM
Unknown Object (File)
Tue, Apr 2, 8:39 AM
Unknown Object (File)
Sat, Mar 30, 5:18 AM
Unknown Object (File)
Mar 23 2024, 5:06 AM
Unknown Object (File)
Mar 20 2024, 8:43 PM
Unknown Object (File)
Feb 3 2024, 5:05 PM
Unknown Object (File)
Jan 25 2024, 12:37 AM
Subscribers
None

Details

Summary

Ref T12974. Ferret object queries SELECT a virtual "_ft_rank" column for relevance ordering.

Currently, they always SELECT this column. That's fine and doesn't hurt anything, but makes developing and debugging things kind of a pain since every query has this , blah blah _ft_rank junk.

Instead, construct this column only if we're actually going to use it.

Mostly, this cleans up DarkConsole / query logs a bit.

Test Plan

Viewed normal query results on various pages, viewed global search results, ordered Maniphest tasks by normal stuff and by "Relevance".

Viewed DarkConsole, saw no more "_ft_rank" junk on normal pages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster completed remote builds in B18735: Diff 44955.
This revision is now accepted and ready to land.Oct 23 2017, 11:00 PM
This revision was automatically updated to reflect the committed changes.