Page MenuHomePhabricator

Clean up virtual "_ft_rank" column for query construction of Ferret objects
ClosedPublic

Authored by epriestley on Oct 23 2017, 10:09 PM.
Tags
None
Referenced Files
F15425613: D18728.diff
Sun, Mar 23, 5:02 AM
F15381318: D18728.diff
Fri, Mar 14, 7:02 AM
F15376798: D18728.id44957.diff
Thu, Mar 13, 5:39 AM
Unknown Object (File)
Feb 9 2025, 4:13 AM
Unknown Object (File)
Feb 7 2025, 4:47 PM
Unknown Object (File)
Jan 31 2025, 1:16 PM
Unknown Object (File)
Jan 27 2025, 8:43 AM
Unknown Object (File)
Jan 21 2025, 7:45 PM
Subscribers
None

Details

Summary

Ref T12974. Ferret object queries SELECT a virtual "_ft_rank" column for relevance ordering.

Currently, they always SELECT this column. That's fine and doesn't hurt anything, but makes developing and debugging things kind of a pain since every query has this , blah blah _ft_rank junk.

Instead, construct this column only if we're actually going to use it.

Mostly, this cleans up DarkConsole / query logs a bit.

Test Plan

Viewed normal query results on various pages, viewed global search results, ordered Maniphest tasks by normal stuff and by "Relevance".

Viewed DarkConsole, saw no more "_ft_rank" junk on normal pages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster completed remote builds in B18735: Diff 44955.
This revision is now accepted and ready to land.Oct 23 2017, 11:00 PM
This revision was automatically updated to reflect the committed changes.