Page MenuHomePhabricator

Remove deprecated Maniphest "Can Edit <Specific Property>" capabilities
ClosedPublic

Authored by epriestley on Aug 14 2018, 5:52 PM.
Tags
None
Referenced Files
F19508280: D19581.diff
Sat, Jan 10, 2:33 AM
F19097629: D19581.diff
Dec 4 2025, 2:08 PM
F19086303: D19581.diff
Dec 2 2025, 9:06 PM
F19018284: D19581.id46812.diff
Nov 23 2025, 10:38 AM
F19015075: D19581.diff
Nov 22 2025, 10:32 PM
F18871647: D19581.id.diff
Nov 4 2025, 11:53 PM
F18865689: D19581.diff
Nov 3 2025, 1:31 PM
F18861753: D19581.diff
Nov 2 2025, 4:28 PM
Subscribers

Details

Summary

Depends on D19579. Fixes T10003. These have been deprecated with a setup warning about their impending removal for about two and a half years.

Ref T13164. See PHI642. My overall goal here is to simplify how we handle transactions which have special policy behaviors. In particular, I'm hoping to replace ApplicationTransactionEditor->requireCapabilities() with a new, more clear policy check.

A problem with requireCapabilities() is that it doesn't actually enforce any policies in almost all cases: the default is "nothing", not CAN_EDIT. So it ends up looking like it's the right place to specialize policy checks, but it usually isn't.

For "Disable", I need to be able to weaken the check selectively (you can disable users if you have the permission, even if you can't edit them otherwise). We have a handful of other edits which work like this (notably, leaving and joining projects) but they're very rare.

Test Plan

Grepped for all removed classes. Edited a Maniphest task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable