Page MenuHomePhabricator

Remove deprecated Maniphest "Can Edit <Specific Property>" capabilities
ClosedPublic

Authored by epriestley on Aug 14 2018, 5:52 PM.
Tags
None
Referenced Files
F18112818: D19581.diff
Tue, Aug 12, 9:03 PM
F18092334: D19581.id46835.diff
Thu, Aug 7, 9:38 AM
F18052225: D19581.id.diff
Mon, Aug 4, 1:55 AM
F17836991: D19581.id.diff
Jul 26 2025, 4:47 PM
F17831281: D19581.id46835.diff
Jul 26 2025, 11:51 AM
F17810863: D19581.diff
Jul 25 2025, 5:58 PM
F17711951: D19581.diff
Jul 17 2025, 9:20 AM
Unknown Object (File)
Jul 5 2025, 1:55 PM
Subscribers

Details

Summary

Depends on D19579. Fixes T10003. These have been deprecated with a setup warning about their impending removal for about two and a half years.

Ref T13164. See PHI642. My overall goal here is to simplify how we handle transactions which have special policy behaviors. In particular, I'm hoping to replace ApplicationTransactionEditor->requireCapabilities() with a new, more clear policy check.

A problem with requireCapabilities() is that it doesn't actually enforce any policies in almost all cases: the default is "nothing", not CAN_EDIT. So it ends up looking like it's the right place to specialize policy checks, but it usually isn't.

For "Disable", I need to be able to weaken the check selectively (you can disable users if you have the permission, even if you can't edit them otherwise). We have a handful of other edits which work like this (notably, leaving and joining projects) but they're very rare.

Test Plan

Grepped for all removed classes. Edited a Maniphest task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable