Page MenuHomePhabricator

Remove obsolete, nonfunctional draft auto-saving in Phriction
ClosedPublic

Authored by epriestley on Sep 11 2018, 4:39 PM.

Details

Summary

Depends on D19660. Ref T5811. Ref T13077.

Long ago, if you started editing a Phriction document but didn't save it, we'd save the draft in the background as part of the preview.

D11169 updated the preview to use shared infrastructure and broke this function, since we never save drafts.

Since this doesn't work right now, I want to add another thing called "draft", and the future of this feature should be more integrated with modern drafts and EditEngine (which fixed some bugs related to versioning), just get rid of this code for the moment.

Test Plan

Edited documents. This code doesn't do anything since D11169, so no behavior changed.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 11 2018, 4:39 PM
epriestley requested review of this revision.Sep 11 2018, 4:40 PM
amckinley accepted this revision.Sep 11 2018, 7:25 PM
This revision is now accepted and ready to land.Sep 11 2018, 7:25 PM
epriestley edited the summary of this revision. (Show Details)Sep 12 2018, 8:21 PM
This revision was automatically updated to reflect the committed changes.