Page MenuHomePhabricator

Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email
ClosedPublic

Authored by epriestley on Feb 16 2018, 1:18 PM.
Tags
None
Referenced Files
F22601286: D19105.diff
Mon, Sep 28, 6:24 PM
Unknown Object (File)
Sun, Sep 6, 3:09 AM
Unknown Object (File)
Aug 22 2026, 1:05 AM
Unknown Object (File)
Aug 19 2026, 5:41 AM
Unknown Object (File)
Aug 14 2026, 5:06 AM
Unknown Object (File)
Jul 12 2026, 7:28 PM
Unknown Object (File)
Jul 11 2026, 5:52 PM
Unknown Object (File)
Jul 11 2026, 12:16 AM
Subscribers
None

Details

Summary

Fixes T10969. Ref T13077. When you create a Phriction document with a relative link ([[ ./path/to/page ]]) the initial email currently points to the wrong place.

This is because the context object (the page) isn't passed to the markup engine. Without this context, the relative link is rendered as though it appeared somewhere else (like a task or revision) where relative links don't make sense.

Test Plan

Created a new Phriction document with a relative link to [[ ./porcupine_facts/starmap ]], saw a usable link in the resulting email.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable