Page MenuHomePhabricator

Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email

Authored by epriestley on Feb 16 2018, 1:18 PM.



Fixes T10969. Ref T13077. When you create a Phriction document with a relative link ([[ ./path/to/page ]]) the initial email currently points to the wrong place.

This is because the context object (the page) isn't passed to the markup engine. Without this context, the relative link is rendered as though it appeared somewhere else (like a task or revision) where relative links don't make sense.

Test Plan

Created a new Phriction document with a relative link to [[ ./porcupine_facts/starmap ]], saw a usable link in the resulting email.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 16 2018, 1:18 PM
epriestley requested review of this revision.Feb 16 2018, 1:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 5:55 PM
This revision was automatically updated to reflect the committed changes.