Page MenuHomePhabricator

Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email
ClosedPublic

Authored by epriestley on Feb 16 2018, 1:18 PM.
Tags
None
Referenced Files
F19092753: D19105.id.diff
Dec 3 2025, 6:20 PM
F19085225: D19105.diff
Dec 2 2025, 5:33 PM
F19084846: D19105.diff
Dec 2 2025, 4:35 PM
F19054201: D19105.id45789.diff
Nov 28 2025, 11:06 AM
F19013647: D19105.diff
Nov 22 2025, 4:35 PM
F18970448: D19105.diff
Nov 15 2025, 8:15 AM
F18862270: D19105.id.diff
Nov 2 2025, 6:55 PM
F18836849: D19105.id45789.diff
Oct 27 2025, 3:43 AM
Subscribers
None

Details

Summary

Fixes T10969. Ref T13077. When you create a Phriction document with a relative link ([[ ./path/to/page ]]) the initial email currently points to the wrong place.

This is because the context object (the page) isn't passed to the markup engine. Without this context, the relative link is rendered as though it appeared somewhere else (like a task or revision) where relative links don't make sense.

Test Plan

Created a new Phriction document with a relative link to [[ ./porcupine_facts/starmap ]], saw a usable link in the resulting email.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable