Differential D19115

Provide the document content as a context object when rendering Phriction documents
ClosedPublic
Actions

Authored by epriestley on Feb 16 2018, 8:41 PM.

Tags

None

Referenced Files

	F14757322: D19115.id45806.diff
	Wed, Jan 22, 12:18 AM

	Unknown Object (File)
	Tue, Jan 21, 9:43 AM

	Unknown Object (File)
	Sat, Jan 18, 7:15 AM

	Unknown Object (File)
	Fri, Jan 17, 1:23 PM

	Unknown Object (File)
	Wed, Jan 15, 1:45 PM

	Unknown Object (File)
	Dec 20 2024, 10:53 PM

	Unknown Object (File)
	Dec 20 2024, 11:49 AM

	Unknown Object (File)
	Dec 19 2024, 7:09 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits: rPcb2f7106069b: Provide the document content as a context object when rendering Phriction…

Summary

Ref T13077. The context object wasn't being passed into the engine properly here, affecting relative link rendering in Phriction.

Test Plan

Viewed rendered Phriction documents with relative links, got clean renders.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 16 2018, 8:41 PM

Harbormaster completed remote builds in B19609: Diff 45805.Feb 16 2018, 8:42 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 8:42 PM

epriestley requested review of this revision.

Closed by commit rPcb2f7106069b: Provide the document content as a context object when rendering Phriction… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

storage/

PhrictionContent.php

1 line

Diff 45806

View Options

src/applications/phriction/storage/PhrictionContent.php

Provide the document content as a context object when rendering Phriction documentsClosedPublicActions