Page MenuHomePhabricator

Move PhrictionContent from RemarkupInterface (deprecated) to PHUIRemarkupView
ClosedPublic

Authored by epriestley on Feb 15 2018, 12:46 PM.

Details

Summary

Depends on D19092. Ref T13077. This modernizes markup rendering for PhrictionContent.

This is a little messy because table of contents generation isn't straightforward.

Test Plan

Viewed Phriction documents with and without 3+ headers, saw ToC vs no ToC. Edited/previewed documents. Grepped for affected symbols. Checked DarkConsole for sensible cache behavior.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 15 2018, 12:46 PM
epriestley requested review of this revision.Feb 15 2018, 12:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 1:40 AM
This revision was automatically updated to reflect the committed changes.