Page MenuHomePhabricator

Give Phriction documents a normal timeline
ClosedPublic

Authored by epriestley on Sep 11 2018, 3:15 PM.
Tags
None
Referenced Files
F15458547: D19659.id46979.diff
Mon, Mar 31, 4:35 AM
F15455630: D19659.id46985.diff
Sun, Mar 30, 3:49 AM
F15436426: D19659.diff
Tue, Mar 25, 2:04 PM
F15409969: D19659.diff
Wed, Mar 19, 6:17 AM
F15361057: D19659.id46979.diff
Tue, Mar 11, 11:40 AM
F15360779: D19659.diff
Tue, Mar 11, 10:13 AM
Unknown Object (File)
Feb 9 2025, 6:29 AM
Unknown Object (File)
Feb 9 2025, 6:29 AM
Subscribers
None

Details

Summary

Ref T13077. See PHI840. Ref T1894. I'm planning to just let you comment on Phriction documents. I think this will create a few problems (e.g., around popular documents which collect long comment threads that are eventually obsolete) but nothing should be too terribly critical (e.g., we handle it gracefully when objects have very large number of comments/transactions) and for most documents this is likely just a net improvement.

"Just enable comments" is probably not the final iteration on this, but I think it's probably a step forward on the balance, not a step sideways or a slippery slope down into a dark hole or anything.

Test Plan

Screen Shot 2018-09-11 at 8.10.33 AM.png (1×1 px, 161 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable