Page MenuHomePhabricator

Let users escape more easily from the autosuggester after typing "[" or "("
ClosedPublic

Authored by epriestley on Feb 16 2018, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:08 PM
Unknown Object (File)
Thu, Dec 19, 7:08 PM
Unknown Object (File)
Thu, Dec 19, 7:08 PM
Unknown Object (File)
Tue, Dec 17, 6:22 AM
Unknown Object (File)
Mon, Dec 16, 8:18 PM
Unknown Object (File)
Wed, Dec 11, 3:50 PM
Unknown Object (File)
Sat, Dec 7, 3:09 AM
Unknown Object (File)
Mon, Dec 2, 8:59 PM
Subscribers
None

Details

Summary

Ref T13077. The autosuggester is a little too eager right now, and will eat carriage returns after typing [ if you never activate the tokenizer.

To fix this, try just canceling sooner. If that doesn't work, we might need to cancel more eagerly by testing to see if the tokenizer is actually open.

Test Plan

Typed [x]<return>, got my return instead of getting trapped by the autosuggester.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Feb 16 2018, 7:02 PM
This revision was automatically updated to reflect the committed changes.