Page MenuHomePhabricator

Work around an issue in MariaDB where dropping a column from a UNIQUE KEY fails
ClosedPublic

Authored by epriestley on Aug 30 2018, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 6:15 AM
Unknown Object (File)
Tue, Dec 31, 9:45 PM
Unknown Object (File)
Tue, Dec 31, 9:45 PM
Unknown Object (File)
Tue, Dec 31, 9:44 PM
Unknown Object (File)
Dec 23 2024, 9:53 AM
Unknown Object (File)
Dec 20 2024, 10:33 PM
Unknown Object (File)
Dec 18 2024, 5:26 AM
Unknown Object (File)
Dec 7 2024, 10:28 AM
Subscribers
Restricted Owners Package

Details

Summary

See T13193. See T13077. If we drop a column which is part of a UNIQUE KEY, MariaDB raises an error.

This is probably a bad idea on our side anyway, but in this case it wasn't an obviously bad idea.

To get around this:

  • Drop the unique key, if it exists, before dropping the column.
  • Explicitly add the new unique key afterward.
Test Plan

Ran bin/storage upgrade locally without issue, but I'm on MySQL. Will follow up on T13193.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable